| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Legacy systems.
|
| |
|
| |
|
|
|
|
|
| |
XFixes only reports cursor changes. We must manually call
XFixesGetCursorImage() when starting.
|
| |
|
|
|
|
|
|
| |
This makes it possible to create a derived class from Socket which is
not TCP based, without having VNCSConnectionST.cxx trying to call
setsockopt() on a non-socket.
|
|
|
|
| |
Define ledNames in XDesktop.cxx, rename N_LEDS to XDESKTOP_N_LEDS
|
| |
|
|
|
|
| |
No need for ifdefs; we can assume MITSHM. Already done in vncviewer.
|
| |
|
|
|
|
|
| |
The normal Xorg server doesn't check this field, so neither can we
as there are applications relying on this leniancy.
|
|
|
|
|
| |
Include the type of exception in the string generated by each
subclass. Also simplify the constructs to what is needed.
|
| |
|
|
|
|
|
| |
Newer CMake complains when you try to get the property of something
that isn't a target so use the specific if operator instead.
|
|
|
|
|
| |
It's not supported in newer CMake, so try to deduce the library
filename from the target name.
|
|
|
|
|
|
| |
It was moved to the common code in f8e3b34c6, but it was unreliable
because the state could sometimes get out of sync. Push it back in
to Xvnc since it isn't necessarily something all servers will have.
|
|
|
|
|
| |
Otherwise we'll wedge the desktop object which expects an approval
or rejection to eventually show up.
|
|
|
|
|
| |
Don't touch the existing value or we might mess it up when we avoid
division by zero.
|
|
|
|
|
| |
We might be calling this outside a normal FLTK event, so we cannot
trust fl_event_time to have a sane value.
|
| |
|
|
|
|
|
| |
The buffer is considered changed right away, so we might not get any
add_changed() calls to trigger a start of the timer.
|
|
|
|
| |
It was only used by WinVNC, so push it there instead.
|
|
|
|
|
|
| |
This is a revert of 6c0181c. Testing showed that we got a big
performance hit by enabling this, and we also saw some graphical
artifacts. More work is needed before this can be enabled by default.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
We don't need the grab any more if the pointer cannot click on our
window. This makes it possible to shift focus to another application
when we aren't covering all monitors.
|
| |
|
|
|
|
|
| |
We would accidentally store they keycode 0 for unknown keysyms, wedging
the lookup table.
|
| |
|
|
|
|
|
| |
This is necessary to make sure the server side rendered cursor works
properly.
|
|
|
|
|
| |
We never un-select it, and it's not a problem if we get extra ones so
register it once right away.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
https://github.com/TigerVNC/tigervnc/issues/361
This is a simple implementation that refetches and transforms the cursor
image every time it changes, and doesn't use the cursor naming functions
of the XFixes extension to save & cache cursor images.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | | |
Don't force users of these headers to squash compiler
warnings about unused arguments, annotate with __unused_attr.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes:
/home/shade/dev/tigervnc/common/rfb/util.cxx:55:13: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare]
if (len < 0) {
~~~ ^ ~
1 error generated.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Clang complains loudly about this with Wformat=2, so add
a __printf_attr to help out.
Fixes:
/home/shade/dev/tigervnc/common/rfb/Logger.cxx:48:35: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
vsnprintf(buf1, sizeof(buf1)-1, format, ap);
^~~~~~
1 error generated.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
InputHandler declares the second parameter of clientCutText
as an int.
Fixes:
/home/shade/dev/tigervnc/common/rfb/CMsgWriter.h:60:18: error: 'rfb::CMsgWriter::clientCutText' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
virtual void clientCutText(const char* str, rdr::U32 len);
^
/home/shade/dev/tigervnc/common/rfb/InputHandler.h:36:18: note: hidden overloaded virtual function 'rfb::InputHandler::clientCutText' declared here: type mismatch at 2nd parameter ('int' vs 'rdr::U32' (aka 'unsigned int'))
virtual void clientCutText(const char* str, int len) {}
^
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Clang doesn't like when struct and class are used to refer
to the same thing interchangeably.
Fixes all instances of:
In file included from /home/shade/dev/tigervnc/common/rfb/CConnection.cxx:29:
In file included from /home/shade/dev/tigervnc/common/rfb/CConnection.h:28:
/home/shade/dev/tigervnc/common/rfb/DecodeManager.h:35:3: error: class 'Exception' was previously declared as a struct [-Werror,-Wmismatched-tags]
class Exception;
^
/home/shade/dev/tigervnc/common/rdr/Exception.h:32:10: note: previous use is here
struct Exception {
^
/home/shade/dev/tigervnc/common/rfb/DecodeManager.h:35:3: note: did you mean struct here?
class Exception;
^~~~~
struct
/home/shade/dev/tigervnc/common/rfb/DecodeManager.h:43:3: error: class 'Rect' was previously declared as a struct [-Werror,-Wmismatched-tags]
class Rect;
^
/home/shade/dev/tigervnc/common/rfb/Rect.h:68:10: note: previous use is here
struct Rect {
^
/home/shade/dev/tigervnc/common/rfb/DecodeManager.h:43:3: note: did you mean struct here?
class Rect;
^~~~~
struct
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
fread() returns size_t, which is unsigned. Don't check
for negative values to avoid warnings from Clang.
/home/shade/dev/tigervnc/common/rdr/FileInStream.cxx:74:13: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare]
if (n < 0 || ferror(file))
~ ^ ~
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix warnings emitted by Clang:
/home/shade/dev/tigervnc/common/rdr/FdInStream.h:30:9: error: 'rdr::FdInStreamBlockCallback' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
class FdInStreamBlockCallback {
^
In file included from /home/shade/dev/tigervnc/common/network/TcpSocket.cxx:44:
In file included from /home/shade/dev/tigervnc/common/network/TcpSocket.h:31:
/home/shade/dev/tigervnc/common/network/Socket.h:82:9: error: 'network::ConnectionFilter' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
class ConnectionFilter {
^
..etc
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix the following warnings emitted by Clang:
/home/shade/dev/tigervnc/common/rfb/Configuration.h:164:18: note: hidden overloaded virtual function 'rfb::VoidParameter::setParam' declared here: different number of parameters (0 vs 1)
virtual bool setParam();
^
/home/shade/dev/tigervnc/common/rfb/Configuration.h:256:18: error: 'rfb::BinaryParameter::setParam' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
virtual void setParam(const void* v, int l);
^
/home/shade/dev/tigervnc/common/rfb/Configuration.h:164:18: note: hidden overloaded virtual function 'rfb::VoidParameter::setParam' declared here: different number of parameters (0 vs 2)
virtual bool setParam();
|
| | | |
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Using XKeysymToKeycode() often gives the incorrect keycode as it
doesn't respect the current modifier state. Use XKB to find the
proper key instead.
This however also means that we need to track the mapping for all
pressed keys to make sure we know the correct keycode when it is
time to release the key.
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The sub-modules generally provide a better description than just the
short security method name.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Indicate to the user how secure the transport channel is so they
can avoid entering their password for untrusted sites.
|