aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'h264-buffer-size-fix' of https://github.com/any1/tigervncPierre Ossman2024-08-192-11/+19
|\
| * H264Libav: Clean up sws contextAndri Yngvason2024-08-161-0/+1
| | | | | | | | This fixes a memory leak
| * H264Libav: Use AVFrame for pixel format conversion bufferAndri Yngvason2024-08-162-11/+18
| | | | | | | | | | | | | | | | This ensures that the buffer is allocated with the correct alignment and padding for use with sws_scale. This fixes out-of-bounds writes which would in some cases cause segmentation faults and/or heap corruption.
* | Handle existing config directory in vncpasswdPierre Ossman2024-08-151-2/+4
| | | | | | | | This fixes commit a79c33d.
* | Let pwquality check minimum lengthPierre Ossman2024-08-151-7/+10
| | | | | | | | | | This is a policy decision, so let's not enforce something on our own if there is a system policy to rely on.
* | Only show pwquality setting where relevantPierre Ossman2024-08-151-3/+3
| | | | | | | | | | It's not used for Windows or macOS builds, so don't show the setting there.
* | Merge branch 'master' of https://github.com/prownd/tigervncPierre Ossman2024-08-154-0/+68
|\ \
| * | Limit the maximum length of a password to 8 charactershanjinpeng2024-08-141-0/+5
| | | | | | | | | | | | | | | Password should not be greater than 8 characters. Because only 8 valid characters are used.
| * | vncpasswd add password complexity rule check to enhance securityhanjinpeng2024-08-144-0/+63
| | | | | | | | | | | | | | | Use the library pwquality to check password complexity and improve security. Additionally, optional enable support is also set in CMake.
* | | Merge branch 'old-log' of https://github.com/jcpunk/tigervncPierre Ossman2024-08-141-11/+36
|\ \ \
| * | | vncsession: Move existing log to log.old if presentPat Riehecky2024-08-131-11/+36
| | |/ | |/|
* | | Use proper gnutls_free() on WindowsPierre Ossman2024-08-132-10/+4
| | | | | | | | | | | | | | | | | | The underlying issue requiring this hack was fixed ages ago. Unfortunately, the fixed GnuTLS doesn't consider static linking. So we need to add a new hack that permits that.
* | | Avoid using excessive namespacesPierre Ossman2024-08-136-16/+8
| | | | | | | | | | | | | | | Try to be more clear about what things are external to the current context, and what aren't.
* | | Avoid connection failed exceptionPierre Ossman2024-08-134-12/+12
| | | | | | | | | | | | | | | The usage of this is unclear as it is never caught. Use the general exception class, to stay consistent with all other protocol handling.
* | | Fix typosAndrew Kreimer2024-08-121-2/+2
| | |
* | | Don't adjust manually sized windowPierre Ossman2024-08-121-7/+0
| | | | | | | | | | | | | | | | | | | | | It's unclear why this code was ever added, and it can be very confusing that the window partially adjusts itself. The code is also in conflict with the earlier comment that states we'll leave the window size alone if it didn't perfectly match before the resize.
* | | Remove unused setPixelFormat() callbackPierre Ossman2024-08-124-20/+7
| | | | | | | | | | | | | | | This was made obsolete in dd45b44 when we extended the serverInit() callback.
* | | Remove fake framebuffer update request callPierre Ossman2024-08-121-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | This method should only be called when the client actually sends a framebuffer update request, otherwise we might send data the client is not ready for. It's unclear what the purpose of this call is, so we have no better fix than to just remove it.
* | | Update processMsg() descriptionPierre Ossman2024-08-122-12/+10
| | | | | | | | | | | | | | | This method is no longer blocking, so the description needed to be adjusted.
* | | Include key code for fake key eventsPierre Ossman2024-08-121-6/+6
| | | | | | | | | | | | Let's try to mimic a real event as much as possible to avoid bugs.
* | | Better type for pointer button maskPierre Ossman2024-08-1222-36/+36
| | | | | | | | | | | | | | | This is a very limited bit field, so use an 8 bit type to clearly show how many bits are available.
* | | Remove InputHandler interfacePierre Ossman2024-08-126-58/+32
| | | | | | | | | | | | | | | The different uses of this interface are not that closely related and there is no need for them to have a common interface class.
* | | Remove ScaleFiltersPierre Ossman2024-08-123-211/+0
| | | | | | | | | | | | This has been unused since 9fe3479.
* | | Remove IdentityVerifier forward declarationPierre Ossman2024-08-121-1/+0
| | | | | | | | | | | | This class has been removed since ages.
* | | Don't parse empty fence messagesPierre Ossman2024-08-121-1/+3
| | | | | | | | | | | | | | | We need to return here or we'll do an out-of-bounds access on the data array.
* | | Don't ask for login data when reconnectingJohannes2024-08-075-2/+57
| | |
* | | Better error message for authentication failurePierre Ossman2024-08-071-0/+4
| | |
* | | Don't abuse auth failure exceptionPierre Ossman2024-08-0710-107/+130
| | | | | | | | | | | | | | | | | | | | | | | | This exception is for when the user fails to authenticate, not all possible errors that might occur during the authentication phase. Use more appropriate exception types for the various other problems that might occur, so that we can present things more accurately to the user.
* | | Remove auth exception prefixPierre Ossman2024-08-076-13/+9
| | | | | | | | | | | | | | | | | | | | | | | | This prefix often just added noise, and could sometimes be added multiple times. It's better that user interface catch the specific exception type and give a more descriptive presentation to the user. This is partially a revert of 1922550.
* | | Correctly handle cancelled authenticationPierre Ossman2024-08-073-11/+15
| | | | | | | | | | | | | | | We should not be throwing up error messages, or asking to reconnect, if the user has actively cancelled the authentication attempt.
* | | Improve x0vncserver key allocation log linePierre Ossman2024-08-061-1/+2
| | | | | | | | | | | | | | | Follow the standard XK_ prefix, and also include the hex value for easier debugging.
* | | Avoid XKeysymToString() conflict with libX11Pierre Ossman2024-08-061-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We implement our own version of this, and because of this we carry our lookup table generated by the same tool that libX11 uses. Unfortunately, that table is a global symbol and as such there might be a mismatch of which table should be used. Make sure we get our own copy by changing the name of it. We use a define rather than modifying ks_tables.h as that file is automatically generated.
* | | Merge branch 'fix-unknown-keysym' of https://github.com/gujjwal00/tigervncPierre Ossman2024-08-065-19/+155
|\ \ \
| * | | Improve unknown keysym handlingGaurav Ujjwal2024-06-305-19/+155
| | | | | | | | | | | | | | | | | | | | | | | | Instead of giving up after all free keycodes have been used, Keycodes from previously added keysyms will be reused. Re: #93
* | | | Merge branch 'min' of https://github.com/KangLin/tigervncPierre Ossman2024-08-063-9/+9
|\ \ \ \ | |_|/ / |/| | |
| * | | Use std::min replace minKang Lin2024-07-263-9/+9
| | | |
* | | | Add missing comma in default security type listPierre Ossman2024-07-291-1/+1
| | | | | | | | | | | | | | | | | | | | Otherwise it merges with the next entry, removing both of them from the default list.
* | | | vncsession: use /bin/sh if the user shell is not setCarlos Santos2024-07-261-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | An empty shell field in the password file is valid, although not common. Use /bin/sh in this case, as documented in the passwd(5) man page, since the vncserver script requires a non-empty SHELL environment variable. Fixes issue #1786. Signed-off-by: Carlos Santos <casantos@redhat.com>
* | | Merge branch 'h264-fix-context-reset' of https://github.com/any1/tigervncPierre Ossman2024-07-241-1/+1
|\ \ \
| * | | H264Decoder: Fix context resetAndri Yngvason2024-07-221-1/+1
| | | | | | | | | | | | | | | | | | | | This fixes a regression introduced by 12b3f4021641537b90727b23d42de5dff59006cd.
* | | | Generate better (fake) modelinesPierre Ossman2024-07-234-5/+66
|/ / / | | | | | | | | | | | | This is what Xwayland does, so let's try to do the same to avoid any incompatibilites with applications.
* | | Fix overflow; "Timer: gettimeofday is broken"Pierre Ossman2024-07-191-1/+4
| | | | | | | | | | | | | | | | | | The rounding misbehaved when the tv_usec calculation overflows. Fixes issue #1782.
* | | Be more careful with ComparingUpdateTracker pointerPierre Ossman2024-07-051-4/+13
| | | | | | | | | | | | | | | | | | As of 28c3f12, we might now be running the frame clock even without a framebuffer present. This means we need to be more careful accessing the ComparingUpdateTracker, as it might be NULL.
* | | Round up expiration time for timersPierre Ossman2024-07-051-1/+1
| | | | | | | | | | | | | | | Otherwise we won't properly guarantee that we'll wait *at least* as long as the specified time.
* | | Fix x0vncserver handling of timersPierre Ossman2024-07-051-3/+3
| | | | | | | | | | | | Bug fix for bf28683.
* | | Update Slovak translationMarián Haburaj2024-06-271-544/+817
|/ /
* | Merge branch 'c++11' of github.com:CendioOssman/tigervncPierre Ossman2024-06-24288-2028/+2013
|\ \
| * | Enforce not shadowing variablesPierre Ossman2024-06-241-0/+1
| | | | | | | | | | | | | | | Shadowing variable can easily lead to bugs, so let's enforce that this is not allowed.
| * | Avoid shadowing variablesPierre Ossman2024-06-2468-260/+285
| | | | | | | | | | | | | | | It's a source of confusion and possibly bugs to reuse the same variable name for multiple things.
| * | Use "static" for helper functionsPierre Ossman2024-06-242-3/+3
| | | | | | | | | | | | | | | These functions act only on the input parameters, so let's make them static to more clearly indicate that they do not act upon any object.