Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Get rid of getStride() | Pierre Ossman | 2014-07-07 | 2 | -14/+11 | |
| | | | | | | It was confusing and not properly used everywhere. Callers should use the stride they get when they get the buffer pointer. | |||||
* | Get rid of the direct access abuse of FullFramePixelBuffer's data | Pierre Ossman | 2014-07-07 | 6 | -17/+29 | |
| | ||||||
* | We don't need a fillRect() that is this optimised | Pierre Ossman | 2014-07-07 | 2 | -83/+19 | |
| | | | | | Keep things simple instead and allows us to remove the extra setPF() methods. | |||||
* | Avoid having virtual methods where not needed | Pierre Ossman | 2014-07-07 | 2 | -17/+10 | |
| | ||||||
* | getImage() doesn't need to be overloadable, keep it simple | Pierre Ossman | 2014-07-07 | 3 | -38/+5 | |
| | ||||||
* | Encoders/decoders should track the connection object | Pierre Ossman | 2014-07-07 | 34 | -109/+102 | |
| | | | | | | The connection object is a much more appropriate object for the decoders and encoders to keep track of. Besides the streams, it also contains state like connection parameters. | |||||
* | Push encoder and decoder handling down into the connection objects | Pierre Ossman | 2014-07-07 | 9 | -140/+57 | |
| | | | | | This keeps the reader and writer objects clean and simple protocol decoders/encoders. | |||||
* | Remove full support for colour maps | Pierre Ossman | 2014-07-07 | 26 | -853/+240 | |
| | | | | | | | | | Gets rid of a loooot of code and complexity. Colour map clients are still supported through an automatically generated map, but we lose the ability to develop a client or server that uses colour maps internally. | |||||
* | Get rid of unnecessary macros as they are only ever set to a single thing | Pierre Ossman | 2014-07-07 | 15 | -85/+30 | |
| | ||||||
* | Push encoding specific formats into the encoders and decoders | Pierre Ossman | 2014-07-07 | 10 | -15/+91 | |
| | | | | Keep the generic stream classes clean and general. | |||||
* | Consolidate the different palette handler implementations | Pierre Ossman | 2014-07-07 | 8 | -493/+272 | |
| | ||||||
* | Handle CopyRect like any other encoding | Pierre Ossman | 2014-07-07 | 7 | -21/+86 | |
| | | | | Avoids having to special case things. Keeps the code simpler. | |||||
* | Avoid reader/writer duplication in every encoder/decoder | Pierre Ossman | 2014-07-07 | 24 | -26/+27 | |
| | ||||||
* | Remove partial update functionality | Pierre Ossman | 2014-07-07 | 15 | -80/+46 | |
| | | | | | | Get rid of the ability of encoders to only send part of the rectangle they are given as we don't want partial updates anyway. | |||||
* | Move serialisation of pseudorects into separate functions | Pierre Ossman | 2014-07-07 | 2 | -69/+72 | |
| | | | | Keeps the code clearer. | |||||
* | Merge the "V3" message classes into the normal ones | Pierre Ossman | 2014-07-07 | 20 | -1140/+818 | |
| | | | | We have no need for this abstraction so let's keep things simple. | |||||
* | Merge branch 'pixeltest' of https://github.com/CendioOssman/tigervnc | Pierre Ossman | 2014-07-07 | 1 | -1/+1 | |
|\ | ||||||
| * | librfb needs librdr so make sure it always gets pulled in | Pierre Ossman | 2014-07-04 | 1 | -1/+1 | |
| | | ||||||
* | | Remove a lot of platform compatibilty stuff | Pierre Ossman | 2014-07-07 | 12 | -132/+0 | |
| | | | | | | | | It's either not used, or no longer relevant. | |||||
* | | Fix some offenders that poke around in the PixelFormat internals | Pierre Ossman | 2014-07-07 | 3 | -60/+47 | |
| | | ||||||
* | | Avoid code duplication for the linear pixel format conversion methods | Pierre Ossman | 2014-07-07 | 1 | -79/+2 | |
| | | ||||||
* | | Consistent use of stride vs pitch | Pierre Ossman | 2014-07-07 | 6 | -23/+24 | |
| | | | | | | | | | | | | | | Consistently use the term stride rather than pitch. Also consistently represent the stride in number of pixels rather than number of bytes. There is so much code that assumes proper alignment already that we do not need the extra resolution. | |||||
* | | Fix possible information leakage | Pierre Ossman | 2014-07-07 | 1 | -2/+11 | |
| | | | | | | | | Zero the padding byte used when converting 24-bit RGB to 32-bit. | |||||
* | | Use the same algorithm for conversions | Pierre Ossman | 2014-07-07 | 1 | -73/+53 | |
| | | | | | | | | | | | | Make sure that the routines that convert between buffer and rgb representations follow the same algorithm so it's easier to compare them. | |||||
* | | Optimise the RGB to pixel conversion to simple shifts | Pierre Ossman | 2014-07-07 | 3 | -51/+65 | |
| | | | | | | | | | | Might as well make it inline at this point as well as it is used heavily in other routines that convert entire blocks of pixels. | |||||
* | | Remove magic JPEG variables from ConnParams | Pierre Ossman | 2014-07-07 | 3 | -14/+3 | |
| | | | | | | | | | | | | Custom compression level and JPEG on/off are not inherent parts of the protocol negotiation so they do not belong in ConnParams. Let the UI frontend handle such things instead. | |||||
* | | Clean up the encoding parser in ConnParams | Pierre Ossman | 2014-07-07 | 1 | -48/+55 | |
| | | ||||||
* | | Make the subsampling setting follow the common style | Pierre Ossman | 2014-07-07 | 8 | -45/+64 | |
| | | ||||||
* | | Stop storing a copy of the encodings as we don't use it for anything | Pierre Ossman | 2014-07-07 | 2 | -14/+3 | |
| | | ||||||
* | | Get rid of the register mechanism for encoders and decoders | Pierre Ossman | 2014-07-07 | 25 | -183/+77 | |
| | | | | | | | | We have no use for it, so let's keep things simple. | |||||
* | | Be more consistent in referring to pixel byte streams as buffers | Pierre Ossman | 2014-07-07 | 8 | -29/+29 | |
| | | ||||||
* | | Document the different pixel representations that we deal with | Pierre Ossman | 2014-07-07 | 1 | -1/+10 | |
| | | ||||||
* | | Get rid of unused things in the ZRLE encoder | Pierre Ossman | 2014-07-07 | 3 | -35/+13 | |
| | | | | | | | | | | Get rid of unused shared MemOutStream and variable max length functionality in the ZRLE encoder. | |||||
* | | Remove the scaled pixel buffer classes as they are not used. | Pierre Ossman | 2014-07-07 | 3 | -354/+0 | |
| | | | | | | | | | | There were also reports of them being broken last time we still made use of them. | |||||
* | | Remove unused (and commented out) PixelBuffer::getPixel() | Pierre Ossman | 2014-07-07 | 2 | -17/+0 | |
| | | ||||||
* | | Remove unused alternative code path from the ZRLE and Hextile decoders | Pierre Ossman | 2014-07-07 | 2 | -81/+0 | |
| | | ||||||
* | | Remove unused pixel conversion method | Pierre Ossman | 2014-07-07 | 2 | -18/+0 | |
| | | ||||||
* | | Remove unsused, commented out code | Pierre Ossman | 2014-07-07 | 2 | -24/+0 | |
| | | ||||||
* | | Reduce dependencies on TransImageGetter.h | Pierre Ossman | 2014-07-07 | 7 | -7/+8 | |
| | | ||||||
* | | Support keeping libjpeg's default compression setting | Pierre Ossman | 2014-07-07 | 1 | -3/+8 | |
| | | ||||||
* | | Converting to RGB might involve a precision increase | Pierre Ossman | 2014-07-07 | 3 | -15/+59 | |
| | | | | | | | | | | | | | | Need to do more than a simple shift to get the appropriate new value. This isn't quite as exact as a proper multiplication and division, but the error is so small it's not worth the extra cycles. | |||||
* | | Make sure we check that PixelFormats we get are actually valid. | Pierre Ossman | 2014-07-03 | 2 | -6/+45 | |
|/ | ||||||
* | The ZRLE decoder relied on an assert() for boundary checks. A default | Pierre Ossman | 2014-03-19 | 1 | -3/+10 | |
| | | | | | | | | | | Release build however will remove all asserts making it possible to overrun this buffer. This could be exploited by a malicious server. This issue has been assigned CVE-2014-0011. Patch by Tim Waugh for Red Hat. git-svn-id: svn://svn.code.sf.net/p/tigervnc/code/trunk@5167 3789f03b-4d11-0410-bbf8-ca57d06f2519 | |||||
* | Make sure the fill function pointer gets updated if the | Pierre Ossman | 2014-01-07 | 2 | -5/+24 | |
| | | | | | | | | | | | managed pixel buffer changes format. Also add a bit more protection for switching pixel format as the base classes aren't really designed for that. Fixes a crash with the mouse pointer in WinVNC. Based on work done by Daniel Wyatt (dewyatt). git-svn-id: svn://svn.code.sf.net/p/tigervnc/code/trunk@5152 3789f03b-4d11-0410-bbf8-ca57d06f2519 | |||||
* | Simplify rfb::ParameterIterator - we always iterate over all enabled params. | Adam Tkac | 2013-03-14 | 1 | -4/+4 | |
| | | | | git-svn-id: svn://svn.code.sf.net/p/tigervnc/code/trunk@5064 3789f03b-4d11-0410-bbf8-ca57d06f2519 | |||||
* | Remove unused assignment operator declaration from rfb::Configuration | Adam Tkac | 2013-03-14 | 2 | -22/+0 | |
| | | | | git-svn-id: svn://svn.code.sf.net/p/tigervnc/code/trunk@5063 3789f03b-4d11-0410-bbf8-ca57d06f2519 | |||||
* | Remove unused parameter from rfb::Configuration::Configuration() | Adam Tkac | 2013-03-14 | 2 | -9/+1 | |
| | | | | git-svn-id: svn://svn.code.sf.net/p/tigervnc/code/trunk@5062 3789f03b-4d11-0410-bbf8-ca57d06f2519 | |||||
* | We were not handling the "sync next" fence properly as we sent the response | Pierre Ossman | 2012-07-20 | 2 | -6/+10 | |
| | | | | | | | | | right after we got the request (instead of waiting for the next command). This created a race where we could lose pixel format sync between the client and the server. git-svn-id: svn://svn.code.sf.net/p/tigervnc/code/trunk@4943 3789f03b-4d11-0410-bbf8-ca57d06f2519 | |||||
* | Also check for negative encodings, in case the server is throwing unexpected | Pierre Ossman | 2012-07-19 | 2 | -3/+3 | |
| | | | | | | | garbage at us. git-svn-id: svn://svn.code.sf.net/p/tigervnc/code/trunk@4942 3789f03b-4d11-0410-bbf8-ca57d06f2519 | |||||
* | ScreenSet references rdr types, so we need to make sure those are defined. | Pierre Ossman | 2012-07-13 | 1 | -0/+1 | |
| | | | | git-svn-id: svn://svn.code.sf.net/p/tigervnc/code/trunk@4934 3789f03b-4d11-0410-bbf8-ca57d06f2519 |