aboutsummaryrefslogtreecommitdiffstats
path: root/common
Commit message (Collapse)AuthorAgeFilesLines
...
* Move utility functions to core libraryPierre Ossman2025-02-1339-304/+352
| | | | | | | Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
* Move basic data types to core libraryPierre Ossman2025-02-1369-370/+496
| | | | | | | Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
* Remove rfb:: prefix from rfb::RegionPierre Ossman2025-02-131-25/+45
| | | | | We normally avoid specifying a class' own namespace prefix in order to keep the code more compact. Region was the sole exception.
* Use initializer lists for basic data typesPierre Ossman2025-02-1313-39/+41
| | | | | | | | Try to keep the code more compact for the simple things where the type should be obvious from the context. Helps us avoid line wrapping. Also remove explicit conversions to Region where the compiler is able to figure it out by itself, again to reduce line length.
* Move getHostAndPort() to network libraryPierre Ossman2025-02-133-120/+90
| | | | | This is a network function, so it makes more sense in the network library.
* Reduce header #include:sPierre Ossman2025-02-1356-78/+187
| | | | | Make compile times faster by reducing the number of headers included in other headers.
* Remove unused SStaticDesktopPierre Ossman2025-02-131-43/+6
| | | | This inline class just makes this header overly complex.
* Merge branch 'resize' of https://github.com/CendioOssman/tigervncPierre Ossman2025-02-062-4/+12
|\
| * Log ComparingUpdateTracker stats at debug levelPierre Ossman2025-02-051-4/+6
| | | | | | | | | | | | We've made the client more aggressive in resizing sessions, so this can quickly produce a lot of log output. Reduce the log level to debug until we can keep the stats for the entire session lifetime.
| * Remove superfluous resizeFramebuffer() callsPierre Ossman2025-02-051-0/+6
| | | | | | | | | | | | | | These are not needed since the cleanup in 6ea58ba. At the same time, move the error logging for a failed SetDesktopSize to the base CConnection class as it is a generic thing.
* | Respect access bits in continuous updatesPierre Ossman2025-02-061-0/+3
| |
* | Fix handling of empty -parameter= argumentsPierre Ossman2025-02-061-2/+2
|/ | | | Broken in e97e225.
* Fix incorrect removal of config parametersPierre Ossman2025-01-271-1/+1
| | | | | Bad logic introduced in 28e35d0. Fortunately, nothing currently uses this method.
*---. Merge branches 'argparse', 'nothread' and 'config' of ↵Pierre Ossman2025-01-1019-422/+195
|\ \ \ | | | | | | | | | | | | https://github.com/CendioOssman/tigervnc
| | | * Use "on"/"off" when displaying bool parametersPierre Ossman2025-01-101-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a lot more readable than "0"/"1", which can easily be confused with integer parameters. Note that this breaks some backwards compatibility. Older clients will not be able to parse configuration files generated by newer clients, as they had a bug where they could only understand "0" and "1".
| | | * Sort parameters in -help and man pagesPierre Ossman2025-01-071-0/+3
| | | | | | | | | | | | | | | | Makes it much easier to find all the different options.
| | | * Use normal iterators for parametersPierre Ossman2025-01-071-25/+5
| | | | | | | | | | | | | | | | | | | | Now that we are based on a normal std::list, we can use normal iterators to go through the parameters.
| | | * Use std::list for config parametersPierre Ossman2025-01-072-33/+34
| | | | | | | | | | | | | | | | Avoid rolling our own linked list when we have the standard library.
| | | * Remove server and viewer config typesPierre Ossman2025-01-078-111/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't consistently use these, so they are just confusing. Instead, we rely on the linker to not include unnecessary objects, and hence irrelevant configuration objects.
| | | * Don't save parameters with default valuesPierre Ossman2025-01-072-0/+6
| | | | | | | | | | | | | | | | | | | | This allows smooth upgrades for users if the defaults change in the future.
| | | * Remove legacy StringParameter code/commentPierre Ossman2025-01-072-6/+0
| | | | | | | | | | | | | | | | This should have been cleaned up in adaedc9.
| | | * Remove unused config isBool() methodPierre Ossman2025-01-072-15/+0
| |_|/ |/| |
| | * Remove Logger_File mutexPierre Ossman2025-01-102-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is not providing protection for all of the logging, so it gives a false sense of security. We're also not making use of this as we have barely any threading. The exception is the WinVNC code, which is very thread heavy. But it is unmaintained and will not be a blocker for this.
| | * Remove Configuration mutexPierre Ossman2025-01-102-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | This is not providing adequate protectection in more complex cases, and we're not making use of threads in a way that should require this. The exception is the WinVNC code, which is very thread heavy. But it is unmaintained and will not be a blocker for this.
| | * Avoid logging in H.264 decoderPierre Ossman2025-01-104-53/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | Decoders are run in threads, and not everything in the logging system is thread safe. Normally decoders consider errors to be fatal and throw an exception. But the H.264 decoder wants to be able to tolerate misbehaving H.264 encoders.
| | * Use normal constructor/destructor for H.264 contextsPierre Ossman2025-01-107-48/+13
| | |
| | * Always reset H.264 contexts the same wayPierre Ossman2025-01-104-12/+8
| | | | | | | | | | | | | | | | | | Reset individual contexts the same way we reset all contexts, i.e. by deleting and recreating them. Avoids surprises by having a consistent method.
| | * Throw exceptions directly in H.264 init routinesPierre Ossman2025-01-066-45/+25
| | | | | | | | | | | | | | | A false return value from these methods result in an exception anyway, so let's keep things simple and throw the exception right away.
| | * Add missing stddef.h include to Decoder.hPierre Ossman2025-01-061-0/+1
| | | | | | | | | | | | It uses the size_t type, which might not otherwise be defined.
| | * Remove mutexes from H.264 decoder and friendsPierre Ossman2025-01-066-20/+0
| |/ |/| | | | | | | The decodered is already flagged as strictly ordered, which means it will only be used from a single thread at a time.
| * Remove Configuration::set() with lengthPierre Ossman2025-01-102-17/+4
| | | | | | | | | | This was a weird hack just to support the method that split arguments. We don't need this know as we expect callers to do any string handling.
| * Fix handling of bool on/off argumentsPierre Ossman2025-01-101-0/+2
| | | | | | | | | | These two values were overlooked in the look-ahead list and hence did not work reliably.
| * Consolidate argument parsing in single functionPierre Ossman2025-01-102-31/+72
| | | | | | | | | | Avoid duplicating this complexity everywhere and make sure all commands get the same handling and fixes.
| * Remove unused Configuration methodsPierre Ossman2024-12-031-9/+0
| | | | | | | | These never even had an implementation.
* | Fix log name typo for SSecurityRSAAESPierre Ossman2024-12-171-1/+1
| |
* | Always flush sockets on shutdown()Pierre Ossman2024-12-1710-19/+87
| | | | | | | | | | | | | | | | The system shutdown() function doesn't drop buffered data, so neither should we. We had one fix in place, but that didn't cover all cases. Move this handling to all socket like classes we have.
* | Reduce header includes in TLS/RSA-AES headersPierre Ossman2024-12-174-9/+26
| | | | | | | | We can make do with forward declarations for these classes.
* | Fix bad restore point handling in RSA-AES handlerPierre Ossman2024-12-171-1/+1
| | | | | | | | | | A set restore point needs to be used or cleared. Release builds will let this slide, but debug builds will kill the connection.
* | Fix encoder solid area detectionPierre Ossman2024-12-072-19/+25
| | | | | | | | | | | | | | This got completely broken in baca73d0 where the templated method got incorrectly called instead of the wrapper/multiplexer. It seems to have been harmless on most systems, but caused crashes on CPUs with strict memory alignment requirements.
* | Merge branch 'keysplit' of https://github.com/CendioOssman/tigervncPierre Ossman2024-12-042-0/+107
|\ \ | |/ |/|
| * Move keyboard tracking to CConnectionPierre Ossman2024-12-042-0/+107
| | | | | | | | | | | | This is a general thing so move it in to the core library instead, letting vncviewer focus on just translation of system events to VNC ones.
* | Also mark tls_error with noexceptPierre Ossman2024-11-262-2/+2
| | | | | | | | Overlooked this special exception in the previous commit.
* | Mark all exception type methods as noexceptPierre Ossman2024-11-263-28/+30
| | | | | | | | | | This is required for the built in exceptions, so let's do the same to avoid surprises.
* | Don't save exceptions as std::exceptionPierre Ossman2024-11-263-7/+15
| | | | | | | | | | | | That type is not guaranteed to preserve anything useful at all. Instead, try to either preserve a more specific type, or use std::runtime_error which at least has a guaranteed message.
* | Change some assertions to exceptionsPierre Ossman2024-11-224-5/+13
| |
* | Capitalize some more logging and exceptionsPierre Ossman2024-11-2223-103/+103
| |
* | Merge branch 'master' of https://github.com/madnicendio/tigervncPierre Ossman2024-11-2216-60/+60
|\ \
| * | Capitalize first letter in log, exception & errorMadeleine Nilsson2024-11-2112-56/+56
| | | | | | | | | | | | The reason for this is to keep a consistency through out the project.
| * | Standardize log message prefix formatMadeleine Nilsson2024-11-111-2/+2
| | | | | | | | | | | | The reason for this is to keep a consistency through out the project.
| * | Standardize on sentence case in titlesMadeleine (ThinLinc team)2024-11-113-3/+3
| | | | | | | | | | | | The reason for this is to keep a consistency through out the project.
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-04 18:38:20 +0000