aboutsummaryrefslogtreecommitdiffstats
path: root/common
Commit message (Collapse)AuthorAgeFilesLines
...
| * Avoid std::string(nullptr) for StringParameterPierre Ossman2025-03-061-1/+1
| | | | | | | | This is undefined and crashes on macOS.
* | Merge branch 'msvc' of https://github.com/KangLin/tigervncPierre Ossman2025-03-111-2/+1
|\ \ | |/ |/|
| * MSVC: fix compile error in Socket.cxxKang Lin2025-02-281-2/+1
| |
* | Fix bad forward declarations of StringParameterPierre Ossman2025-03-032-4/+0
| | | | | | | | This should have been done as part of cf1bc66.
* | Convert conv unit tests to Google TestPierre Ossman2025-02-271-1/+1
|/
* Stop relying on "using namespace"Pierre Ossman2025-02-251-1/+0
| | | | | | There were not many uses of this left after the move to std::exception and the move to the core library. Let's get rid of the last stragglers and reduce the risk of name collisions.
* Move concurrency abstration layer to corePierre Ossman2025-02-2512-69/+54
| | | | | OS abstractions are generic enough that we can merge these with the new core library.
* Move winerrno.h to corePierre Ossman2025-02-256-5/+5
| | | | | OS abstractions are generic enough that we can merge these with the new core library.
* Move application directory handling to corePierre Ossman2025-02-258-22/+17
| | | | | These are general plumbing, so they fit in nicely with the new core library.
* Rename core/util to core/stringPierre Ossman2025-02-2532-34/+35
| | | | | It's just string helper functions here, so let's get rid of the catch-all name for this module.
* Get rid of __rfbmax()/__rfbmin()Pierre Ossman2025-02-2510-64/+49
| | | | | | | | They weren't that well used, and were mostly just confusing special functions anyway. Allows us to move away from generic and ambigious headers such as "util".
* Keep all time helpers in a single placePierre Ossman2025-02-253-32/+34
|
* Handle bad ordering to time helpersPierre Ossman2025-02-251-0/+3
| | | | | | These functions assumes there is a specific ordering between the given moments. Make sure we don't return something completely crazy if this ordering isn't true.
* Move time utilities to separate filePierre Ossman2025-02-2510-59/+124
| | | | Let's clear things up by categorizing our utility functions.
* Move timers to core libraryPierre Ossman2025-02-2512-32/+32
| | | | | | | Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
* Move logging to core libraryPierre Ossman2025-02-2550-140/+130
| | | | | | | Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
* Move configuration to core libraryPierre Ossman2025-02-2533-125/+143
| | | | | | | Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
* Move base exception classes to core libraryPierre Ossman2025-02-2527-94/+96
| | | | | | | Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
* Move utility functions to core libraryPierre Ossman2025-02-1339-304/+352
| | | | | | | Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
* Move basic data types to core libraryPierre Ossman2025-02-1369-370/+496
| | | | | | | Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
* Remove rfb:: prefix from rfb::RegionPierre Ossman2025-02-131-25/+45
| | | | | We normally avoid specifying a class' own namespace prefix in order to keep the code more compact. Region was the sole exception.
* Use initializer lists for basic data typesPierre Ossman2025-02-1313-39/+41
| | | | | | | | Try to keep the code more compact for the simple things where the type should be obvious from the context. Helps us avoid line wrapping. Also remove explicit conversions to Region where the compiler is able to figure it out by itself, again to reduce line length.
* Move getHostAndPort() to network libraryPierre Ossman2025-02-133-120/+90
| | | | | This is a network function, so it makes more sense in the network library.
* Reduce header #include:sPierre Ossman2025-02-1356-78/+187
| | | | | Make compile times faster by reducing the number of headers included in other headers.
* Remove unused SStaticDesktopPierre Ossman2025-02-131-43/+6
| | | | This inline class just makes this header overly complex.
* Merge branch 'resize' of https://github.com/CendioOssman/tigervncPierre Ossman2025-02-062-4/+12
|\
| * Log ComparingUpdateTracker stats at debug levelPierre Ossman2025-02-051-4/+6
| | | | | | | | | | | | We've made the client more aggressive in resizing sessions, so this can quickly produce a lot of log output. Reduce the log level to debug until we can keep the stats for the entire session lifetime.
| * Remove superfluous resizeFramebuffer() callsPierre Ossman2025-02-051-0/+6
| | | | | | | | | | | | | | These are not needed since the cleanup in 6ea58ba. At the same time, move the error logging for a failed SetDesktopSize to the base CConnection class as it is a generic thing.
* | Respect access bits in continuous updatesPierre Ossman2025-02-061-0/+3
| |
* | Fix handling of empty -parameter= argumentsPierre Ossman2025-02-061-2/+2
|/ | | | Broken in e97e225.
* Fix incorrect removal of config parametersPierre Ossman2025-01-271-1/+1
| | | | | Bad logic introduced in 28e35d0. Fortunately, nothing currently uses this method.
*---. Merge branches 'argparse', 'nothread' and 'config' of ↵Pierre Ossman2025-01-1019-422/+195
|\ \ \ | | | | | | | | | | | | https://github.com/CendioOssman/tigervnc
| | | * Use "on"/"off" when displaying bool parametersPierre Ossman2025-01-101-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a lot more readable than "0"/"1", which can easily be confused with integer parameters. Note that this breaks some backwards compatibility. Older clients will not be able to parse configuration files generated by newer clients, as they had a bug where they could only understand "0" and "1".
| | | * Sort parameters in -help and man pagesPierre Ossman2025-01-071-0/+3
| | | | | | | | | | | | | | | | Makes it much easier to find all the different options.
| | | * Use normal iterators for parametersPierre Ossman2025-01-071-25/+5
| | | | | | | | | | | | | | | | | | | | Now that we are based on a normal std::list, we can use normal iterators to go through the parameters.
| | | * Use std::list for config parametersPierre Ossman2025-01-072-33/+34
| | | | | | | | | | | | | | | | Avoid rolling our own linked list when we have the standard library.
| | | * Remove server and viewer config typesPierre Ossman2025-01-078-111/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't consistently use these, so they are just confusing. Instead, we rely on the linker to not include unnecessary objects, and hence irrelevant configuration objects.
| | | * Don't save parameters with default valuesPierre Ossman2025-01-072-0/+6
| | | | | | | | | | | | | | | | | | | | This allows smooth upgrades for users if the defaults change in the future.
| | | * Remove legacy StringParameter code/commentPierre Ossman2025-01-072-6/+0
| | | | | | | | | | | | | | | | This should have been cleaned up in adaedc9.
| | | * Remove unused config isBool() methodPierre Ossman2025-01-072-15/+0
| |_|/ |/| |
| | * Remove Logger_File mutexPierre Ossman2025-01-102-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is not providing protection for all of the logging, so it gives a false sense of security. We're also not making use of this as we have barely any threading. The exception is the WinVNC code, which is very thread heavy. But it is unmaintained and will not be a blocker for this.
| | * Remove Configuration mutexPierre Ossman2025-01-102-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | This is not providing adequate protectection in more complex cases, and we're not making use of threads in a way that should require this. The exception is the WinVNC code, which is very thread heavy. But it is unmaintained and will not be a blocker for this.
| | * Avoid logging in H.264 decoderPierre Ossman2025-01-104-53/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | Decoders are run in threads, and not everything in the logging system is thread safe. Normally decoders consider errors to be fatal and throw an exception. But the H.264 decoder wants to be able to tolerate misbehaving H.264 encoders.
| | * Use normal constructor/destructor for H.264 contextsPierre Ossman2025-01-107-48/+13
| | |
| | * Always reset H.264 contexts the same wayPierre Ossman2025-01-104-12/+8
| | | | | | | | | | | | | | | | | | Reset individual contexts the same way we reset all contexts, i.e. by deleting and recreating them. Avoids surprises by having a consistent method.
| | * Throw exceptions directly in H.264 init routinesPierre Ossman2025-01-066-45/+25
| | | | | | | | | | | | | | | A false return value from these methods result in an exception anyway, so let's keep things simple and throw the exception right away.
| | * Add missing stddef.h include to Decoder.hPierre Ossman2025-01-061-0/+1
| | | | | | | | | | | | It uses the size_t type, which might not otherwise be defined.
| | * Remove mutexes from H.264 decoder and friendsPierre Ossman2025-01-066-20/+0
| |/ |/| | | | | | | The decodered is already flagged as strictly ordered, which means it will only be used from a single thread at a time.
| * Remove Configuration::set() with lengthPierre Ossman2025-01-102-17/+4
| | | | | | | | | | This was a weird hack just to support the method that split arguments. We don't need this know as we expect callers to do any string handling.
| * Fix handling of bool on/off argumentsPierre Ossman2025-01-101-0/+2
| | | | | | | | | | These two values were overlooked in the look-ahead list and hence did not work reliably.