| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 8a80c906b9f7c08b1c664569a97d327d62c6d8ae added a check to prevent
announcing clipboard when it's not plain text data. When this check
triggers and we want to ignore the non-plain text clipboard, we should
reset the state by no longer indicating pending clipboard, and by asking
the server to clear its clipboard. This ensures we don't end up in a
state where the server thinks the viewer has useful clipboard data, but
it doesn't.
(cherry picked from commit 6f6d9406035d59b6a9f59ff0f38206c0c98a0266)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FLTK has support for both image and plain text clipboard data, we don't.
This means we only send plain text clipboard from the viewer to the
server. Some applications can get confused when we announce that
clipboard is available and later don't send anything. An example of such
an application is QGIS, in the remote session it froze when an image was
copied on the client side.
This fix means we only call announceClipboard() when the clipboard
contains plain text. That means TigerVNC is now more robust and doesn't
trigger freezes in buggy applications.
(cherry picked from commit 8a80c906b9f7c08b1c664569a97d327d62c6d8ae)
|
|
|
|
|
|
|
| |
They are not automatically cleaned up with the window on Windows, and we
might want to reconnect so we cannot rely on the process cleanup either.
(cherry picked from commit 43ce674dfbd2576fe5b382ad9f87e5beebc72812)
|
|
|
|
|
|
| |
This happens if you've connected to a server using a Unix socket.
(cherry picked from commit 4236d0c644a7454ab7a955e837143a8fd0777c09)
|
|
|
|
| |
(cherry picked from commit 169ffe18c141a4ca1fc2e790e927a1aa49cce30e)
|
|
|
|
|
|
|
|
|
|
| |
Read just the first password and ignore anything else in the password
file. This allows you to reuse a password file from the server that also
includes a view-only password.
This fixes a regression introduced in b99daad.
(cherry picked from commit 49a087e8f8ecafe950a86a71ae6657d6cac8ea77)
|
|
|
|
|
|
|
| |
Although rare, there are cases where we might fail to determine our base
directories. Make sure the code can handle it.
(cherry picked from commit edee4db8d1fd85495f189293041311bfff56d23c)
|
|
|
|
|
|
| |
This is non-trivial now, so let's modularize this a bit.
(cherry picked from commit 0c61c069bab38d14b93ad9d71b6509427a5611a8)
|
|
|
|
| |
(cherry picked from commit a1bd5cf795d36dd4ce17e980b5cb0a7f200756b5)
|
|\ |
|
| |
| |
| |
| |
| |
| | |
One-shot timers are more common, so let's change the API a bit to make
that use case simpler. This API also makes it more clear what is
happening.
|
| |
| |
| |
| |
| | |
It is much more sane to treat "0" as "a timer is ready NOW", so let's
change to using -1 as the invalid timeout value.
|
| |
| |
| |
| |
| |
| |
| | |
Avoid duplicating this complexity in too many places.
At the same time make the interface more identical to regular mkdir(),
for familiarity.
|
|\ \
| | |
| | | |
Allow for alternative user config locations, deprecate `~/.vnc` in favour of XDG Base Directory Specification paths
|
| | | |
|
| |/ |
|
| |
| |
| |
| |
| |
| | |
FLTK can send events with fl_xevent pointing to random memory, which
means that we cannot trust that structure. XQueryPointer() can give us
what we need, at the cost of an extra round trip.
|
|/
|
|
|
| |
That extra add_fd() only set the read notification, overwriting any
write notification set up in the lines just above.
|
|
|
|
| |
This keep everything consistent.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
It's a reoccurring issue that users try to build individual components
by pointing cmake at a specific subdirectory, e.g. 'cmake vncviewer'.
CMake, unfortunately, has insufficient protection against this so we'll
need to add a manual check.
This commit only adds it to the most likely places for misuse so we
don't have to pollute every CMakeLists.txt.
|
|
|
|
|
| |
All the information we need is now available in keysymdef.h, so let's
get everything updated and in sync.
|
|
|
|
| |
Make it easier to see what's code and what's just a lot of data.
|
|
|
|
|
| |
This is a manually set up table specific for TigerVNC. For clarity,
separate it out from the general keysym/Unicode table.
|
|
|
|
|
|
|
|
|
| |
This is mainly a copy of XKeysymToString() from libX11. We've also added
a wrapper that still gives a string, even if there is no name for the
requested keysym.
This grows the binaries a bit, but not with any extreme amount so is
hopefully worth it to get better debug logging.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can get races with clipboard managers in the server that is very
confusing to the user.
When the clipboard changes locally, we tell the server to drop the old
clipboard (as it is now lost). But we don't send over the new clipboard
until we get focus again, in order to not leak more data than necessary.
This causes some clibpoard managers to take over ownership in order to
avoid an empty clipboard. And this takes precedence over the new client
clipboard as it happened later. Effectively reverting the clipboard the
user sees.
Avoid all of this by simply ignoring the server when we don't have
focus. This is likely what users expect anyway as they expect their
currently focused application to control the clipboard, not vncviewer in
the background.
|
|
|
|
|
|
| |
Don't assume a lack of TCP listeners means the server will be
unreachable. There might be other methods of access, so let the higher
levels do that sanity check instead.
|
|
|
|
|
|
|
| |
Using "c" is in conflict the the "Ctrl" entry, so we need to pick
something else here.
This was a regression introduced in 44b085a.
|
|
|
|
|
|
|
|
| |
FLTK only allows 256 different box types, but it doesn't actually check
this when registering new ones.
Move our custom types to a valid range, and add an assert for good
measure to make sure we don't overflow FLTK's internal structures.
|
| |
|
|
|
|
|
| |
Follow the colors that modern desktops use when it comes to background,
text and selections.
|
|
|
|
|
|
|
| |
There is something broken with these FLTK draw routines on Windows. They
leave gaps at the start and end of the arc/pie rather than filling the
whole specified span. So we need to nudge the numbers a bit to work
around this.
|
|
|
|
|
|
|
|
|
|
|
| |
Inspired by modern Windows appearance, and to some extent macOS. They
have flat boxes and use white, or very light, colors for interactive
elements. Unfortunately we can't directly control the colors of
widgets, so instead we just lighten everything that uses this box type.
GNOME uses a different design, both their older and newer style. But UI
look is less consistent on Linux, so hopefully our new look is decent
enough there as well.
|
|
|
|
|
| |
Work around a bug in Fl_Input_Choice where it forgets to set the proper
"input background" on some parts.
|
|
|
|
| |
We should have a consistent color set over all widgets.
|
|
|
|
|
|
|
|
|
|
| |
gcc doesn't support -Wformat for the wide format versions of printf()
and friends yet:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=38308
Do what glibc does and have some commented out tags to show future
intent.
|
|
|
|
|
|
|
|
|
|
| |
gettext replaces all *printf() functions on platforms that don't fully
conform to the POSIX behaviour. Unfortunately, gettext fails to tag
these replacement functions properly so that -Wformat can still do its
thing.
Resolve this by adding a redudant declaration of the relevant functions,
with the attribute tagging in place.
|
|
|
|
|
|
| |
The size of size_t depends on the architecture, so we need to have
different conversion to and from strings. But we don't really need that
range, so avoid the issue by using a standard integer size.
|
|
|
|
|
| |
The WM_CLASS we set on all windows is just "vncviewer", so that it
matches the name of the .desktop file, which is what GNOME expects.
|
|\ |
|
| |
| |
| |
| |
| |
| | |
We should handle this in the low-level protocol code as much as possible
to avoid mistakes. This way the rest of the code can assume that strings
are always UTF-8 with \n line endings.
|
| |
| |
| |
| |
| | |
These will always be byte streams at heart, so let's try to keep them
with a proper type. Should make it clearer how they will be used.
|
| |
| |
| |
| | |
The need for these must have got lost somewhere in the type cleanup.
|
| |
| |
| |
| | |
They are not fully supported and break with some backends, like Ninja.
|
| |
| |
| |
| |
| | |
It is more specific, and it properly sets up propagation when include
directories also need to be used further down a dependency chain.
|
|/
|
|
|
|
|
| |
The coordinates we get are relative the root window of each screen, so
we can only trust them if we are on the same screen. So let's explicitly
check that we are still getting events from the expected screen by
checking the root window field of the event.
|
|
|
|
|
| |
It's a type specific to that class, so let's keep them close for
clarity.
|
|
|
|
|
| |
It is much more natural than custom methods for this very common
operation.
|
|
|
|
|
|
|
|
| |
These files don't use anything from this header, so remove the include.
This exposes some missing includes in other places, though. So add an
explicit include in the files that were relying on an indirect
inclusion.
|