| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
A server can be specified in many different ways, so it is easy to get
multiple entries in the history for the same thing.
Get rid of these by parsing each entry and comparing with existing
entries.
|
|
|
|
|
| |
It's easier for the user if the most recently used entries are at the
top.
|
|
|
|
|
| |
We don't need random access to the entries, so a list fits just as well.
It also has better accessors we need.
|
|
|
|
| |
This happens if you've connected to a server using a Unix socket.
|
|
|
|
|
| |
Prefer this exception for failures involving errno as it gives a better
error description.
|
|\ |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Read just the first password and ignore anything else in the password
file. This allows you to reuse a password file from the server that also
includes a view-only password.
This fixes a regression introduced in b99daad.
|
| |
| |
| |
| |
| | |
Problems with the original code: A process can only establish one connection.
After modification, multiple connections can be supported.
|
| | |
|
| |
| |
| |
| |
| | |
Although rare, there are cases where we might fail to determine our base
directories. Make sure the code can handle it.
|
| |
| |
| |
| | |
This is non-trivial now, so let's modularize this a bit.
|
|/
|
|
|
|
|
|
|
| |
An issue with minimise not working when in fullscreen on macOS was
workaround in Pull Request #1813. The underlaying issue is currently
unknown.
macOS native fullscreen mode was looked into, but no clear answer was
given. See #1813 for details.
|
| |
|
| |
|
|
|
|
|
|
|
| |
It's unclear why this code was ever added, and it can be very confusing
that the window partially adjusts itself. The code is also in conflict
with the earlier comment that states we'll leave the window size alone
if it didn't perfectly match before the resize.
|
|
|
|
|
| |
This is a very limited bit field, so use an 8 bit type to clearly show
how many bits are available.
|
| |
|
| |
|
|
|
|
|
| |
We should not be throwing up error messages, or asking to reconnect, if
the user has actively cancelled the authentication attempt.
|
|
|
|
|
| |
It's a source of confusion and possibly bugs to reuse the same variable
name for multiple things.
|
|
|
|
|
| |
These functions act only on the input parameters, so let's make them
static to more clearly indicate that they do not act upon any object.
|
|
|
|
|
|
|
|
|
| |
These are often more readable as they avoid a lot of the boilerplate of
iterating over fixed arrays or STL containers.
Note that this change is very conservative to avoid noise in "git
blame". Only loops where this is a clear improvement have been
converted.
|
|
|
|
|
| |
Use the new "override" keyword to properly differentiate between new
virtual methods, and existing virtual methods being overridden.
|
|
|
|
|
|
| |
We use the pointer to just store an identifier for the menu, but this is
enough for gcc to think we are using 0 instead of nullptr and complain.
Even an explicit cast isn't enough to silence it here for some reason.
|
|
|
|
|
| |
It's more readable than 0, and a bit safer than NULL, so let's try to
follow modern norms.
|
|\ |
|
| |
| |
| |
| |
| |
| | |
One-shot timers are more common, so let's change the API a bit to make
that use case simpler. This API also makes it more clear what is
happening.
|
| |
| |
| |
| |
| | |
It is much more sane to treat "0" as "a timer is ready NOW", so let's
change to using -1 as the invalid timeout value.
|
| |
| |
| |
| |
| |
| |
| | |
Avoid duplicating this complexity in too many places.
At the same time make the interface more identical to regular mkdir(),
for familiarity.
|
|\ \
| | |
| | | |
Allow for alternative user config locations, deprecate `~/.vnc` in favour of XDG Base Directory Specification paths
|
| | | |
|
| |/ |
|
| |
| |
| |
| |
| |
| | |
FLTK can send events with fl_xevent pointing to random memory, which
means that we cannot trust that structure. XQueryPointer() can give us
what we need, at the cost of an extra round trip.
|
|/
|
|
|
| |
That extra add_fd() only set the read notification, overwriting any
write notification set up in the lines just above.
|
|
|
|
| |
This keep everything consistent.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
It's a reoccurring issue that users try to build individual components
by pointing cmake at a specific subdirectory, e.g. 'cmake vncviewer'.
CMake, unfortunately, has insufficient protection against this so we'll
need to add a manual check.
This commit only adds it to the most likely places for misuse so we
don't have to pollute every CMakeLists.txt.
|
|
|
|
|
| |
All the information we need is now available in keysymdef.h, so let's
get everything updated and in sync.
|
|
|
|
| |
Make it easier to see what's code and what's just a lot of data.
|
|
|
|
|
| |
This is a manually set up table specific for TigerVNC. For clarity,
separate it out from the general keysym/Unicode table.
|
|
|
|
|
|
|
|
|
| |
This is mainly a copy of XKeysymToString() from libX11. We've also added
a wrapper that still gives a string, even if there is no name for the
requested keysym.
This grows the binaries a bit, but not with any extreme amount so is
hopefully worth it to get better debug logging.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can get races with clipboard managers in the server that is very
confusing to the user.
When the clipboard changes locally, we tell the server to drop the old
clipboard (as it is now lost). But we don't send over the new clipboard
until we get focus again, in order to not leak more data than necessary.
This causes some clibpoard managers to take over ownership in order to
avoid an empty clipboard. And this takes precedence over the new client
clipboard as it happened later. Effectively reverting the clipboard the
user sees.
Avoid all of this by simply ignoring the server when we don't have
focus. This is likely what users expect anyway as they expect their
currently focused application to control the clipboard, not vncviewer in
the background.
|
|
|
|
|
|
| |
Don't assume a lack of TCP listeners means the server will be
unreachable. There might be other methods of access, so let the higher
levels do that sanity check instead.
|
|
|
|
|
|
|
| |
Using "c" is in conflict the the "Ctrl" entry, so we need to pick
something else here.
This was a regression introduced in 44b085a.
|
|
|
|
|
|
|
|
| |
FLTK only allows 256 different box types, but it doesn't actually check
this when registering new ones.
Move our custom types to a valid range, and add an assert for good
measure to make sure we don't overflow FLTK's internal structures.
|
| |
|
|
|
|
|
| |
Follow the colors that modern desktops use when it comes to background,
text and selections.
|
|
|
|
|
|
|
| |
There is something broken with these FLTK draw routines on Windows. They
leave gaps at the start and end of the arc/pie rather than filling the
whole specified span. So we need to nudge the numbers a bit to work
around this.
|