aboutsummaryrefslogtreecommitdiffstats
path: root/vncviewer
Commit message (Collapse)AuthorAgeFilesLines
* Prevent incorrect cmake usagePierre Ossman2023-12-281-0/+4
| | | | | | | | | | It's a reoccurring issue that users try to build individual components by pointing cmake at a specific subdirectory, e.g. 'cmake vncviewer'. CMake, unfortunately, has insufficient protection against this so we'll need to add a manual check. This commit only adds it to the most likely places for misuse so we don't have to pollute every CMakeLists.txt.
* Automatically generate keyucsmap.hPierre Ossman2023-12-132-54/+109
| | | | | All the information we need is now available in keysymdef.h, so let's get everything updated and in sync.
* Move Keysym/Unicode mapping table to separate filePierre Ossman2023-12-132-789/+800
| | | | Make it easier to see what's code and what's just a lot of data.
* Move dead/combining keys to separate tablePierre Ossman2023-12-131-39/+82
| | | | | This is a manually set up table specific for TigerVNC. For clarity, separate it out from the general keysym/Unicode table.
* Add own keysym to name functionPierre Ossman2023-11-161-10/+3
| | | | | | | | | This is mainly a copy of XKeysymToString() from libX11. We've also added a wrapper that still gives a string, even if there is no name for the requested keysym. This grows the binaries a bit, but not with any extreme amount so is hopefully worth it to get better debug logging.
* fix spelling errorut0045272023-11-061-1/+1
|
* Completely ignore server clipboard when unfocusedPierre Ossman2023-09-112-20/+4
| | | | | | | | | | | | | | | | | | We can get races with clipboard managers in the server that is very confusing to the user. When the clipboard changes locally, we tell the server to drop the old clipboard (as it is now lost). But we don't send over the new clipboard until we get focus again, in order to not leak more data than necessary. This causes some clibpoard managers to take over ownership in order to avoid an empty clipboard. And this takes precedence over the new client clipboard as it happened later. Effectively reverting the clipboard the user sees. Avoid all of this by simply ignoring the server when we don't have focus. This is likely what users expect anyway as they expect their currently focused application to control the clipboard, not vncviewer in the background.
* More graceful handling of disabled listenersPierre Ossman2023-09-081-0/+2
| | | | | | Don't assume a lack of TCP listeners means the server will be unreachable. There might be other methods of access, so let the higher levels do that sanity check instead.
* Change accelerator for "Disconnect" entryPierre Ossman2023-08-211-1/+1
| | | | | | | Using "c" is in conflict the the "Ctrl" entry, so we need to pick something else here. This was a regression introduced in 44b085a.
* Move custom FLTK box types to valid rangePierre Ossman2023-08-172-1/+6
| | | | | | | | FLTK only allows 256 different box types, but it doesn't actually check this when registering new ones. Move our custom types to a valid range, and add an assert for good measure to make sure we don't overflow FLTK's internal structures.
* Update copyright year to 2023Samuel Mannehed2023-07-202-2/+2
|
* Use modern UI colorsPierre Ossman2023-07-141-6/+34
| | | | | Follow the colors that modern desktops use when it comes to background, text and selections.
* Workaround for broken fl_arc()/fl_pie()Pierre Ossman2023-07-141-0/+25
| | | | | | | There is something broken with these FLTK draw routines on Windows. They leave gaps at the start and end of the arc/pie rather than filling the whole specified span. So we need to nudge the numbers a bit to work around this.
* Apply custom theme to FLTKPierre Ossman2023-07-142-7/+204
| | | | | | | | | | | Inspired by modern Windows appearance, and to some extent macOS. They have flat boxes and use white, or very light, colors for interactive elements. Unfortunately we can't directly control the colors of widgets, so instead we just lighten everything that uses this box type. GNOME uses a different design, both their older and newer style. But UI look is less consistent on Linux, so hopefully our new look is decent enough there as well.
* Fix correct background in Fl_Input_ChoicePierre Ossman2023-07-141-0/+2
| | | | | Work around a bug in Fl_Input_Choice where it forgets to set the proper "input background" on some parts.
* Respect selection color in monitor widgetPierre Ossman2023-07-132-4/+2
| | | | We should have a consistent color set over all widgets.
* Don't tag up gettext's *wprintf() functionsPierre Ossman2023-07-061-3/+3
| | | | | | | | | | gcc doesn't support -Wformat for the wide format versions of printf() and friends yet: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=38308 Do what glibc does and have some commented out tags to show future intent.
* Unbreak -Wformat warnings when gettext is usedPierre Ossman2023-07-051-1/+23
| | | | | | | | | | gettext replaces all *printf() functions on platforms that don't fully conform to the POSIX behaviour. Unfortunately, gettext fails to tag these replacement functions properly so that -Wformat can still do its thing. Resolve this by adding a redudant declaration of the relevant functions, with the attribute tagging in place.
* Use smaller, stable, int for history indexPierre Ossman2023-07-051-2/+2
| | | | | | The size of size_t depends on the architecture, so we need to have different conversion to and from strings. But we don't really need that range, so avoid the issue by using a standard integer size.
* Fix WM_CLASS in desktop filePierre Ossman2023-07-031-1/+1
| | | | | The WM_CLASS we set on all windows is just "vncviewer", so that it matches the name of the .desktop file, which is what GNOME expects.
* Merge branch 'types2' of https://github.com/CendioOssman/tigervncPierre Ossman2023-06-303-2/+7
|\
| * Clean up string encoding handlingPierre Ossman2023-06-301-0/+5
| | | | | | | | | | | | We should handle this in the low-level protocol code as much as possible to avoid mistakes. This way the rest of the code can assume that strings are always UTF-8 with \n line endings.
| * Consistently use uint8_t for data buffersPierre Ossman2023-03-182-2/+2
| | | | | | | | | | These will always be byte streams at heart, so let's try to keep them with a proper type. Should make it clearer how they will be used.
* | Remove unneeded "using namespace"Pierre Ossman2023-06-144-5/+0
| | | | | | | | The need for these must have got lost somewhere in the type cleanup.
* | Avoid wildcards in cmake rulesPierre Ossman2023-04-171-4/+10
| | | | | | | | They are not fully supported and break with some backends, like Ninja.
* | Prefer target_include_directories()Pierre Ossman2023-03-311-6/+4
| | | | | | | | | | It is more specific, and it properly sets up propagation when include directories also need to be used further down a dependency chain.
* | Detect leaving window on zaphod systemsPierre Ossman2023-03-081-1/+9
|/ | | | | | | The coordinates we get are relative the root window of each screen, so we can only trust them if we are on the same screen. So let's explicitly check that we are still getting events from the expected screen by checking the root window field of the event.
* Merge "Pixel" type in to PixelFormat headerPierre Ossman2023-02-181-1/+0
| | | | | It's a type specific to that class, so let's keep them close for clarity.
* Use operator overloading for comparisonPierre Ossman2023-02-041-1/+1
| | | | | It is much more natural than custom methods for this very common operation.
* Remove unused rfb/util.h includesPierre Ossman2023-02-042-0/+2
| | | | | | | | These files don't use anything from this header, so remove the include. This exposes some missing includes in other places, though. So add an explicit include in the files that were relying on an indirect inclusion.
* Use std::string for string memory managementPierre Ossman2023-02-043-14/+11
| | | | | Avoids a bit of complexity by delegating that handling to a string object.
* Use std::string instead of CharArrayPierre Ossman2023-02-042-5/+5
| | | | | Let's use a more common type instead of something homegrown. Should be more familiar to new developers.
* Return std::string instead of dynamic allocationsPierre Ossman2023-02-046-30/+26
| | | | | | We mostly use classical C strings, but the memory management around them can get confusing and error prone. Let's use std::string for the cases where we need to return a newly allocated string.
* Use fixed size character bufferPierre Ossman2023-02-041-4/+3
| | | | | We know the needed space here, so let's keep it simple with a constant size string buffer.
* Remove trailing slash from getvnchomedir()Pierre Ossman2023-02-042-4/+4
| | | | | It should return a path to the directory itself, just like its sister function getuserhomedir().
* Namespace directory functionsPierre Ossman2023-02-043-7/+7
| | | | All library functions should be in a proper namespace.
* Return static char buffer from some methodsPierre Ossman2023-02-044-20/+13
| | | | | | | | | This mimics how some system functions (like inet_ntop()) work, and avoids complexity around ownership of the returned string buffer. The downside is that the string must be consumed directly as it will be overwritten on the next call, but that is not an issue with the current usage.
* Use StringParameters directlyPierre Ossman2023-02-042-5/+5
| | | | | We don't need to make extra copies of the string in most cases, so let's simplify the code and access the string directly when we can.
* Get rid of TCHAR magicPierre Ossman2023-02-041-1/+0
| | | | | We never use Windows' "UNICODE" mode anyway, so let's get rid of this complexity.
* Use stdint typesPierre Ossman2023-02-0110-30/+29
| | | | | Avoid having our own custom stuff and instead use the modern, standard types, for familiarity.
* Use __attribute__:s directlyPierre Ossman2023-01-052-15/+6
| | | | | | These are supported by gcc and clang, and I don't think MSVC works well with our code anyway, so let's keep things simple and use these directly.
* Don't partially init monitor informationPierre Ossman2023-01-051-1/+1
| | | | gcc will complain, and we will fill out all fields later anyway.
* Fix incorrect typesPierre Ossman2023-01-051-4/+4
| | | | | These types caused an incorrect signed/unsigned behaviour, so let's make sure we use the appropriate type.
* Remove useless checksPierre Ossman2023-01-051-3/+0
| | | | These are all truisms because of the valid range of the types.
* Explicitly mark switch case fall throughPierre Ossman2023-01-052-0/+2
| | | | | This allows us to separate accidental fall through from explicit ones, which allows us to turn on such checks in the compiler.
* Add missing breaks to Windows key grab codePierre Ossman2023-01-041-0/+2
| | | | | These were not meant to fall through. Likely didn't have any adverse effects, but let's fix it anyway.
* Explicitly mark unused parametersPierre Ossman2023-01-0411-33/+46
| | | | | This allows us to separate accidentally unused, from explicitly unused parameters, which allows us to turn on such checks in the compiler.
* Respect given server namePierre Ossman2023-01-041-1/+1
| | | | | No practical difference currently, but let's respect what this API was supposed to do.
* Don't include unused file path parameterPierre Ossman2023-01-041-3/+3
|
* Mark system include paths correctlyPierre Ossman2023-01-041-2/+2
| | | | | This makes sure the compiler doesn't complain about problems in those files.
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-05 13:11:24 +0000