aboutsummaryrefslogtreecommitdiffstats
path: root/vncviewer
Commit message (Collapse)AuthorAgeFilesLines
* Fix typosAndrew Kreimer2024-08-121-2/+2
|
* Don't adjust manually sized windowPierre Ossman2024-08-121-7/+0
| | | | | | | It's unclear why this code was ever added, and it can be very confusing that the window partially adjusts itself. The code is also in conflict with the earlier comment that states we'll leave the window size alone if it didn't perfectly match before the resize.
* Better type for pointer button maskPierre Ossman2024-08-124-15/+15
| | | | | This is a very limited bit field, so use an 8 bit type to clearly show how many bits are available.
* Don't ask for login data when reconnectingJohannes2024-08-075-2/+57
|
* Better error message for authentication failurePierre Ossman2024-08-071-0/+4
|
* Correctly handle cancelled authenticationPierre Ossman2024-08-072-1/+5
| | | | | We should not be throwing up error messages, or asking to reconnect, if the user has actively cancelled the authentication attempt.
* Avoid shadowing variablesPierre Ossman2024-06-2414-98/+114
| | | | | It's a source of confusion and possibly bugs to reuse the same variable name for multiple things.
* Use "static" for helper functionsPierre Ossman2024-06-242-3/+3
| | | | | These functions act only on the input parameters, so let's make them static to more clearly indicate that they do not act upon any object.
* Simplify code using range-based for loopsPierre Ossman2024-06-244-42/+32
| | | | | | | | | These are often more readable as they avoid a lot of the boilerplate of iterating over fixed arrays or STL containers. Note that this change is very conservative to avoid noise in "git blame". Only loops where this is a clear improvement have been converted.
* Mark overridden virtual functionsPierre Ossman2024-06-2413-45/+48
| | | | | Use the new "override" keyword to properly differentiate between new virtual methods, and existing virtual methods being overridden.
* Disable gcc NULL warning for context menuPierre Ossman2024-06-241-1/+4
| | | | | | We use the pointer to just store an identifier for the menu, but this is enough for gcc to think we are using 0 instead of nullptr and complain. Even an explicit cast isn't enough to silence it here for some reason.
* Use nullptr in all C++ codePierre Ossman2024-06-2426-198/+203
| | | | | It's more readable than 0, and a bit safer than NULL, so let's try to follow modern norms.
* Merge branch 'present' of github.com:CendioOssman/tigervncPierre Ossman2024-06-195-10/+6
|\
| * Explicitly request timer repetitionPierre Ossman2024-06-194-9/+5
| | | | | | | | | | | | One-shot timers are more common, so let's change the API a bit to make that use case simpler. This API also makes it more clear what is happening.
| * Stop treating "0" as "no timeouts"Pierre Ossman2024-06-191-1/+1
| | | | | | | | | | It is much more sane to treat "0" as "a timer is ready NOW", so let's change to using -1 as the invalid timeout value.
* | Create common recursive mkdir()Pierre Ossman2024-05-301-34/+15
| | | | | | | | | | | | | | Avoid duplicating this complexity in too many places. At the same time make the interface more identical to regular mkdir(), for familiarity.
* | Merge pull request #1737 from 62832/fix-1195Samuel Mannehed (ThinLinc team)2024-05-075-32/+81
|\ \ | | | | | | Allow for alternative user config locations, deprecate `~/.vnc` in favour of XDG Base Directory Specification paths
| * | Implement XDG Base Directory paths, deprecate ~/.vnc902024-04-263-10/+35
| | |
| * | Begin work on XDGBDS compliance and overrideable configs902024-03-153-26/+50
| |/
* | Use XQueryPointer() instead to detect zaphodPierre Ossman2024-04-101-4/+8
| | | | | | | | | | | | FLTK can send events with fl_xevent pointing to random memory, which means that we cannot trust that structure. XQueryPointer() can give us what we need, at the cost of an extra round trip.
* | Correctly set socket write notificationPierre Ossman2024-04-091-2/+0
|/ | | | | That extra add_fd() only set the read notification, overwriting any write notification set up in the lines just above.
* Set all HAVE_ macros on the top levelPierre Ossman2024-01-241-1/+0
| | | | This keep everything consistent.
* Update copyright year to 2024Samuel Mannehed2024-01-092-2/+2
|
* Prevent incorrect cmake usagePierre Ossman2023-12-281-0/+4
| | | | | | | | | | It's a reoccurring issue that users try to build individual components by pointing cmake at a specific subdirectory, e.g. 'cmake vncviewer'. CMake, unfortunately, has insufficient protection against this so we'll need to add a manual check. This commit only adds it to the most likely places for misuse so we don't have to pollute every CMakeLists.txt.
* Automatically generate keyucsmap.hPierre Ossman2023-12-132-54/+109
| | | | | All the information we need is now available in keysymdef.h, so let's get everything updated and in sync.
* Move Keysym/Unicode mapping table to separate filePierre Ossman2023-12-132-789/+800
| | | | Make it easier to see what's code and what's just a lot of data.
* Move dead/combining keys to separate tablePierre Ossman2023-12-131-39/+82
| | | | | This is a manually set up table specific for TigerVNC. For clarity, separate it out from the general keysym/Unicode table.
* Add own keysym to name functionPierre Ossman2023-11-161-10/+3
| | | | | | | | | This is mainly a copy of XKeysymToString() from libX11. We've also added a wrapper that still gives a string, even if there is no name for the requested keysym. This grows the binaries a bit, but not with any extreme amount so is hopefully worth it to get better debug logging.
* fix spelling errorut0045272023-11-061-1/+1
|
* Completely ignore server clipboard when unfocusedPierre Ossman2023-09-112-20/+4
| | | | | | | | | | | | | | | | | | We can get races with clipboard managers in the server that is very confusing to the user. When the clipboard changes locally, we tell the server to drop the old clipboard (as it is now lost). But we don't send over the new clipboard until we get focus again, in order to not leak more data than necessary. This causes some clibpoard managers to take over ownership in order to avoid an empty clipboard. And this takes precedence over the new client clipboard as it happened later. Effectively reverting the clipboard the user sees. Avoid all of this by simply ignoring the server when we don't have focus. This is likely what users expect anyway as they expect their currently focused application to control the clipboard, not vncviewer in the background.
* More graceful handling of disabled listenersPierre Ossman2023-09-081-0/+2
| | | | | | Don't assume a lack of TCP listeners means the server will be unreachable. There might be other methods of access, so let the higher levels do that sanity check instead.
* Change accelerator for "Disconnect" entryPierre Ossman2023-08-211-1/+1
| | | | | | | Using "c" is in conflict the the "Ctrl" entry, so we need to pick something else here. This was a regression introduced in 44b085a.
* Move custom FLTK box types to valid rangePierre Ossman2023-08-172-1/+6
| | | | | | | | FLTK only allows 256 different box types, but it doesn't actually check this when registering new ones. Move our custom types to a valid range, and add an assert for good measure to make sure we don't overflow FLTK's internal structures.
* Update copyright year to 2023Samuel Mannehed2023-07-202-2/+2
|
* Use modern UI colorsPierre Ossman2023-07-141-6/+34
| | | | | Follow the colors that modern desktops use when it comes to background, text and selections.
* Workaround for broken fl_arc()/fl_pie()Pierre Ossman2023-07-141-0/+25
| | | | | | | There is something broken with these FLTK draw routines on Windows. They leave gaps at the start and end of the arc/pie rather than filling the whole specified span. So we need to nudge the numbers a bit to work around this.
* Apply custom theme to FLTKPierre Ossman2023-07-142-7/+204
| | | | | | | | | | | Inspired by modern Windows appearance, and to some extent macOS. They have flat boxes and use white, or very light, colors for interactive elements. Unfortunately we can't directly control the colors of widgets, so instead we just lighten everything that uses this box type. GNOME uses a different design, both their older and newer style. But UI look is less consistent on Linux, so hopefully our new look is decent enough there as well.
* Fix correct background in Fl_Input_ChoicePierre Ossman2023-07-141-0/+2
| | | | | Work around a bug in Fl_Input_Choice where it forgets to set the proper "input background" on some parts.
* Respect selection color in monitor widgetPierre Ossman2023-07-132-4/+2
| | | | We should have a consistent color set over all widgets.
* Don't tag up gettext's *wprintf() functionsPierre Ossman2023-07-061-3/+3
| | | | | | | | | | gcc doesn't support -Wformat for the wide format versions of printf() and friends yet: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=38308 Do what glibc does and have some commented out tags to show future intent.
* Unbreak -Wformat warnings when gettext is usedPierre Ossman2023-07-051-1/+23
| | | | | | | | | | gettext replaces all *printf() functions on platforms that don't fully conform to the POSIX behaviour. Unfortunately, gettext fails to tag these replacement functions properly so that -Wformat can still do its thing. Resolve this by adding a redudant declaration of the relevant functions, with the attribute tagging in place.
* Use smaller, stable, int for history indexPierre Ossman2023-07-051-2/+2
| | | | | | The size of size_t depends on the architecture, so we need to have different conversion to and from strings. But we don't really need that range, so avoid the issue by using a standard integer size.
* Fix WM_CLASS in desktop filePierre Ossman2023-07-031-1/+1
| | | | | The WM_CLASS we set on all windows is just "vncviewer", so that it matches the name of the .desktop file, which is what GNOME expects.
* Merge branch 'types2' of https://github.com/CendioOssman/tigervncPierre Ossman2023-06-303-2/+7
|\
| * Clean up string encoding handlingPierre Ossman2023-06-301-0/+5
| | | | | | | | | | | | We should handle this in the low-level protocol code as much as possible to avoid mistakes. This way the rest of the code can assume that strings are always UTF-8 with \n line endings.
| * Consistently use uint8_t for data buffersPierre Ossman2023-03-182-2/+2
| | | | | | | | | | These will always be byte streams at heart, so let's try to keep them with a proper type. Should make it clearer how they will be used.
* | Remove unneeded "using namespace"Pierre Ossman2023-06-144-5/+0
| | | | | | | | The need for these must have got lost somewhere in the type cleanup.
* | Avoid wildcards in cmake rulesPierre Ossman2023-04-171-4/+10
| | | | | | | | They are not fully supported and break with some backends, like Ninja.
* | Prefer target_include_directories()Pierre Ossman2023-03-311-6/+4
| | | | | | | | | | It is more specific, and it properly sets up propagation when include directories also need to be used further down a dependency chain.
* | Detect leaving window on zaphod systemsPierre Ossman2023-03-081-1/+9
|/ | | | | | | The coordinates we get are relative the root window of each screen, so we can only trust them if we are on the same screen. So let's explicitly check that we are still getting events from the expected screen by checking the root window field of the event.
generated by cgit v1.2.3 (git 2.39.1) at 2025-02-03 20:23:58 +0000