From 35cc69aef494039387e75bb8fda5739f32f83f9a Mon Sep 17 00:00:00 2001 From: Pierre Ossman Date: Mon, 27 Jan 2025 07:09:01 +0100 Subject: Fix incorrect removal of config parameters Bad logic introduced in 28e35d0. Fortunately, nothing currently uses this method. --- common/rfb/Configuration.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/rfb/Configuration.cxx b/common/rfb/Configuration.cxx index 653890ab..e6c37b7e 100644 --- a/common/rfb/Configuration.cxx +++ b/common/rfb/Configuration.cxx @@ -121,7 +121,7 @@ bool Configuration::remove(const char* param) { [param](VoidParameter* p) { return strcasecmp(p->getName(), param) == 0; }); - if (iter != params.end()) + if (iter == params.end()) return false; params.erase(iter); -- cgit v1.2.3