Fixed TabSheet keyboard navigation (#12971)

Change-Id: Ibb155946811eb43829c6c200fa83c5eaa1d7cdfa

2 files changed, 62 insertions, 4 deletions

diff --git a/client/src/com/vaadin/client/ui/VTabsheet.java b/client/src/com/vaadin/client/ui/VTabsheet.java
index c64216d49f..68a685965b 100644
--- a/client/src/com/vaadin/client/ui/VTabsheet.java
+++ b/client/src/com/vaadin/client/ui/VTabsheet.java
@@ -421,10 +421,6 @@ public class VTabsheet extends VTabsheetBase implements Focusable,
             }
 
             int index = getWidgetIndex(caption.getParent());
-            // IE needs explicit focus()
-            if (BrowserInfo.get().isIE()) {
-                getTabsheet().focus();
-            }
             getTabsheet().onTabSelected(index);
         }
 
@@ -619,6 +615,8 @@ public class VTabsheet extends VTabsheetBase implements Focusable,
             client.updateVariable(id, "selected", tabKeys.get(tabIndex)
                     .toString(), true);
             waitingForResponse = true;
+
+            tb.getTab(tabIndex).focus(); // move keyboard focus to active tab
         }
         // Note that we return true when tabIndex == activeTabIndex; the active
         // tab could be selected, it's just a no-op.
diff --git a/uitest/src/com/vaadin/tests/components/tabsheet/TabsheetScrollingTest.java b/uitest/src/com/vaadin/tests/components/tabsheet/TabsheetScrollingTest.java
new file mode 100644
index 0000000000..1670963b9b
--- /dev/null
+++ b/uitest/src/com/vaadin/tests/components/tabsheet/TabsheetScrollingTest.java
@@ -0,0 +1,60 @@
+/*
+ * Copyright 2000-2013 Vaadin Ltd.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.vaadin.tests.components.tabsheet;
+
+import org.junit.Assert;
+import org.junit.Test;
+import org.openqa.selenium.Keys;
+import org.openqa.selenium.WebElement;
+import org.openqa.selenium.interactions.Actions;
+
+import com.vaadin.testbench.By;
+import com.vaadin.tests.tb3.MultiBrowserTest;
+
+public class TabsheetScrollingTest extends MultiBrowserTest {
+
+    @Test
+    public void keyboardScrolling() {
+        openTestURL();
+        getTab(1).click();
+        for (int i = 0; i < 10; i++) {
+            sendKey(Keys.ARROW_RIGHT);
+        }
+        Assert.assertEquals("Hide this tab (21)", getHideButtonText());
+    }
+
+    private WebElement getTab(int index) {
+        return getDriver().findElement(
+                By.vaadin("/VVerticalLayout[0]/Slot[1]"
+                        + "/VVerticalLayout[0]/Slot[0]/VTabsheet[0]"
+                        + "/domChild[0]/domChild[0]/domChild[0]"
+                        + "/domChild[0]/domChild[" + index + "]"));
+
+    }
+
+    private String getHideButtonText() {
+        WebElement buttonCaption = getDriver().findElement(
+                By.vaadin("/VVerticalLayout[0]/Slot[1]/VVerticalLayout[0]"
+                        + "/Slot[0]/VTabsheet[0]/VTabsheetPanel[0]"
+                        + "/VButton[0]/domChild[0]/domChild[0]"));
+        return buttonCaption.getText();
+    }
+
+    private void sendKey(Keys key) {
+        new Actions(getDriver()).sendKeys(key).perform();
+    }
+
+}