summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTeppo Kurki <teppo.kurki@vaadin.com>2013-12-30 21:47:18 +0200
committerLeif Åstrand <leif@vaadin.com>2014-01-03 06:59:34 +0000
commit65c2f2bf06986d397169e58f819ba1592fa52bb7 (patch)
treea1013ac71ec1c1adef31e831aef9d200d1eca7ee
parent797ebdff7c1cb5c0d58910f3ff6e86bbdb91ea0a (diff)
downloadvaadin-framework-65c2f2bf06986d397169e58f819ba1592fa52bb7.tar.gz
vaadin-framework-65c2f2bf06986d397169e58f819ba1592fa52bb7.zip
Properly remove shadow event listeners to prevent IE8 memory leak (#13129)
Change-Id: I98becf08f56ce35a3ee47650d0d4e204e7d18e73
-rw-r--r--client/src/com/vaadin/client/ui/VOverlay.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/client/src/com/vaadin/client/ui/VOverlay.java b/client/src/com/vaadin/client/ui/VOverlay.java
index 2f5df6d4f3..e2c9001fed 100644
--- a/client/src/com/vaadin/client/ui/VOverlay.java
+++ b/client/src/com/vaadin/client/ui/VOverlay.java
@@ -241,10 +241,10 @@ public class VOverlay extends PopupPanel implements CloseHandler<PopupPanel> {
private void removeShadowIfPresent() {
if (isShadowAttached()) {
- shadow.removeFromParent();
-
// Remove event listener from the shadow
unsinkShadowEvents();
+
+ shadow.removeFromParent();
}
}