diff options
| author | Jouni Koivuviita <jouni@vaadin.com> | 2014-08-14 14:48:26 +0300 |
|---|---|---|
| committer | Vaadin Code Review <review@vaadin.com> | 2014-08-15 10:34:40 +0000 |
| commit | 56195677e92cb6ad9ac6e0e5ef2aae2a403d3fc0 (patch) | |
| tree | 0bdff9faf66df78490838db688b5c22fd3fc3a20 | |
| parent | 987505f4a9ffee33bd9edc48d412f5b29a3fccd2 (diff) | |
| download | vaadin-framework-56195677e92cb6ad9ac6e0e5ef2aae2a403d3fc0.tar.gz vaadin-framework-56195677e92cb6ad9ac6e0e5ef2aae2a403d3fc0.zip | |
Window close and maximize/restore buttons not visible on initial render in IE8 (Valo) #14413
Remove unnecessary FontAwesome declaration as well, which made the
characters look bad in IE8.
Change-Id: Ib0f9b01023b0a7a6f40513c80cbb6e6c69bd164c
| -rw-r--r-- | WebContent/VAADIN/themes/valo/components/_window.scss | 1 | ||||
| -rw-r--r-- | client/src/com/vaadin/client/ui/VWindow.java | 14 |
2 files changed, 14 insertions, 1 deletions
diff --git a/WebContent/VAADIN/themes/valo/components/_window.scss b/WebContent/VAADIN/themes/valo/components/_window.scss index d866ce2584..97859a62b2 100644 --- a/WebContent/VAADIN/themes/valo/components/_window.scss +++ b/WebContent/VAADIN/themes/valo/components/_window.scss @@ -125,7 +125,6 @@ $v-window-modality-curtain-background-color: #222 !default; line-height: $v-unit-size - 3px; text-align: center; cursor: pointer; - font-family: FontAwesome; font-size: round($v-font-size * 1.3); color: valo-font-color($v-window-background-color, .4); diff --git a/client/src/com/vaadin/client/ui/VWindow.java b/client/src/com/vaadin/client/ui/VWindow.java index 495e230156..7223e4ac83 100644 --- a/client/src/com/vaadin/client/ui/VWindow.java +++ b/client/src/com/vaadin/client/ui/VWindow.java @@ -245,6 +245,20 @@ public class VWindow extends VOverlay implements ShortcutActionHandlerOwner, * state. */ setTabStopEnabled(doTabStop); + + // Fix for #14413. Any pseudo elements inside these elements are not + // visible on initial render unless we shake the DOM. + if (BrowserInfo.get().isIE8()) { + closeBox.getStyle().setDisplay(Display.NONE); + maximizeRestoreBox.getStyle().setDisplay(Display.NONE); + Scheduler.get().scheduleFinally(new Command() { + @Override + public void execute() { + closeBox.getStyle().clearDisplay(); + maximizeRestoreBox.getStyle().clearDisplay(); + } + }); + } } @Override |