summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLeif Åstrand <leif@vaadin.com>2012-06-12 16:14:19 +0300
committerLeif Åstrand <leif@vaadin.com>2012-06-12 16:14:19 +0300
commitadcf03c1b5f05b38cda25819b732745c1a4859fc (patch)
treeb2597ef74fd70cd304c15ba1ee0c04e3a4be1ae4
parentab53fcaf5924e4dc471147c55674d0d7882e4fc1 (diff)
downloadvaadin-framework-adcf03c1b5f05b38cda25819b732745c1a4859fc.tar.gz
vaadin-framework-adcf03c1b5f05b38cda25819b732745c1a4859fc.zip
Refresh row cache in requestRepaintAll to avoid partial repaint (#8714)
-rw-r--r--src/com/vaadin/ui/Table.java8
-rw-r--r--tests/testbench/com/vaadin/tests/components/table/TableInTabsheet.java6
2 files changed, 10 insertions, 4 deletions
diff --git a/src/com/vaadin/ui/Table.java b/src/com/vaadin/ui/Table.java
index e41c3d2a42..fc736bfa93 100644
--- a/src/com/vaadin/ui/Table.java
+++ b/src/com/vaadin/ui/Table.java
@@ -1603,6 +1603,14 @@ public class Table extends AbstractSelect implements Action.Container,
super.requestRepaint();
}
+ @Override
+ public void requestRepaintAll() {
+ super.requestRepaintAll();
+
+ // Avoid sending a partial repaint (#8714)
+ refreshRowCache();
+ }
+
private void removeRowsFromCacheAndFillBottom(int firstIndex, int rows) {
int totalCachedRows = pageBuffer[CELL_ITEMID].length;
int totalRows = size();
diff --git a/tests/testbench/com/vaadin/tests/components/table/TableInTabsheet.java b/tests/testbench/com/vaadin/tests/components/table/TableInTabsheet.java
index 811bdd3433..27e624b810 100644
--- a/tests/testbench/com/vaadin/tests/components/table/TableInTabsheet.java
+++ b/tests/testbench/com/vaadin/tests/components/table/TableInTabsheet.java
@@ -103,14 +103,12 @@ public class TableInTabsheet extends AbstractTestRoot {
@Override
protected String getTestDescription() {
- // TODO Auto-generated method stub
- return null;
+ return "Chaning to a different tab and then back to the first tab should properly render the table.";
}
@Override
protected Integer getTicketNumber() {
- // TODO Auto-generated method stub
- return null;
+ return Integer.valueOf(8714);
}
}