summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohannes Dahlström <johannes.dahlstrom@vaadin.com>2011-12-16 12:47:56 +0000
committerJohannes Dahlström <johannes.dahlstrom@vaadin.com>2011-12-16 12:47:56 +0000
commita79c9749fc0adea7c5ed7163d210c501984b05e9 (patch)
treefd2f190b32da3c1e3c0941b6925e85724adcffed
parent780a2098cbd96a8befe35a4676bfe49a01a704f4 (diff)
downloadvaadin-framework-a79c9749fc0adea7c5ed7163d210c501984b05e9.tar.gz
vaadin-framework-a79c9749fc0adea7c5ed7163d210c501984b05e9.zip
#8040 Improved comment
svn changeset:22424/svn branch:6.7
-rw-r--r--src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java11
1 files changed, 9 insertions, 2 deletions
diff --git a/src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java b/src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java
index d77507084d..553934bf98 100644
--- a/src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java
@@ -4052,8 +4052,15 @@ public class VScrollTable extends FlowPanel implements Table, ScrollHandler,
reactLastRow = totalRows - 1;
}
if (lastRendered < reactFirstRow || firstRendered > reactLastRow) {
- // #8040 - scroll position is completely changed
- // TODO: should probably be done earlier
+ /*
+ * #8040 - scroll position is completely changed since the
+ * latest request, so request a new set of rows.
+ *
+ * TODO: We should probably check whether the fetched rows match
+ * the current scroll position right when they arrive, so as to
+ * not waste time rendering a set of rows that will never be
+ * visible...
+ */
rowRequestHandler.setReqFirstRow(reactFirstRow);
rowRequestHandler.setReqRows(reactLastRow - reactFirstRow + 1);
rowRequestHandler.deferRowFetch(1);