diff options
| author | Henrik Paul <henrik@vaadin.com> | 2015-04-02 16:03:54 +0300 |
|---|---|---|
| committer | Henrik Paul <henrik@vaadin.com> | 2015-04-02 16:06:23 +0300 |
| commit | c5118632a6772ac0791a5ca1a0471f140027cf64 (patch) | |
| tree | e47261852d3f81bf2176afd1e119c753b266eff5 | |
| parent | 0ca0240a30a9701cdf9fb071594a9e24ee810ad9 (diff) | |
| download | vaadin-framework-c5118632a6772ac0791a5ca1a0471f140027cf64.tar.gz vaadin-framework-c5118632a6772ac0791a5ca1a0471f140027cf64.zip | |
No unnecessary detail-request RPCs (#17367)
Change-Id: Ia5f00765d623a5fadd254f2146fbd9e5c9e1b86a
| -rw-r--r-- | client/src/com/vaadin/client/connectors/GridConnector.java | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/client/src/com/vaadin/client/connectors/GridConnector.java b/client/src/com/vaadin/client/connectors/GridConnector.java index 5554664566..d31baaa665 100644 --- a/client/src/com/vaadin/client/connectors/GridConnector.java +++ b/client/src/com/vaadin/client/connectors/GridConnector.java @@ -178,7 +178,7 @@ public class GridConnector extends AbstractHasComponentsConnector implements /** * Sets a new renderer for this column object - * + * * @param rendererConnector * a renderer connector object */ @@ -736,14 +736,17 @@ public class GridConnector extends AbstractHasComponentsConnector implements private final DetailsListener detailsListener = new DetailsListener() { @Override public void reapplyDetailsVisibility(int rowIndex, JsonObject row) { - if (row.hasKey(GridState.JSONKEY_DETAILS_VISIBLE) - && row.getBoolean(GridState.JSONKEY_DETAILS_VISIBLE)) { + if (hasDetailsOpen(row)) { getWidget().setDetailsVisible(rowIndex, true); + detailsConnectorFetcher.schedule(); } else { getWidget().setDetailsVisible(rowIndex, false); } + } - detailsConnectorFetcher.schedule(); + private boolean hasDetailsOpen(JsonObject row) { + return row.hasKey(GridState.JSONKEY_DETAILS_VISIBLE) + && row.getBoolean(GridState.JSONKEY_DETAILS_VISIBLE); } @Override |