Use a custom field factory for editor row (#16513)

Change-Id: I0102d93c7f661993a5a07d2bcdf511f433419300

3 files changed, 117 insertions, 5 deletions

diff --git a/server/src/com/vaadin/data/fieldgroup/DefaultFieldGroupFieldFactory.java b/server/src/com/vaadin/data/fieldgroup/DefaultFieldGroupFieldFactory.java
index 8e32585a47..b6bf97e68e 100644
--- a/server/src/com/vaadin/data/fieldgroup/DefaultFieldGroupFieldFactory.java
+++ b/server/src/com/vaadin/data/fieldgroup/DefaultFieldGroupFieldFactory.java
@@ -129,10 +129,6 @@ public class DefaultFieldGroupFieldFactory implements FieldGroupFieldFactory {
         return (T) field;
     }
 
-    private boolean anyField(Class<?> fieldType) {
-        return fieldType == Field.class || fieldType == AbstractField.class;
-    }
-
     protected AbstractSelect createCompatibleSelect(
             Class<? extends AbstractSelect> fieldType) {
         AbstractSelect select;
@@ -157,7 +153,23 @@ public class DefaultFieldGroupFieldFactory implements FieldGroupFieldFactory {
         return select;
     }
 
-    private boolean anySelect(Class<? extends Field> fieldType) {
+    /**
+     * @since 7.4
+     * @param fieldType
+     *            the type of the field
+     * @return true if any AbstractField can be assigned to the field
+     */
+    protected boolean anyField(Class<?> fieldType) {
+        return fieldType == Field.class || fieldType == AbstractField.class;
+    }
+
+    /**
+     * @since 7.4
+     * @param fieldType
+     *            the type of the field
+     * @return true if any AbstractSelect can be assigned to the field
+     */
+    protected boolean anySelect(Class<? extends Field> fieldType) {
         return anyField(fieldType) || fieldType == AbstractSelect.class;
     }
 
diff --git a/server/src/com/vaadin/ui/Grid.java b/server/src/com/vaadin/ui/Grid.java
index adb08e0fcc..3c0afbc484 100644
--- a/server/src/com/vaadin/ui/Grid.java
+++ b/server/src/com/vaadin/ui/Grid.java
@@ -22,6 +22,7 @@ import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
+import java.util.EnumSet;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Iterator;
@@ -47,7 +48,9 @@ import com.vaadin.data.Item;
 import com.vaadin.data.Property;
 import com.vaadin.data.RpcDataProviderExtension;
 import com.vaadin.data.RpcDataProviderExtension.DataProviderKeyMapper;
+import com.vaadin.data.fieldgroup.DefaultFieldGroupFieldFactory;
 import com.vaadin.data.fieldgroup.FieldGroup;
+import com.vaadin.data.fieldgroup.FieldGroup.BindException;
 import com.vaadin.data.fieldgroup.FieldGroup.CommitException;
 import com.vaadin.data.fieldgroup.FieldGroupFieldFactory;
 import com.vaadin.data.sort.Sort;
@@ -166,6 +169,11 @@ public class Grid extends AbstractComponent implements SelectionNotifier,
      * been bound.
      */
     private final class CustomFieldGroup extends FieldGroup {
+
+        public CustomFieldGroup() {
+            setFieldFactory(EditorFieldFactory.get());
+        }
+
         @Override
         protected Class<?> getPropertyType(Object propertyId)
                 throws BindException {
@@ -178,6 +186,59 @@ public class Grid extends AbstractComponent implements SelectionNotifier,
     }
 
     /**
+     * Field factory used by default in the editor.
+     * 
+     * Aims to fields of suitable type and with suitable size for use in the
+     * editor row.
+     */
+    public static class EditorFieldFactory extends
+            DefaultFieldGroupFieldFactory {
+        private static final EditorFieldFactory INSTANCE = new EditorFieldFactory();
+
+        protected EditorFieldFactory() {
+        }
+
+        /**
+         * Returns the singleton instance
+         * 
+         * @return the singleton instance
+         */
+        public static EditorFieldFactory get() {
+            return INSTANCE;
+        }
+
+        @Override
+        public <T extends Field> T createField(Class<?> type, Class<T> fieldType) {
+            T f = super.createField(type, fieldType);
+            if (f != null) {
+                f.setWidth("100%");
+            }
+            return f;
+        }
+
+        @Override
+        protected AbstractSelect createCompatibleSelect(
+                Class<? extends AbstractSelect> fieldType) {
+            if (anySelect(fieldType)) {
+                return super.createCompatibleSelect(ComboBox.class);
+            }
+            return super.createCompatibleSelect(fieldType);
+        }
+
+        @Override
+        protected void populateWithEnumData(AbstractSelect select,
+                Class<? extends Enum> enumClass) {
+            // Use enums directly and the EnumToStringConverter to be consistent
+            // with what is shown in the Grid
+            @SuppressWarnings("unchecked")
+            EnumSet<?> enumSet = EnumSet.allOf(enumClass);
+            for (Object r : enumSet) {
+                select.addItem(r);
+            }
+        }
+    }
+
+    /**
      * Selection modes representing built-in {@link SelectionModel
      * SelectionModels} that come bundled with {@link Grid}.
      * <p>
diff --git a/uitest/src/com/vaadin/tests/fieldgroup/BasicCrudGridEditorRowTest.java b/uitest/src/com/vaadin/tests/fieldgroup/BasicCrudGridEditorRowTest.java
new file mode 100644
index 0000000000..3ccd547417
--- /dev/null
+++ b/uitest/src/com/vaadin/tests/fieldgroup/BasicCrudGridEditorRowTest.java
@@ -0,0 +1,39 @@
+/*
+ * Copyright 2000-2014 Vaadin Ltd.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.vaadin.tests.fieldgroup;
+
+import org.junit.Test;
+import org.openqa.selenium.interactions.Actions;
+
+import com.vaadin.testbench.elements.GridElement;
+import com.vaadin.testbench.elements.GridElement.GridCellElement;
+import com.vaadin.tests.tb3.MultiBrowserTest;
+
+public class BasicCrudGridEditorRowTest extends MultiBrowserTest {
+
+    @Test
+    public void lookAndFeel() throws Exception {
+        openTestURL();
+        GridElement grid = $(GridElement.class).first();
+        GridCellElement ritaBirthdate = grid.getCell(2, 3);
+        compareScreen("grid");
+
+        // Open editor row
+        new Actions(getDriver()).doubleClick(ritaBirthdate).perform();
+        compareScreen("editorrow");
+
+    }
+}