diff options
author | Artur Signell <artur@vaadin.com> | 2014-12-18 12:07:41 +0200 |
---|---|---|
committer | Vaadin Code Review <review@vaadin.com> | 2014-12-18 10:44:05 +0000 |
commit | dac2d7ec49d0213ddd2977b9a3dc05c8366ff6b2 (patch) | |
tree | 576671206119756f3fb4af7e4fe8c0c584d8c9fd | |
parent | 399b62d0ecd593efbb5563db957017ef43a3945c (diff) | |
download | vaadin-framework-dac2d7ec49d0213ddd2977b9a3dc05c8366ff6b2.tar.gz vaadin-framework-dac2d7ec49d0213ddd2977b9a3dc05c8366ff6b2.zip |
Fix inconsistencies in CheckBox clear and isEmpty (#14755)
Change-Id: I566257d3a4db15973f76a5a70adb095bd7203918
-rw-r--r-- | server/src/com/vaadin/ui/CheckBox.java | 11 | ||||
-rw-r--r-- | server/tests/src/com/vaadin/ui/CheckBoxTest.java | 48 |
2 files changed, 59 insertions, 0 deletions
diff --git a/server/src/com/vaadin/ui/CheckBox.java b/server/src/com/vaadin/ui/CheckBox.java index e26e5c4750..e98a2b61b9 100644 --- a/server/src/com/vaadin/ui/CheckBox.java +++ b/server/src/com/vaadin/ui/CheckBox.java @@ -253,4 +253,15 @@ public class CheckBox extends AbstractField<Boolean> { def.getValue(), Boolean.class); } + @Override + public void clear() { + setValue(Boolean.FALSE); + } + + @Override + public boolean isEmpty() { + return getValue() == null || getValue().equals(Boolean.FALSE); + + } + } diff --git a/server/tests/src/com/vaadin/ui/CheckBoxTest.java b/server/tests/src/com/vaadin/ui/CheckBoxTest.java new file mode 100644 index 0000000000..7d699998de --- /dev/null +++ b/server/tests/src/com/vaadin/ui/CheckBoxTest.java @@ -0,0 +1,48 @@ +/* + * Copyright 2000-2014 Vaadin Ltd. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package com.vaadin.ui; + +import org.junit.Assert; +import org.junit.Test; + +import com.vaadin.data.util.ObjectProperty; + +public class CheckBoxTest { + @Test + public void initiallyEmpty() { + CheckBox tf = new CheckBox(); + Assert.assertTrue(tf.isEmpty()); + } + + @Test + public void emptyAfterClearUsingPDS() { + CheckBox tf = new CheckBox(); + tf.setPropertyDataSource(new ObjectProperty<Boolean>(Boolean.TRUE)); + Assert.assertFalse(tf.isEmpty()); + tf.clear(); + Assert.assertTrue(tf.isEmpty()); + } + + @Test + public void emptyAfterClear() { + CheckBox tf = new CheckBox(); + tf.setValue(true); + Assert.assertFalse(tf.isEmpty()); + tf.clear(); + Assert.assertTrue(tf.isEmpty()); + } + +} |