diff options
author | Anna Koskinen <Ansku@users.noreply.github.com> | 2020-05-14 12:06:45 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-05-14 12:06:45 +0300 |
commit | 8acc300acd5b859159bdf14ea4c1ad69ac250dbb (patch) | |
tree | d166e89e75323a54470c2ca9fbbce4887462c93f | |
parent | 992fe46ec822b0995fb04cb9e1fe8a13854aa8a0 (diff) | |
download | vaadin-framework-8acc300acd5b859159bdf14ea4c1ad69ac250dbb.tar.gz vaadin-framework-8acc300acd5b859159bdf14ea4c1ad69ac250dbb.zip |
Fix indexing issue in Compatibility Grid resize when scrolled to bottom. (#12003) (#12006)
Issue #11893
-rwxr-xr-x | compatibility-client/src/main/java/com/vaadin/v7/client/widgets/Escalator.java | 1 | ||||
-rw-r--r-- | uitest/src/main/java/com/vaadin/tests/components/grid/CompatibilityGridScrollDownResize.java | 34 |
2 files changed, 35 insertions, 0 deletions
diff --git a/compatibility-client/src/main/java/com/vaadin/v7/client/widgets/Escalator.java b/compatibility-client/src/main/java/com/vaadin/v7/client/widgets/Escalator.java index 3aafe416fc..6af497efb3 100755 --- a/compatibility-client/src/main/java/com/vaadin/v7/client/widgets/Escalator.java +++ b/compatibility-client/src/main/java/com/vaadin/v7/client/widgets/Escalator.java @@ -3720,6 +3720,7 @@ public class Escalator extends Widget visualRowOrder.getLast()) + 1; moveAndUpdateEscalatorRows(Range.withOnly(0), visualRowOrder.size(), newLogicalIndex); + updateTopRowLogicalIndex(1); } } } diff --git a/uitest/src/main/java/com/vaadin/tests/components/grid/CompatibilityGridScrollDownResize.java b/uitest/src/main/java/com/vaadin/tests/components/grid/CompatibilityGridScrollDownResize.java new file mode 100644 index 0000000000..973598f18f --- /dev/null +++ b/uitest/src/main/java/com/vaadin/tests/components/grid/CompatibilityGridScrollDownResize.java @@ -0,0 +1,34 @@ +package com.vaadin.tests.components.grid; + +import com.vaadin.server.VaadinRequest; +import com.vaadin.tests.components.AbstractTestUI; +import com.vaadin.tests.minitutorials.v7_4.GridExampleHelper; +import com.vaadin.ui.VerticalLayout; +import com.vaadin.v7.ui.Grid; + +public class CompatibilityGridScrollDownResize extends AbstractTestUI { + + @Override + protected void setup(VaadinRequest request) { + // container with at least 100 rows + final Grid grid = new Grid(GridExampleHelper.createContainer()); + grid.setSizeFull(); + addComponent(grid); + getLayout().setSizeFull(); + getLayout().setExpandRatio(grid, 2); + ((VerticalLayout) getLayout().getParent()).setSizeFull(); + } + + @Override + protected Integer getTicketNumber() { + return 11893; + }; + + @Override + protected String getTestDescription() { + return "Scrolling all the way down, resizing the browser window smaller " + + "so that one row gets completely hidden, and scrolling down " + + "again should keep the row contents consistent and in expected " + + "sequence."; + } +} |