diff options
| author | Anna Koskinen <Ansku@users.noreply.github.com> | 2021-07-05 11:47:28 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-07-05 11:47:28 +0300 |
| commit | 7174593574ed0e204ba835cbbf2494ee714aaed2 (patch) | |
| tree | 892c8ef3d8cb651eb136895857967ed0701f1507 | |
| parent | 8b1b06f571d0abde4e11043823712ee5e4927fe5 (diff) | |
| download | vaadin-framework-7174593574ed0e204ba835cbbf2494ee714aaed2.tar.gz vaadin-framework-7174593574ed0e204ba835cbbf2494ee714aaed2.zip | |
Small updates to servlet container test setup. (#12318) (#12334)
* Small updates to servlet container test setup. (#12318)
* Small updates to servlet container test setup.
- Upgraded to use cargo-maven3-plugin since cargo-maven2-plugin is now
EOL.
- Defined supported packagings as the current jetty-maven-plugin default
only covers war.
- Changed a test pojo to implement Serializable in order to prevent an
error in cargo-maven3-plugin stop-container phase.
6 files changed, 10 insertions, 6 deletions
diff --git a/test/servlet-containers/generic-ui/src/main/java/com/vaadin/tests/integration/ServletIntegrationUI.java b/test/servlet-containers/generic-ui/src/main/java/com/vaadin/tests/integration/ServletIntegrationUI.java index 0d4010beaa..670d0ca8d5 100644 --- a/test/servlet-containers/generic-ui/src/main/java/com/vaadin/tests/integration/ServletIntegrationUI.java +++ b/test/servlet-containers/generic-ui/src/main/java/com/vaadin/tests/integration/ServletIntegrationUI.java @@ -1,5 +1,7 @@ package com.vaadin.tests.integration; +import java.io.Serializable; + import com.vaadin.annotations.DesignRoot; import com.vaadin.annotations.Widgetset; import com.vaadin.server.ClassResource; @@ -15,7 +17,7 @@ import com.vaadin.ui.declarative.Design; @Widgetset("com.vaadin.DefaultWidgetSet") public class ServletIntegrationUI extends UI { - public static class Country { + public static class Country implements Serializable { private final String name; private final String id; private final Resource icon; diff --git a/test/servlet-containers/pom.xml b/test/servlet-containers/pom.xml index 89e78e9277..500bf375cd 100644 --- a/test/servlet-containers/pom.xml +++ b/test/servlet-containers/pom.xml @@ -110,7 +110,8 @@ <!-- Generic cargo plugin configuration. Define container to use in submodule. --> <plugin> <groupId>org.codehaus.cargo</groupId> - <artifactId>cargo-maven2-plugin</artifactId> + <artifactId>cargo-maven3-plugin</artifactId> + <version>1.9.4</version> <configuration> <configuration> <type>standalone</type> @@ -194,6 +195,7 @@ <groupId>org.eclipse.jetty</groupId> <artifactId>jetty-maven-plugin</artifactId> <configuration> + <supportedPackagings>pom,jar,war</supportedPackagings> <webApp> <contextPath>${context.path}</contextPath> </webApp> diff --git a/test/servlet-containers/tomcat7/pom.xml b/test/servlet-containers/tomcat7/pom.xml index 28b2abee22..19d7f1397e 100644 --- a/test/servlet-containers/tomcat7/pom.xml +++ b/test/servlet-containers/tomcat7/pom.xml @@ -36,7 +36,7 @@ <!-- Server configuration --> <plugin> <groupId>org.codehaus.cargo</groupId> - <artifactId>cargo-maven2-plugin</artifactId> + <artifactId>cargo-maven3-plugin</artifactId> <configuration> <container> <containerId>tomcat7x</containerId> diff --git a/test/servlet-containers/tomcat80/pom.xml b/test/servlet-containers/tomcat80/pom.xml index d3ee9a476c..eb534f0c3f 100644 --- a/test/servlet-containers/tomcat80/pom.xml +++ b/test/servlet-containers/tomcat80/pom.xml @@ -36,7 +36,7 @@ <!-- Server configuration --> <plugin> <groupId>org.codehaus.cargo</groupId> - <artifactId>cargo-maven2-plugin</artifactId> + <artifactId>cargo-maven3-plugin</artifactId> <configuration> <container> <containerId>tomcat8x</containerId> diff --git a/test/servlet-containers/tomcat85/pom.xml b/test/servlet-containers/tomcat85/pom.xml index e1a693a509..ac4a749251 100644 --- a/test/servlet-containers/tomcat85/pom.xml +++ b/test/servlet-containers/tomcat85/pom.xml @@ -36,7 +36,7 @@ <!-- Server configuration --> <plugin> <groupId>org.codehaus.cargo</groupId> - <artifactId>cargo-maven2-plugin</artifactId> + <artifactId>cargo-maven3-plugin</artifactId> <configuration> <container> <containerId>tomcat8x</containerId> diff --git a/test/servlet-containers/tomcat9/pom.xml b/test/servlet-containers/tomcat9/pom.xml index fde7a4bbee..17dddaaa68 100644 --- a/test/servlet-containers/tomcat9/pom.xml +++ b/test/servlet-containers/tomcat9/pom.xml @@ -36,7 +36,7 @@ <!-- Server configuration --> <plugin> <groupId>org.codehaus.cargo</groupId> - <artifactId>cargo-maven2-plugin</artifactId> + <artifactId>cargo-maven3-plugin</artifactId> <configuration> <container> <containerId>tomcat9x</containerId> |