diff options
author | Anna Koskinen <Ansku@users.noreply.github.com> | 2021-11-03 15:38:14 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-11-03 15:38:14 +0200 |
commit | 9ccece724727d6229957dfa825849d6f5cbbed65 (patch) | |
tree | fa006b48e1057d5365b868634f57120c7db489d8 | |
parent | b62869bfb112317fd2f5cdeaff954241b03b8191 (diff) | |
download | vaadin-framework-9ccece724727d6229957dfa825849d6f5cbbed65.tar.gz vaadin-framework-9ccece724727d6229957dfa825849d6f5cbbed65.zip |
TableSortIndicatorTest fix (#12469)
Stabilize the tests by ensuring that the loading indicator is no longer
present when the screenshot comparison is done.
-rwxr-xr-x | uitest/reference-screenshots/chrome/TableSortIndicatorTest-ascendingIndicatorIsShown_ANY_Chrome__ascending.png | bin | 14132 -> 14154 bytes | |||
-rwxr-xr-x | uitest/reference-screenshots/chrome/TableSortIndicatorTest-descendingIndicatorIsShown_ANY_Chrome__descending.png | bin | 14140 -> 14130 bytes | |||
-rw-r--r-- | uitest/src/test/java/com/vaadin/tests/themes/valo/TableSortIndicatorTest.java | 2 |
3 files changed, 2 insertions, 0 deletions
diff --git a/uitest/reference-screenshots/chrome/TableSortIndicatorTest-ascendingIndicatorIsShown_ANY_Chrome__ascending.png b/uitest/reference-screenshots/chrome/TableSortIndicatorTest-ascendingIndicatorIsShown_ANY_Chrome__ascending.png Binary files differindex 58669454a1..dda7458004 100755 --- a/uitest/reference-screenshots/chrome/TableSortIndicatorTest-ascendingIndicatorIsShown_ANY_Chrome__ascending.png +++ b/uitest/reference-screenshots/chrome/TableSortIndicatorTest-ascendingIndicatorIsShown_ANY_Chrome__ascending.png diff --git a/uitest/reference-screenshots/chrome/TableSortIndicatorTest-descendingIndicatorIsShown_ANY_Chrome__descending.png b/uitest/reference-screenshots/chrome/TableSortIndicatorTest-descendingIndicatorIsShown_ANY_Chrome__descending.png Binary files differindex 0b6205d449..c07c3ea7d5 100755 --- a/uitest/reference-screenshots/chrome/TableSortIndicatorTest-descendingIndicatorIsShown_ANY_Chrome__descending.png +++ b/uitest/reference-screenshots/chrome/TableSortIndicatorTest-descendingIndicatorIsShown_ANY_Chrome__descending.png diff --git a/uitest/src/test/java/com/vaadin/tests/themes/valo/TableSortIndicatorTest.java b/uitest/src/test/java/com/vaadin/tests/themes/valo/TableSortIndicatorTest.java index 9fe927e84c..e05a69fb0b 100644 --- a/uitest/src/test/java/com/vaadin/tests/themes/valo/TableSortIndicatorTest.java +++ b/uitest/src/test/java/com/vaadin/tests/themes/valo/TableSortIndicatorTest.java @@ -21,6 +21,7 @@ public class TableSortIndicatorTest extends MultiBrowserTest { clickOnCellHeader(); + waitUntilLoadingIndicatorNotVisible(); compareScreen("ascending"); } @@ -32,6 +33,7 @@ public class TableSortIndicatorTest extends MultiBrowserTest { clickOnCellHeader(); clickOnSortIndicator(); + waitUntilLoadingIndicatorNotVisible(); compareScreen("descending"); } |