summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArtur Signell <artur.signell@itmill.com>2012-08-22 11:17:12 +0000
committerArtur Signell <artur.signell@itmill.com>2012-08-22 11:17:12 +0000
commit8c226ab0f258f7b294701612b51a1c8f96471f83 (patch)
tree6258b60dc29026f3aaa7fc9284a1f006957e93ab
parent1596ed4fc077bfb40cceb5cc71218aea05740d59 (diff)
downloadvaadin-framework-8c226ab0f258f7b294701612b51a1c8f96471f83.tar.gz
vaadin-framework-8c226ab0f258f7b294701612b51a1c8f96471f83.zip
Fixed SQLContainer and ComboBox co-operation problems (#9155)
svn changeset:24220/svn branch:6.8
-rw-r--r--src/com/vaadin/data/util/sqlcontainer/SQLContainer.java4
-rw-r--r--src/com/vaadin/ui/Select.java14
2 files changed, 2 insertions, 16 deletions
diff --git a/src/com/vaadin/data/util/sqlcontainer/SQLContainer.java b/src/com/vaadin/data/util/sqlcontainer/SQLContainer.java
index 71b260fa21..c9bd52f926 100644
--- a/src/com/vaadin/data/util/sqlcontainer/SQLContainer.java
+++ b/src/com/vaadin/data/util/sqlcontainer/SQLContainer.java
@@ -515,9 +515,7 @@ public class SQLContainer implements Container, Container.Filterable,
*/
public void removeContainerFilter(Filter filter) {
filters.remove(filter);
- // TODO this cannot be added before ComboBox is fixed
- // (Select.requestRepaint() must not affect filter string)
- // refresh();
+ refresh();
}
/**
diff --git a/src/com/vaadin/ui/Select.java b/src/com/vaadin/ui/Select.java
index 0ea331dc40..8f2c5175a2 100644
--- a/src/com/vaadin/ui/Select.java
+++ b/src/com/vaadin/ui/Select.java
@@ -656,7 +656,7 @@ public class Select extends AbstractSelect implements AbstractSelect.Filtering,
if (filterstring != null) {
filterstring = filterstring.toLowerCase();
}
- optionRepaint();
+ requestRepaint();
} else if (isNewItemsAllowed()) {
// New option entered (and it is allowed)
final String newitem = (String) variables.get("newitem");
@@ -677,18 +677,6 @@ public class Select extends AbstractSelect implements AbstractSelect.Filtering,
}
- @Override
- public void requestRepaint() {
- super.requestRepaint();
- optionRequest = false;
- prevfilterstring = filterstring;
- filterstring = null;
- }
-
- private void optionRepaint() {
- super.requestRepaint();
- }
-
public void setFilteringMode(int filteringMode) {
this.filteringMode = filteringMode;
}