Reverted constructor visibility changes, will use isSynthetic() test instead

svn changeset:14081/svn branch:6.4

11 files changed, 12 insertions, 22 deletions

diff --git a/src/com/vaadin/Application.java b/src/com/vaadin/Application.java
index 872bdc99ba..61df7c9f9a 100644
--- a/src/com/vaadin/Application.java
+++ b/src/com/vaadin/Application.java
@@ -1347,7 +1347,7 @@ public abstract class Application implements URIHandler,
         /**
          * Use {@link CustomizedSystemMessages} to customize
          */
-        SystemMessages() {
+        private SystemMessages() {
 
         }
 
diff --git a/src/com/vaadin/data/util/ContainerHierarchicalWrapper.java b/src/com/vaadin/data/util/ContainerHierarchicalWrapper.java
index f429cdc256..4dca5cf52b 100644
--- a/src/com/vaadin/data/util/ContainerHierarchicalWrapper.java
+++ b/src/com/vaadin/data/util/ContainerHierarchicalWrapper.java
@@ -67,7 +67,7 @@ public class ContainerHierarchicalWrapper implements Container.Hierarchical,
             Comparator<Object>, Serializable {
         private final Collection<?> itemIds;
 
-        public ListedItemsFirstComparator(Collection<?> itemIds) {
+        private ListedItemsFirstComparator(Collection<?> itemIds) {
             this.itemIds = itemIds;
         }
 
diff --git a/src/com/vaadin/data/util/FilesystemContainer.java b/src/com/vaadin/data/util/FilesystemContainer.java
index 7460a84b7f..1c9671d52d 100644
--- a/src/com/vaadin/data/util/FilesystemContainer.java
+++ b/src/com/vaadin/data/util/FilesystemContainer.java
@@ -596,7 +596,7 @@ public class FilesystemContainer implements Container.Hierarchical {
         /**
          * Constructs a FileItem from a existing file.
          */
-        FileItem(File file) {
+        private FileItem(File file) {
             this.file = file;
         }
 
diff --git a/src/com/vaadin/data/util/IndexedContainer.java b/src/com/vaadin/data/util/IndexedContainer.java
index e4dd54e276..2f6bae9851 100644
--- a/src/com/vaadin/data/util/IndexedContainer.java
+++ b/src/com/vaadin/data/util/IndexedContainer.java
@@ -747,7 +747,7 @@ public class IndexedContainer implements Container.Indexed,
     private class PropertySetChangeEvent extends EventObject implements
             Container.PropertySetChangeEvent, Serializable {
 
-        public PropertySetChangeEvent(IndexedContainer source) {
+        private PropertySetChangeEvent(IndexedContainer source) {
             super(source);
         }
 
@@ -813,7 +813,7 @@ public class IndexedContainer implements Container.Indexed,
     private class PropertyValueChangeEvent extends EventObject implements
             Property.ValueChangeEvent, Serializable {
 
-        public PropertyValueChangeEvent(Property source) {
+        private PropertyValueChangeEvent(Property source) {
             super(source);
         }
 
@@ -1068,7 +1068,7 @@ public class IndexedContainer implements Container.Indexed,
          * @param itemId
          *            the Item ID of the new Item.
          */
-        IndexedContainerItem(Object itemId) {
+        private IndexedContainerItem(Object itemId) {
 
             // Gets the item contents from the host
             if (itemId == null) {
@@ -1212,7 +1212,7 @@ public class IndexedContainer implements Container.Indexed,
          *            the list that contains the Item to contain the new
          *            Property.
          */
-        public IndexedContainerProperty(Object itemId, Object propertyId) {
+        private IndexedContainerProperty(Object itemId, Object propertyId) {
             if (itemId == null || propertyId == null) {
                 // Null ids are not accepted
                 throw new NullPointerException(
diff --git a/src/com/vaadin/data/util/PropertysetItem.java b/src/com/vaadin/data/util/PropertysetItem.java
index 825934c831..83eb15b6ad 100644
--- a/src/com/vaadin/data/util/PropertysetItem.java
+++ b/src/com/vaadin/data/util/PropertysetItem.java
@@ -166,7 +166,7 @@ public class PropertysetItem implements Item, Item.PropertySetChangeNotifier,
     private class PropertySetChangeEvent extends EventObject implements
             Item.PropertySetChangeEvent {
 
-        public PropertySetChangeEvent(Item source) {
+        private PropertySetChangeEvent(Item source) {
             super(source);
         }
 
diff --git a/src/com/vaadin/data/util/QueryContainer.java b/src/com/vaadin/data/util/QueryContainer.java
index 351d4af697..96788947a9 100644
--- a/src/com/vaadin/data/util/QueryContainer.java
+++ b/src/com/vaadin/data/util/QueryContainer.java
@@ -498,7 +498,7 @@ public class QueryContainer implements Container, Container.Ordered,
 
         Object id;
 
-        Row(Object rowId) {
+        private Row(Object rowId) {
             id = rowId;
         }
 
diff --git a/src/com/vaadin/event/ListenerMethod.java b/src/com/vaadin/event/ListenerMethod.java
index ec7ee6a2cf..b294dbf86d 100644
--- a/src/com/vaadin/event/ListenerMethod.java
+++ b/src/com/vaadin/event/ListenerMethod.java
@@ -596,7 +596,7 @@ public class ListenerMethod implements EventListener, Serializable {
 
         private String message;
 
-        MethodException(String message, Throwable cause) {
+        private MethodException(String message, Throwable cause) {
             super(message);
             this.cause = cause;
         }
diff --git a/src/com/vaadin/ui/AbstractSelect.java b/src/com/vaadin/ui/AbstractSelect.java
index 80a3a2f91c..510536a12b 100644
--- a/src/com/vaadin/ui/AbstractSelect.java
+++ b/src/com/vaadin/ui/AbstractSelect.java
@@ -1891,7 +1891,7 @@ public abstract class AbstractSelect extends AbstractField implements
         public static VerticalLocationIs MIDDLE = new VerticalLocationIs(
                 VerticalDropLocation.MIDDLE);
 
-        VerticalLocationIs(VerticalDropLocation l) {
+        private VerticalLocationIs(VerticalDropLocation l) {
             super("detail", l.name());
         }
     }
diff --git a/src/com/vaadin/ui/CustomComponent.java b/src/com/vaadin/ui/CustomComponent.java
index 25f829145c..e06fb321e3 100644
--- a/src/com/vaadin/ui/CustomComponent.java
+++ b/src/com/vaadin/ui/CustomComponent.java
@@ -156,11 +156,6 @@ public class CustomComponent extends AbstractComponentContainer {
             Serializable {
         boolean first = getCompositionRoot() != null;
 
-        public ComponentIterator() {
-            // needed to prevent generation of non-serializable access
-            // constructor classes as this nested class is private
-        }
-
         public boolean hasNext() {
             return first;
         }
diff --git a/src/com/vaadin/ui/SplitPanel.java b/src/com/vaadin/ui/SplitPanel.java
index 3385376e79..d38dc06f9e 100644
--- a/src/com/vaadin/ui/SplitPanel.java
+++ b/src/com/vaadin/ui/SplitPanel.java
@@ -73,11 +73,6 @@ public class SplitPanel extends AbstractLayout {
 
         int i = 0;
 
-        public ComponentIterator() {
-            // needed to prevent generation of non-serializable access
-            // constructor classes as this nested class is private
-        }
-
         public boolean hasNext() {
             if (i < (firstComponent == null ? 0 : 1)
                     + (secondComponent == null ? 0 : 1)) {
diff --git a/src/com/vaadin/ui/Window.java b/src/com/vaadin/ui/Window.java
index bb5dc89238..866c2d0c34 100644
--- a/src/com/vaadin/ui/Window.java
+++ b/src/com/vaadin/ui/Window.java
@@ -994,7 +994,7 @@ public class Window extends Panel implements URIHandler, ParameterHandler {
          * @param border
          *            The border style of the target window
          */
-        public OpenResource(Resource resource, String name, int width,
+        private OpenResource(Resource resource, String name, int width,
                 int height, int border) {
             this.resource = resource;
             this.name = name;