diff options
| author | Teemu Suo-Anttila <tsuoanttila@users.noreply.github.com> | 2018-03-13 13:55:44 +0200 |
|---|---|---|
| committer | Ilia Motornyi <elmot@vaadin.com> | 2018-03-13 14:55:44 +0300 |
| commit | 5deec671ffbefe7eb7388151e5009548179637a7 (patch) | |
| tree | f6076a705f185f8cadb2b9489b0bf3fdc05ea571 | |
| parent | 867ea6353d2160d84b4df3aeff9115776423d0a0 (diff) | |
| download | vaadin-framework-5deec671ffbefe7eb7388151e5009548179637a7.tar.gz vaadin-framework-5deec671ffbefe7eb7388151e5009548179637a7.zip | |
Fix performance issue in Grid initial render with Footer (#10705)
* Fix performance issue in Grid initial render with Footer
| -rw-r--r-- | client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java | 7 | ||||
| -rw-r--r-- | uitest/src/main/java/com/vaadin/tests/components/grid/GridManyColumns.java | 1 |
2 files changed, 4 insertions, 4 deletions
diff --git a/client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java b/client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java index fca1feab25..491aa0d9d2 100644 --- a/client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java +++ b/client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java @@ -211,10 +211,9 @@ public class GridConnector extends AbstractListingConnector Grid<JsonObject> grid = getWidget(); - // Remove default headers when initializing Grid widget - while (grid.getHeaderRowCount() > 0) { - grid.removeHeaderRow(0); - } + // Trigger early redraw of both grid static sections. + grid.setHeaderVisible(!grid.isHeaderVisible()); + grid.setFooterVisible(!grid.isFooterVisible()); registerRpc(GridClientRpc.class, new GridClientRpc() { diff --git a/uitest/src/main/java/com/vaadin/tests/components/grid/GridManyColumns.java b/uitest/src/main/java/com/vaadin/tests/components/grid/GridManyColumns.java index 7dca082a62..dd7cc6f043 100644 --- a/uitest/src/main/java/com/vaadin/tests/components/grid/GridManyColumns.java +++ b/uitest/src/main/java/com/vaadin/tests/components/grid/GridManyColumns.java @@ -22,6 +22,7 @@ public class GridManyColumns extends AbstractTestUI { .setWidth(200); } grid.setItems(IntStream.range(0, 10).boxed().map(i -> "")); + grid.appendFooterRow(); addComponent(grid); } } |