Fix for #4354 - SplitPanel setComponent methods should check if the component is already set

svn changeset:11908/svn branch:6.3

1 files changed, 10 insertions, 0 deletions

diff --git a/src/com/vaadin/ui/SplitPanel.java b/src/com/vaadin/ui/SplitPanel.java
index 1a149d7394..4319bf7d9c 100644
--- a/src/com/vaadin/ui/SplitPanel.java
+++ b/src/com/vaadin/ui/SplitPanel.java
@@ -105,6 +105,11 @@ public class SplitPanel extends AbstractLayout {
     }
 
     public void setFirstComponent(Component c) {
+        if (firstComponent == c) {
+            // Nothing to do
+            return;
+        }
+
         if (firstComponent != null) {
             // detach old
             removeComponent(firstComponent);
@@ -114,6 +119,11 @@ public class SplitPanel extends AbstractLayout {
     }
 
     public void setSecondComponent(Component c) {
+        if (c == secondComponent) {
+            // Nothing to do
+            return;
+        }
+
         if (secondComponent != null) {
             // detach old
             removeComponent(secondComponent);