aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArtur Signell <artur.signell@itmill.com>2008-09-02 13:12:54 +0000
committerArtur Signell <artur.signell@itmill.com>2008-09-02 13:12:54 +0000
commitc34d58b1ada9485883f1f1e2024f9c4e028ce76c (patch)
tree7ba5527d8f7cce4b58a689955ab76e8337f8d974
parente5842c1ebd81792aac9c5acb600e4a6f15c88f3b (diff)
downloadvaadin-framework-c34d58b1ada9485883f1f1e2024f9c4e028ce76c.tar.gz
vaadin-framework-c34d58b1ada9485883f1f1e2024f9c4e028ce76c.zip
Fix for #2043 - width/height for Link
svn changeset:5335/svn branch:trunk
-rw-r--r--src/com/itmill/toolkit/terminal/gwt/client/ui/ILink.java6
-rw-r--r--src/com/itmill/toolkit/tests/tickets/Ticket2043.java27
2 files changed, 30 insertions, 3 deletions
diff --git a/src/com/itmill/toolkit/terminal/gwt/client/ui/ILink.java b/src/com/itmill/toolkit/terminal/gwt/client/ui/ILink.java
index 37fa003853..4b9b86d1a3 100644
--- a/src/com/itmill/toolkit/terminal/gwt/client/ui/ILink.java
+++ b/src/com/itmill/toolkit/terminal/gwt/client/ui/ILink.java
@@ -81,10 +81,10 @@ public class ILink extends HTML implements Paintable, ClickListener {
borderStyle = BORDER_STYLE_DEFAULT;
}
- targetHeight = uidl.hasAttribute("height") ? uidl
+ targetHeight = uidl.hasAttribute("targetHeight") ? uidl
.getIntAttribute("targetHeight") : -1;
- targetWidth = uidl.hasAttribute("width") ? uidl
- .getIntAttribute("targetHeidth") : -1;
+ targetWidth = uidl.hasAttribute("targetWidth") ? uidl
+ .getIntAttribute("targetWidth") : -1;
// Set link caption
DOM.setInnerText(captionElement, uidl.getStringAttribute("caption"));
diff --git a/src/com/itmill/toolkit/tests/tickets/Ticket2043.java b/src/com/itmill/toolkit/tests/tickets/Ticket2043.java
new file mode 100644
index 0000000000..ba2f00fc98
--- /dev/null
+++ b/src/com/itmill/toolkit/tests/tickets/Ticket2043.java
@@ -0,0 +1,27 @@
+package com.itmill.toolkit.tests.tickets;
+
+import com.itmill.toolkit.Application;
+import com.itmill.toolkit.terminal.ExternalResource;
+import com.itmill.toolkit.ui.GridLayout;
+import com.itmill.toolkit.ui.Link;
+import com.itmill.toolkit.ui.Window;
+
+public class Ticket2043 extends Application {
+
+ public void init() {
+ Window w = new Window(getClass().getSimpleName());
+ setMainWindow(w);
+ // setTheme("tests-tickets");
+ GridLayout layout = new GridLayout(10, 10);
+ w.setLayout(layout);
+ createUI(layout);
+ }
+
+ private void createUI(GridLayout layout) {
+ Link l = new Link("IT Mill home (new 200x200 window, no decor, icon)",
+ new ExternalResource("http://www.itmill.com"), "_blank", 200,
+ 200, Link.TARGET_BORDER_NONE);
+
+ layout.addComponent(l);
+ }
+}