aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenri Sara <hesara@vaadin.com>2015-11-12 12:46:11 +0200
committerHenri Sara <hesara@vaadin.com>2016-01-15 14:42:58 +0200
commit029f3e59ef23625ef5171705e3fe1d54c7a531c7 (patch)
tree9757c65796941d2bf7fc7635f6b52922b57e4b7c
parentc85c5ec5b6e49b3e024c94df6ab615aa4a694307 (diff)
downloadvaadin-framework-029f3e59ef23625ef5171705e3fe1d54c7a531c7.tar.gz
vaadin-framework-029f3e59ef23625ef5171705e3fe1d54c7a531c7.zip
Minor ComboBox client side cleanup (#19929)
Remove unused references to immediate flags. Change-Id: I780fcf44f9824a132acb35d37d40d8c969d4f0f3
-rw-r--r--client/src/com/vaadin/client/ui/VFilterSelect.java25
-rw-r--r--client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java4
2 files changed, 2 insertions, 27 deletions
diff --git a/client/src/com/vaadin/client/ui/VFilterSelect.java b/client/src/com/vaadin/client/ui/VFilterSelect.java
index 0ef3dd07c1..5089793393 100644
--- a/client/src/com/vaadin/client/ui/VFilterSelect.java
+++ b/client/src/com/vaadin/client/ui/VFilterSelect.java
@@ -77,7 +77,6 @@ import com.vaadin.client.ui.combobox.ComboBoxConnector;
import com.vaadin.client.ui.menubar.MenuBar;
import com.vaadin.client.ui.menubar.MenuItem;
import com.vaadin.shared.AbstractComponentState;
-import com.vaadin.shared.EventId;
import com.vaadin.shared.ui.ComponentStateUtil;
import com.vaadin.shared.ui.combobox.FilteringMode;
import com.vaadin.shared.util.SharedUtil;
@@ -1633,22 +1632,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
* The filter to apply to the components
*/
public void filterOptions(int page, String filter) {
- filterOptions(page, filter, true);
- }
-
- /**
- * Filters the options at certain page using the given filter
- *
- * @param page
- * The page to filter
- * @param filter
- * The filter to apply to the options
- * @param immediate
- * Whether to send the options request immediately
- */
- private void filterOptions(int page, String filter, boolean immediate) {
- debug("VFS: filterOptions(" + page + ", " + filter + ", " + immediate
- + ")");
+ debug("VFS: filterOptions(" + page + ", " + filter + ")");
if (filter.equals(lastFilter) && currentPage == page) {
if (!suggestionPopup.isAttached()) {
@@ -2223,12 +2207,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
// ask suggestionPopup if it was just closed, we are using GWT
// Popup's auto close feature
if (!suggestionPopup.isJustClosed()) {
- // If a focus event is not going to be sent, send the options
- // request immediately; otherwise queue in the same burst as the
- // focus event. Fixes #8321.
- boolean immediate = focused
- || !connector.hasEventListener(EventId.FOCUS);
- filterOptions(-1, "", immediate);
+ filterOptions(-1, "");
dataReceivedHandler.popupOpenerClicked();
lastFilter = "";
}
diff --git a/client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java b/client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java
index 6f9860131d..b20fa851c7 100644
--- a/client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java
+++ b/client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java
@@ -47,8 +47,6 @@ public class ComboBoxConnector extends AbstractFieldConnector implements
protected FocusAndBlurServerRpc focusAndBlurRpc = RpcProxy.create(
FocusAndBlurServerRpc.class, this);
- private boolean immediate;
-
@Override
protected void init() {
super.init();
@@ -64,8 +62,6 @@ public class ComboBoxConnector extends AbstractFieldConnector implements
getWidget().readonly = isReadOnly();
getWidget().updateReadOnly();
- immediate = getState().immediate;
-
getWidget().setTextInputEnabled(getState().textInputAllowed);
if (getState().inputPrompt != null) {