diff options
author | caalador <mikael.grankvist@gmail.com> | 2017-02-08 13:04:12 +0200 |
---|---|---|
committer | Henri Sara <henri.sara@gmail.com> | 2017-02-08 13:04:12 +0200 |
commit | 84dc6c0b8876c8943a17b3f8ca8b06b680ddb0bb (patch) | |
tree | cd4fc28b30969b43923c7778c888b3e11951eebe /client/src | |
parent | 8c7974592f2a3fb289773c53c5ffe06481ff51b8 (diff) | |
download | vaadin-framework-84dc6c0b8876c8943a17b3f8ca8b06b680ddb0bb.tar.gz vaadin-framework-84dc6c0b8876c8943a17b3f8ca8b06b680ddb0bb.zip |
Fix keyboard navigation for ListSelect (#8503)
Fixes vaadin/framework8-issues#463
Diffstat (limited to 'client/src')
-rw-r--r-- | client/src/main/java/com/vaadin/client/ui/VListSelect.java | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/client/src/main/java/com/vaadin/client/ui/VListSelect.java b/client/src/main/java/com/vaadin/client/ui/VListSelect.java index 185c593b83..68d25bbe30 100644 --- a/client/src/main/java/com/vaadin/client/ui/VListSelect.java +++ b/client/src/main/java/com/vaadin/client/ui/VListSelect.java @@ -22,12 +22,13 @@ import java.util.Objects; import java.util.Set; import java.util.function.BiConsumer; -import com.google.gwt.event.dom.client.ClickEvent; -import com.google.gwt.event.dom.client.ClickHandler; +import com.google.gwt.event.dom.client.ChangeEvent; +import com.google.gwt.event.dom.client.ChangeHandler; import com.google.gwt.user.client.ui.Composite; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.HasEnabled; import com.google.gwt.user.client.ui.ListBox; + import com.vaadin.client.FastStringSet; import com.vaadin.client.Focusable; import com.vaadin.client.connectors.AbstractMultiSelectConnector.MultiSelectWidget; @@ -40,7 +41,7 @@ import elemental.json.JsonObject; * * @author Vaadin Ltd */ -public class VListSelect extends Composite implements ClickHandler, Field, +public class VListSelect extends Composite implements ChangeHandler, Field, Focusable, HasEnabled, MultiSelectWidget { private List<BiConsumer<Set<String>, Set<String>>> selectionChangeListeners = new ArrayList<>(); @@ -63,7 +64,7 @@ public class VListSelect extends Composite implements ClickHandler, Field, select = new ListBox(); select.setMultipleSelect(true); - select.addClickHandler(this); + select.addChangeHandler(this); container.add(select); @@ -161,8 +162,8 @@ public class VListSelect extends Composite implements ClickHandler, Field, } @Override - public void onClick(ClickEvent event) { - if (event.getSource() == select) { + public void onChange(ChangeEvent changeEvent) { + if (changeEvent.getSource() == select) { // selection can change by adding and at the same time removing // previous keys, or by just adding (e.g. when modifier keys are // pressed) |