diff options
author | Ahmed Ashour <asashour@yahoo.com> | 2017-10-10 12:06:27 +0200 |
---|---|---|
committer | Henri Sara <henri.sara@gmail.com> | 2017-10-10 13:06:27 +0300 |
commit | ab18b6c58ef819dbc0049c4713cf06209d5abc47 (patch) | |
tree | 84aec85fe2dbeae4b9b340481c5a18228c4ec296 /client | |
parent | 802bb98b851ab9b15617b283ccdba3dbc517ada6 (diff) | |
download | vaadin-framework-ab18b6c58ef819dbc0049c4713cf06209d5abc47.tar.gz vaadin-framework-ab18b6c58ef819dbc0049c4713cf06209d5abc47.zip |
Remove unneeded .toString() (#10141)
Diffstat (limited to 'client')
7 files changed, 16 insertions, 15 deletions
diff --git a/client/src/main/java/com/vaadin/client/MeasuredSize.java b/client/src/main/java/com/vaadin/client/MeasuredSize.java index 2029fd9e4d..1fcdb9d17a 100644 --- a/client/src/main/java/com/vaadin/client/MeasuredSize.java +++ b/client/src/main/java/com/vaadin/client/MeasuredSize.java @@ -280,7 +280,7 @@ public class MeasuredSize { String changedFrom, String changedTo) { if (debugSizeChanges) { getLogger().info(sizeChangeType + " has changed from " + changedFrom - + " to " + changedTo + " for " + element.toString()); + + " to " + changedTo + " for " + element); } } diff --git a/client/src/main/java/com/vaadin/client/communication/ServerRpcQueue.java b/client/src/main/java/com/vaadin/client/communication/ServerRpcQueue.java index 23b3490231..1460b978ac 100644 --- a/client/src/main/java/com/vaadin/client/communication/ServerRpcQueue.java +++ b/client/src/main/java/com/vaadin/client/communication/ServerRpcQueue.java @@ -251,7 +251,7 @@ public class ServerRpcQueue { String connectorId = invocation.getConnectorId(); if (!connectorExists(connectorId)) { getLogger().info("Ignoring RPC for removed connector: " - + connectorId + ": " + invocation.toString()); + + connectorId + ": " + invocation); continue; } @@ -269,8 +269,8 @@ public class ServerRpcQueue { Method method = type.getMethod(invocation.getMethodName()); parameterTypes = method.getParameterTypes(); } catch (NoDataException e) { - throw new RuntimeException( - "No type data for " + invocation.toString(), e); + throw new RuntimeException("No type data for " + invocation, + e); } } diff --git a/client/src/main/java/com/vaadin/client/metadata/Type.java b/client/src/main/java/com/vaadin/client/metadata/Type.java index 587731aac6..408d085d3d 100644 --- a/client/src/main/java/com/vaadin/client/metadata/Type.java +++ b/client/src/main/java/com/vaadin/client/metadata/Type.java @@ -89,7 +89,7 @@ public class Type { if (i != 0) { string += ','; } - string += parameterTypes[i].toString(); + string += parameterTypes[i]; } string += '>'; } diff --git a/client/src/main/java/com/vaadin/client/ui/VAccordion.java b/client/src/main/java/com/vaadin/client/ui/VAccordion.java index 6bba4f22eb..9ad4ef4e96 100644 --- a/client/src/main/java/com/vaadin/client/ui/VAccordion.java +++ b/client/src/main/java/com/vaadin/client/ui/VAccordion.java @@ -152,7 +152,7 @@ public class VAccordion extends VTabsheetBase { addStyleDependentName("loading"); connector.getRpcProxy(TabsheetServerRpc.class) - .setSelected(tabKeys.get(index).toString()); + .setSelected(tabKeys.get(index)); } } diff --git a/client/src/main/java/com/vaadin/client/ui/VTabsheet.java b/client/src/main/java/com/vaadin/client/ui/VTabsheet.java index 35c8c1c6fb..f5e137f6e4 100644 --- a/client/src/main/java/com/vaadin/client/ui/VTabsheet.java +++ b/client/src/main/java/com/vaadin/client/ui/VTabsheet.java @@ -828,7 +828,7 @@ public class VTabsheet extends VTabsheetBase getCurrentlyDisplayedWidget().getElement().getParentElement() .getStyle().setVisibility(Visibility.HIDDEN); - getRpcProxy().setSelected(tabKeys.get(tabIndex).toString()); + getRpcProxy().setSelected(tabKeys.get(tabIndex)); waitingForResponse = true; diff --git a/client/src/main/java/com/vaadin/client/ui/menubar/MenuBarConnector.java b/client/src/main/java/com/vaadin/client/ui/menubar/MenuBarConnector.java index 69fe368768..47d2eb0f35 100644 --- a/client/src/main/java/com/vaadin/client/ui/menubar/MenuBarConnector.java +++ b/client/src/main/java/com/vaadin/client/ui/menubar/MenuBarConnector.java @@ -131,7 +131,7 @@ public class MenuBarConnector extends AbstractComponentConnector } } - currentItem = currentMenu.addItem(itemHTML.toString(), cmd); + currentItem = currentMenu.addItem(itemHTML, cmd); currentItem.updateFromUIDL(item, client); if (item.getChildCount() > 0) { diff --git a/client/src/main/java/com/vaadin/client/widgets/Grid.java b/client/src/main/java/com/vaadin/client/widgets/Grid.java index 2b623804cf..80c7e354c7 100755 --- a/client/src/main/java/com/vaadin/client/widgets/Grid.java +++ b/client/src/main/java/com/vaadin/client/widgets/Grid.java @@ -3164,8 +3164,7 @@ public class Grid<T> extends ResizeComposite implements HasSelectionHandlers<T>, if (!columns.contains(column)) { throw new IllegalArgumentException( - "Given column is not a column in this grid. " - + column.toString()); + "Given column is not a column in this grid. " + column); } if (!column.isSortable()) { @@ -4724,8 +4723,8 @@ public class Grid<T> extends ResizeComposite implements HasSelectionHandlers<T>, @Override public void render(RendererCellReference cell, Object data) { if (!warned && !(data instanceof String)) { - getLogger().warning(Column.this.toString() + ": " - + DEFAULT_RENDERER_WARNING); + getLogger().warning( + Column.this + ": " + DEFAULT_RENDERER_WARNING); warned = true; } @@ -5599,7 +5598,8 @@ public class Grid<T> extends ResizeComposite implements HasSelectionHandlers<T>, boolean isSelected = hasData && isSelected(rowData); if (Grid.this.selectionModel.isSelectionAllowed()) { - rowElement.setAttribute("aria-selected", String.valueOf(isSelected)); + rowElement.setAttribute("aria-selected", + String.valueOf(isSelected)); } else { rowElement.removeAttribute("aria-selected"); } @@ -6318,10 +6318,11 @@ public class Grid<T> extends ResizeComposite implements HasSelectionHandlers<T>, * Adds the given role as 'role="$param"' to the {@code <table />} element * of the grid. * - * @param role the role param + * @param role + * the role param * @since 8.2 */ - protected void setAriaRole(String role){ + protected void setAriaRole(String role) { escalator.getTable().setAttribute("role", role); } |