aboutsummaryrefslogtreecommitdiffstats
path: root/client
diff options
context:
space:
mode:
authorAnastasia Smirnova <anasmi@utu.fi>2019-03-06 08:16:14 +0200
committerSun Zhe <31067185+ZheSun88@users.noreply.github.com>2019-03-06 08:16:14 +0200
commit6854108f316d04b8c5c10cc0add38f6158b43845 (patch)
treeb92a300d854cd7a7c9cd14b683f21c4af8fc7995 /client
parent6cc773fb7c717328fbce7255fa419581b7609a92 (diff)
downloadvaadin-framework-6854108f316d04b8c5c10cc0add38f6158b43845.tar.gz
vaadin-framework-6854108f316d04b8c5c10cc0add38f6158b43845.zip
Remove redundant check for for Firefox (#11471)
* Add Test file * Remove redundant check for for Firefox It seems that in older versions of Firefox (at least, older than 45) the KeyPress event should be used instead of KeyDownHandler. At some point (works already on 58 version, the current one is 65) the issue was resolved and starting from Firefox 65 this hook prevents from navigating in the pop-up via keyboard. Simply removing additional logic makes navigating in both DateField and InlineDateField possible Fixes #11465
Diffstat (limited to 'client')
-rw-r--r--client/src/main/java/com/vaadin/client/ui/VAbstractCalendarPanel.java11
1 files changed, 1 insertions, 10 deletions
diff --git a/client/src/main/java/com/vaadin/client/ui/VAbstractCalendarPanel.java b/client/src/main/java/com/vaadin/client/ui/VAbstractCalendarPanel.java
index 7a534de724..8f32d35acb 100644
--- a/client/src/main/java/com/vaadin/client/ui/VAbstractCalendarPanel.java
+++ b/client/src/main/java/com/vaadin/client/ui/VAbstractCalendarPanel.java
@@ -214,16 +214,7 @@ public abstract class VAbstractCalendarPanel<R extends Enum<R>>
setStyleName(VDateField.CLASSNAME + "-calendarpanel");
Roles.getGridRole().set(getElement());
- /*
- * Firefox auto-repeat works correctly only if we use a key press
- * handler, other browsers handle it correctly when using a key down
- * handler
- */
- if (BrowserInfo.get().isGecko()) {
- addKeyPressHandler(this);
- } else {
- addKeyDownHandler(this);
- }
+ addKeyDownHandler(this);
addFocusHandler(this);
addBlurHandler(this);
}