Prevent browser to scroll when space it pressed on a TabSheet (#14320)

Browser page scroll by default when space key is pressed.
The TabSheet uses the space key (32) to select the tab
when navigating using left/right keys. So when the space
is pressed the default browser page scroll behavior is
now prevented.

Change-Id: I8c3c7c4904109018d2f91447235e30dbd29eec5d

1 files changed, 15 insertions, 1 deletions

diff --git a/client/src/com/vaadin/client/ui/VTabsheet.java b/client/src/com/vaadin/client/ui/VTabsheet.java
index 15d9c83c49..35fdebf353 100644
--- a/client/src/com/vaadin/client/ui/VTabsheet.java
+++ b/client/src/com/vaadin/client/ui/VTabsheet.java
@@ -1280,6 +1280,7 @@ public class VTabsheet extends VTabsheetBase implements Focusable,
         if (event.getSource() instanceof Tab) {
             int keycode = event.getNativeEvent().getKeyCode();
 
+            // Scroll throw the tabs.
             if (!event.isAnyModifierKeyDown()) {
                 if (keycode == getPreviousTabKey()) {
                     selectPreviousTab();
@@ -1294,6 +1295,10 @@ public class VTabsheet extends VTabsheetBase implements Focusable,
                     }
                 } else if (keycode == getSelectTabKey()) {
                     loadTabSheet(focusedTabIndex);
+
+                    // Prevent the page from scrolling when hitting space
+                    // (select key) to select the current tab.
+                    event.preventDefault();
                 }
             }
         }
@@ -1307,8 +1312,17 @@ public class VTabsheet extends VTabsheetBase implements Focusable,
         return KeyCodes.KEY_LEFT;
     }
 
+    /**
+     * Gets the key to activate the selected tab when navigating using
+     * previous/next (left/right) keys.
+     * 
+     * @return the key to activate the selected tab.
+     * 
+     * @see #getNextTabKey()
+     * @see #getPreviousTabKey()
+     */
     protected int getSelectTabKey() {
-        return 32; // Space key
+        return KeyCodes.KEY_SPACE;
     }
 
     /**