Merge changes from origin/7.0

892b8ba Do not submit TextArea value on enter in IE (#11982)
bd3f975 Properly disable combobox when parent is disabled (#10734)
1b85e59 Added missing import (#11982)
3c8a3bf Merge of properly focus clicked input element in Webkit (#11854, #11297)
d647d7a Ensure VBrowserFrame content is unloaded in IE (#11683)
08ba394 Disable drag&drop when source or target component is disabled, re-implementation of 6.8 fix for #11801
b01427a Change field types from LinkedHashSet back to HashSet to retain binary compatibility (#11432)
14ebd0d Fixed newlines

Change-Id: Icea535d8d5130e013327dd76a194e3910f533332

8 files changed, 102 insertions, 20 deletions

diff --git a/client/src/com/vaadin/client/ui/VBrowserFrame.java b/client/src/com/vaadin/client/ui/VBrowserFrame.java
index c1e131a6c5..4e13921582 100644
--- a/client/src/com/vaadin/client/ui/VBrowserFrame.java
+++ b/client/src/com/vaadin/client/ui/VBrowserFrame.java
@@ -19,6 +19,7 @@ import com.google.gwt.dom.client.Document;
 import com.google.gwt.dom.client.Element;
 import com.google.gwt.dom.client.IFrameElement;
 import com.google.gwt.user.client.ui.Widget;
+import com.vaadin.client.BrowserInfo;
 
 public class VBrowserFrame extends Widget {
 
@@ -134,4 +135,23 @@ public class VBrowserFrame extends Widget {
             iframe.setName(name);
         }
     }
+
+    @Override
+    protected void onDetach() {
+        if (BrowserInfo.get().isIE()) {
+            // Force browser to fire unload event when component is detached
+            // from the view (IE doesn't do this automatically)
+            if (iframe != null) {
+                /*
+                 * src was previously set to javascript:false, but this was not
+                 * enough to overcome a bug when detaching an iframe with a pdf
+                 * loaded in IE9. about:blank seems to cause the adobe reader
+                 * plugin to unload properly before the iframe is removed. See
+                 * #7855
+                 */
+                iframe.setSrc("about:blank");
+            }
+        }
+        super.onDetach();
+    }
 }
diff --git a/client/src/com/vaadin/client/ui/VCheckBox.java b/client/src/com/vaadin/client/ui/VCheckBox.java
index bb49dd7f0a..94b37f418e 100644
--- a/client/src/com/vaadin/client/ui/VCheckBox.java
+++ b/client/src/com/vaadin/client/ui/VCheckBox.java
@@ -16,10 +16,13 @@
 
 package com.vaadin.client.ui;
 
+import com.google.gwt.event.dom.client.ClickEvent;
+import com.google.gwt.event.dom.client.ClickHandler;
 import com.google.gwt.user.client.DOM;
 import com.google.gwt.user.client.Element;
 import com.google.gwt.user.client.Event;
 import com.vaadin.client.ApplicationConnection;
+import com.vaadin.client.BrowserInfo;
 import com.vaadin.client.Util;
 import com.vaadin.client.VTooltip;
 import com.vaadin.client.ui.aria.AriaHelper;
@@ -55,6 +58,17 @@ public class VCheckBox extends com.google.gwt.user.client.ui.CheckBox implements
                     (DOM.getEventsSunk(el) | VTooltip.TOOLTIP_EVENTS));
             el = DOM.getNextSibling(el);
         }
+
+        if (BrowserInfo.get().isWebkit()) {
+            // Webkit does not focus non-text input elements on click
+            // (#11854)
+            addClickHandler(new ClickHandler() {
+                @Override
+                public void onClick(ClickEvent event) {
+                    setFocus(true);
+                }
+            });
+        }
     }
 
     @Override
diff --git a/client/src/com/vaadin/client/ui/VDragAndDropWrapper.java b/client/src/com/vaadin/client/ui/VDragAndDropWrapper.java
index f23bf88969..1c1173c295 100644
--- a/client/src/com/vaadin/client/ui/VDragAndDropWrapper.java
+++ b/client/src/com/vaadin/client/ui/VDragAndDropWrapper.java
@@ -80,7 +80,8 @@ public class VDragAndDropWrapper extends VCustomComponent implements
 
             @Override
             public void onMouseDown(MouseDownEvent event) {
-                if (startDrag(event.getNativeEvent())) {
+                if (getConnector().isEnabled()
+                        && startDrag(event.getNativeEvent())) {
                     event.preventDefault(); // prevent text selection
                 }
             }
@@ -90,7 +91,8 @@ public class VDragAndDropWrapper extends VCustomComponent implements
 
             @Override
             public void onTouchStart(TouchStartEvent event) {
-                if (startDrag(event.getNativeEvent())) {
+                if (getConnector().isEnabled()
+                        && startDrag(event.getNativeEvent())) {
                     /*
                      * Dont let eg. panel start scrolling.
                      */
@@ -112,8 +114,7 @@ public class VDragAndDropWrapper extends VCustomComponent implements
     private boolean startDrag(NativeEvent event) {
         if (dragStartMode == WRAPPER || dragStartMode == COMPONENT) {
             VTransferable transferable = new VTransferable();
-            transferable.setDragSource(ConnectorMap.get(client).getConnector(
-                    VDragAndDropWrapper.this));
+            transferable.setDragSource(getConnector());
 
             ComponentConnector paintable = Util.findPaintable(client,
                     (Element) event.getEventTarget().cast());
@@ -187,7 +188,7 @@ public class VDragAndDropWrapper extends VCustomComponent implements
 
     private boolean uploading;
 
-    private ReadyStateChangeHandler readyStateChangeHandler = new ReadyStateChangeHandler() {
+    private final ReadyStateChangeHandler readyStateChangeHandler = new ReadyStateChangeHandler() {
 
         @Override
         public void onReadyStateChange(XMLHttpRequest xhr) {
@@ -261,8 +262,7 @@ public class VDragAndDropWrapper extends VCustomComponent implements
             }
             if (VDragAndDropManager.get().getCurrentDropHandler() != getDropHandler()) {
                 VTransferable transferable = new VTransferable();
-                transferable.setDragSource(ConnectorMap.get(client)
-                        .getConnector(this));
+                transferable.setDragSource(getConnector());
 
                 vaadinDragEvent = VDragAndDropManager.get().startDrag(
                         transferable, event, false);
@@ -458,6 +458,9 @@ public class VDragAndDropWrapper extends VCustomComponent implements
 
         @Override
         public void dragEnter(VDragEvent drag) {
+            if (!getConnector().isEnabled()) {
+                return;
+            }
             updateDropDetails(drag);
             currentlyValid = false;
             super.dragEnter(drag);
@@ -471,6 +474,9 @@ public class VDragAndDropWrapper extends VCustomComponent implements
 
         @Override
         public void dragOver(final VDragEvent drag) {
+            if (!getConnector().isEnabled()) {
+                return;
+            }
             boolean detailsChanged = updateDropDetails(drag);
             if (detailsChanged) {
                 currentlyValid = false;
@@ -486,6 +492,9 @@ public class VDragAndDropWrapper extends VCustomComponent implements
 
         @Override
         public boolean drop(VDragEvent drag) {
+            if (!getConnector().isEnabled()) {
+                return false;
+            }
             deEmphasis(true);
 
             Map<String, Object> dd = drag.getDropDetails();
@@ -511,14 +520,16 @@ public class VDragAndDropWrapper extends VCustomComponent implements
 
         @Override
         protected void dragAccepted(VDragEvent drag) {
+            if (!getConnector().isEnabled()) {
+                return;
+            }
             currentlyValid = true;
             emphasis(drag);
         }
 
         @Override
         public ComponentConnector getConnector() {
-            return ConnectorMap.get(client).getConnector(
-                    VDragAndDropWrapper.this);
+            return VDragAndDropWrapper.this.getConnector();
         }
 
         @Override
@@ -528,6 +539,10 @@ public class VDragAndDropWrapper extends VCustomComponent implements
 
     }
 
+    public ComponentConnector getConnector() {
+        return ConnectorMap.get(client).getConnector(this);
+    }
+
     protected native void hookHtml5DragStart(Element el)
     /*-{
         var me = this;
@@ -594,8 +609,7 @@ public class VDragAndDropWrapper extends VCustomComponent implements
     }
 
     private void notifySizePotentiallyChanged() {
-        LayoutManager.get(client).setNeedsMeasure(
-                ConnectorMap.get(client).getConnector(getElement()));
+        LayoutManager.get(client).setNeedsMeasure(getConnector());
     }
 
     protected void emphasis(VDragEvent drag) {
diff --git a/client/src/com/vaadin/client/ui/VNativeButton.java b/client/src/com/vaadin/client/ui/VNativeButton.java
index 71413a76e6..67fa6f2ee3 100644
--- a/client/src/com/vaadin/client/ui/VNativeButton.java
+++ b/client/src/com/vaadin/client/ui/VNativeButton.java
@@ -143,8 +143,10 @@ public class VNativeButton extends Button implements ClickHandler {
             return;
         }
 
-        if (BrowserInfo.get().isSafari()) {
-            VNativeButton.this.setFocus(true);
+        if (BrowserInfo.get().isWebkit()) {
+            // Webkit does not focus non-text input elements on click
+            // (#11854)
+            setFocus(true);
         }
         if (disableOnClick) {
             setEnabled(false);
diff --git a/client/src/com/vaadin/client/ui/VOptionGroup.java b/client/src/com/vaadin/client/ui/VOptionGroup.java
index eed5549e39..a4c8b6733c 100644
--- a/client/src/com/vaadin/client/ui/VOptionGroup.java
+++ b/client/src/com/vaadin/client/ui/VOptionGroup.java
@@ -41,6 +41,7 @@ import com.google.gwt.user.client.ui.Panel;
 import com.google.gwt.user.client.ui.RadioButton;
 import com.google.gwt.user.client.ui.Widget;
 import com.vaadin.client.ApplicationConnection;
+import com.vaadin.client.BrowserInfo;
 import com.vaadin.client.UIDL;
 import com.vaadin.client.Util;
 import com.vaadin.shared.EventId;
@@ -161,8 +162,16 @@ public class VOptionGroup extends VOptionGroupBase implements FocusHandler,
     public void onClick(ClickEvent event) {
         super.onClick(event);
         if (event.getSource() instanceof CheckBox) {
-            final boolean selected = ((CheckBox) event.getSource()).getValue();
-            final String key = optionsToKeys.get(event.getSource());
+            CheckBox source = (CheckBox) event.getSource();
+
+            if (BrowserInfo.get().isWebkit()) {
+                // Webkit does not focus non-text input elements on click
+                // (#11854)
+                source.setFocus(true);
+            }
+
+            final boolean selected = source.getValue();
+            final String key = optionsToKeys.get(source);
             if (!isMultiselect()) {
                 selectedKeys.clear();
             }
diff --git a/client/src/com/vaadin/client/ui/VTextArea.java b/client/src/com/vaadin/client/ui/VTextArea.java
index 45e0532451..2a697969df 100644
--- a/client/src/com/vaadin/client/ui/VTextArea.java
+++ b/client/src/com/vaadin/client/ui/VTextArea.java
@@ -22,6 +22,7 @@ import com.google.gwt.dom.client.Style.WhiteSpace;
 import com.google.gwt.dom.client.TextAreaElement;
 import com.google.gwt.event.dom.client.ChangeEvent;
 import com.google.gwt.event.dom.client.ChangeHandler;
+import com.google.gwt.event.dom.client.KeyDownEvent;
 import com.google.gwt.event.dom.client.KeyUpEvent;
 import com.google.gwt.event.dom.client.KeyUpHandler;
 import com.google.gwt.user.client.Command;
@@ -285,4 +286,12 @@ public class VTextArea extends VTextField {
         }
         this.wordwrap = wordwrap;
     }
+
+    @Override
+    public void onKeyDown(KeyDownEvent event) {
+        // Overridden to avoid submitting TextArea value on enter in IE. This is
+        // another reason why widgets should inherit a common abstract
+        // class instead of directly each other.
+    }
+
 }
diff --git a/client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java b/client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java
index d9eac91e2b..f91ff9e2b9 100644
--- a/client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java
+++ b/client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java
@@ -50,9 +50,6 @@ public class ComboBoxConnector extends AbstractFieldConnector implements
         getWidget().paintableId = uidl.getId();
 
         getWidget().readonly = isReadOnly();
-        getWidget().enabled = isEnabled();
-
-        getWidget().tb.setEnabled(getWidget().enabled);
         getWidget().updateReadOnly();
 
         if (!isRealUpdate(uidl)) {
@@ -280,4 +277,11 @@ public class ComboBoxConnector extends AbstractFieldConnector implements
             widget.updateRootWidth();
         }
     }
+
+    @Override
+    public void setWidgetEnabled(boolean widgetEnabled) {
+        super.setWidgetEnabled(widgetEnabled);
+        getWidget().enabled = widgetEnabled;
+        getWidget().tb.setEnabled(widgetEnabled);
+    }
 }
diff --git a/client/src/com/vaadin/client/ui/dd/VDragAndDropManager.java b/client/src/com/vaadin/client/ui/dd/VDragAndDropManager.java
index ffc146ad04..dd838fdeff 100644
--- a/client/src/com/vaadin/client/ui/dd/VDragAndDropManager.java
+++ b/client/src/com/vaadin/client/ui/dd/VDragAndDropManager.java
@@ -287,7 +287,7 @@ public class VDragAndDropManager {
     protected VDragAndDropManager() {
     }
 
-    private NativePreviewHandler defaultDragAndDropEventHandler = new DefaultDragAndDropEventHandler();
+    private final NativePreviewHandler defaultDragAndDropEventHandler = new DefaultDragAndDropEventHandler();
 
     /**
      * Flag to indicate if drag operation has really started or not. Null check
@@ -469,7 +469,8 @@ public class VDragAndDropManager {
             if (w == null) {
                 return null;
             }
-            while (!(w instanceof VHasDropHandler)) {
+            while (!(w instanceof VHasDropHandler)
+                    || !isDropEnabled((VHasDropHandler) w)) {
                 w = w.getParent();
                 if (w == null) {
                     break;
@@ -492,6 +493,15 @@ public class VDragAndDropManager {
     }
 
     /**
+     * Checks if the given {@link VHasDropHandler} really is able to accept
+     * drops.
+     */
+    private static boolean isDropEnabled(VHasDropHandler target) {
+        VDropHandler dh = target.getDropHandler();
+        return dh != null && dh.getConnector().isEnabled();
+    }
+
+    /**
      * Drag is ended (drop happened) on current drop handler. Calls drop method
      * on current drop handler and does appropriate cleanup.
      */