diff options
| author | Willem Verstraeten <willem.verstraeten@gmail.com> | 2019-10-21 19:15:23 +0200 |
|---|---|---|
| committer | Tatu Lund <tatu@vaadin.com> | 2019-10-21 20:15:23 +0300 |
| commit | bb9473e77c00f1fdda9eb4fdbbbeefbf985a3e8f (patch) | |
| tree | 809b963e2f64fa9470362cdeb70107fd6af11a6c /compatibility-server | |
| parent | 333f4458e58439bd424dd1fca582118d0fcd70e6 (diff) | |
| download | vaadin-framework-bb9473e77c00f1fdda9eb4fdbbbeefbf985a3e8f.tar.gz vaadin-framework-bb9473e77c00f1fdda9eb4fdbbbeefbf985a3e8f.zip | |
Make cancellation of uploads work regardless of Push configuration (#11743)
- Checking the push configuration outside of session lock threw
an AssertionError, so the push configuration is not checked anymore.
- The original problem with cancelling Upload was due to a subtle
ordering issue that depended on the Push configuration.
In the case of PushMode.AUTOMATIC, a new StreamVariable was
added by the `Upload` component _before_ the `FileUploadHandler`
got a chance to remove the old `StreamVariable`. As a result, the
`FileUploadHandler` actually removed the fresh `StreamVariable`,
breaking future uploads.
Fixes #11682
Diffstat (limited to 'compatibility-server')
0 files changed, 0 insertions, 0 deletions