diff options
| author | Pekka Hyvönen <pekka@vaadin.com> | 2017-11-06 20:20:58 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-11-06 20:20:58 +0200 |
| commit | f7abbea6bef3eb46fa4f3580a7da2a2440463266 (patch) | |
| tree | 08f5548e33600dfd6ace1e962e9990ff90541118 /server/pom.xml | |
| parent | eb617673472871b84d029917fc15a202cca58e59 (diff) | |
| download | vaadin-framework-f7abbea6bef3eb46fa4f3580a7da2a2440463266.tar.gz vaadin-framework-f7abbea6bef3eb46fa4f3580a7da2a2440463266.zip | |
HasItems.setItems(T... items) should allow edits (#10290)
* HasItems.setItems(T... items) should allow edits
Arrays.asList() creates a immutable Arrays.ArrayList, preventing users from doing dataProvider.getItems() and updating the returned collection. This makes it impossible to keep the same data provider, update it and keep the filters & sorting, and then just call dataProvider.refreshAll() to get changes visible. We should not require users to create a new data provider in this case.
This is the same for DataProvider.ofItems(T... items)
* fix missing whitespace from test error message
Diffstat (limited to 'server/pom.xml')
| -rw-r--r-- | server/pom.xml | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/server/pom.xml b/server/pom.xml index 91df364a5e..c38f528e70 100644 --- a/server/pom.xml +++ b/server/pom.xml @@ -127,7 +127,12 @@ <artifactId>slf4j-log4j12</artifactId> <scope>test</scope> </dependency> - + <dependency> + <groupId>org.reflections</groupId> + <artifactId>reflections</artifactId> + <version>0.9.11</version> + <scope>test</scope> + </dependency> <!-- For manual testing with PostgreSQL (see SQLTestConstants) --> <!-- <dependency><groupId>postgresql</groupId><artifactId>postgresql</artifactId><version>9.1-901.jdbc3</version></dependency> --> </dependencies> |