Make fields with value change listener immediate

Makes fields with value change listener immediate without explicit
call. If immediate value has been explicitly set, it is honoured.
In most cases immediate now works seamlessly and excess server
round trips should be rare as a regression.

“Fixes” #8029 in a more elegant manner

Change-Id: Ic240c78c0a29447809a17de74196d3325a78ec1f

1 files changed, 17 insertions, 1 deletions

diff --git a/server/src/com/vaadin/ui/AbstractComponent.java b/server/src/com/vaadin/ui/AbstractComponent.java
index a0a87b260d..85671922a5 100644
--- a/server/src/com/vaadin/ui/AbstractComponent.java
+++ b/server/src/com/vaadin/ui/AbstractComponent.java
@@ -38,6 +38,7 @@ import com.vaadin.server.VaadinSession;
 import com.vaadin.shared.AbstractComponentState;
 import com.vaadin.shared.ComponentConstants;
 import com.vaadin.shared.ui.ComponentStateUtil;
+import com.vaadin.ui.Field.ValueChangeEvent;
 import com.vaadin.util.ReflectTools;
 
 /**
@@ -97,6 +98,8 @@ public abstract class AbstractComponent extends AbstractClientConnector
 
     private HasComponents parent;
 
+    private Boolean explicitImmediateValue;
+
     /* Constructor */
 
     /**
@@ -361,7 +364,17 @@ public abstract class AbstractComponent extends AbstractClientConnector
     }
 
     public boolean isImmediate() {
-        return getState(false).immediate;
+        if (explicitImmediateValue != null) {
+            return explicitImmediateValue;
+        } else if (hasListeners(ValueChangeEvent.class)) {
+            /*
+             * Automatic immediate for fields that developers are interested
+             * about.
+             */
+            return true;
+        } else {
+            return false;
+        }
     }
 
     /**
@@ -372,6 +385,7 @@ public abstract class AbstractComponent extends AbstractClientConnector
      *            immediate mode after the call.
      */
     public void setImmediate(boolean immediate) {
+        explicitImmediateValue = immediate;
         getState().immediate = immediate;
     }
 
@@ -668,6 +682,8 @@ public abstract class AbstractComponent extends AbstractClientConnector
         } else {
             getState().errorMessage = null;
         }
+
+        getState().immediate = isImmediate();
     }
 
     /* General event framework */