diff options
author | Fabian Lange <lange.fabian@gmail.com> | 2014-06-20 10:49:50 +0200 |
---|---|---|
committer | Vaadin Code Review <review@vaadin.com> | 2014-06-23 06:51:47 +0000 |
commit | 0c229ae91460fedaeb557bdc5a646433658b0dfb (patch) | |
tree | 4959adbc8ab29cc67515e44e2fc792d39ffba310 /server/src/com/vaadin/ui/MenuBar.java | |
parent | 6e109e4d73b7e3c09da3000a813904b52ea89991 (diff) | |
download | vaadin-framework-0c229ae91460fedaeb557bdc5a646433658b0dfb.tar.gz vaadin-framework-0c229ae91460fedaeb557bdc5a646433658b0dfb.zip |
Reading properties of components should not set state to dirty (#14060).
Many core vaadin components did incorrectly mark the state as dirty when
reading from them. This patch fixes the problem, which should reduce the
amount of server->client state updates significantly.
Change-Id: I342d74129e2985a7f407e9b53a802dc0146d9992
Diffstat (limited to 'server/src/com/vaadin/ui/MenuBar.java')
-rw-r--r-- | server/src/com/vaadin/ui/MenuBar.java | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/server/src/com/vaadin/ui/MenuBar.java b/server/src/com/vaadin/ui/MenuBar.java index 17a2f8e391..6b6555c0a2 100644 --- a/server/src/com/vaadin/ui/MenuBar.java +++ b/server/src/com/vaadin/ui/MenuBar.java @@ -57,6 +57,11 @@ public class MenuBar extends AbstractComponent implements LegacyComponent, return (MenuBarState) super.getState(); } + @Override + protected MenuBarState getState(boolean markAsDirty) { + return (MenuBarState) super.getState(markAsDirty); + } + /** Paint (serialise) the component for the client. */ @Override public void paintContent(PaintTarget target) throws PaintException { @@ -396,7 +401,7 @@ public class MenuBar extends AbstractComponent implements LegacyComponent, @Override public int getTabIndex() { - return getState().tabIndex; + return getState(false).tabIndex; } /* |