Reading properties of components should not set state to dirty (#14060).

Many core vaadin components did incorrectly mark the state as dirty when
reading from them. This patch fixes the problem, which should reduce the
amount of server->client state updates significantly.

Change-Id: I342d74129e2985a7f407e9b53a802dc0146d9992

1 files changed, 8 insertions, 3 deletions

diff --git a/server/src/com/vaadin/ui/Panel.java b/server/src/com/vaadin/ui/Panel.java
index 34ff6ec112..9b1d8fd5fa 100644
--- a/server/src/com/vaadin/ui/Panel.java
+++ b/server/src/com/vaadin/ui/Panel.java
@@ -171,7 +171,7 @@ public class Panel extends AbstractSingleComponentContainer implements
      */
     @Override
     public int getScrollLeft() {
-        return getState().scrollLeft;
+        return getState(false).scrollLeft;
     }
 
     /*
@@ -181,7 +181,7 @@ public class Panel extends AbstractSingleComponentContainer implements
      */
     @Override
     public int getScrollTop() {
-        return getState().scrollTop;
+        return getState(false).scrollTop;
     }
 
     /*
@@ -309,7 +309,7 @@ public class Panel extends AbstractSingleComponentContainer implements
      */
     @Override
     public int getTabIndex() {
-        return getState().tabIndex;
+        return getState(false).tabIndex;
     }
 
     /**
@@ -334,4 +334,9 @@ public class Panel extends AbstractSingleComponentContainer implements
         return (PanelState) super.getState();
     }
 
+    @Override
+    protected PanelState getState(boolean markAsDirty) {
+        return (PanelState) super.getState(markAsDirty);
+    }
+
 }