diff options
author | Fabian Lange <lange.fabian@gmail.com> | 2014-06-20 10:49:50 +0200 |
---|---|---|
committer | Vaadin Code Review <review@vaadin.com> | 2014-06-23 06:51:47 +0000 |
commit | 0c229ae91460fedaeb557bdc5a646433658b0dfb (patch) | |
tree | 4959adbc8ab29cc67515e44e2fc792d39ffba310 /server/src/com/vaadin/ui/Slider.java | |
parent | 6e109e4d73b7e3c09da3000a813904b52ea89991 (diff) | |
download | vaadin-framework-0c229ae91460fedaeb557bdc5a646433658b0dfb.tar.gz vaadin-framework-0c229ae91460fedaeb557bdc5a646433658b0dfb.zip |
Reading properties of components should not set state to dirty (#14060).
Many core vaadin components did incorrectly mark the state as dirty when
reading from them. This patch fixes the problem, which should reduce the
amount of server->client state updates significantly.
Change-Id: I342d74129e2985a7f407e9b53a802dc0146d9992
Diffstat (limited to 'server/src/com/vaadin/ui/Slider.java')
-rw-r--r-- | server/src/com/vaadin/ui/Slider.java | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/server/src/com/vaadin/ui/Slider.java b/server/src/com/vaadin/ui/Slider.java index e108c74ba2..ff6c955e47 100644 --- a/server/src/com/vaadin/ui/Slider.java +++ b/server/src/com/vaadin/ui/Slider.java @@ -144,13 +144,18 @@ public class Slider extends AbstractField<Double> { return (SliderState) super.getState(); } + @Override + public SliderState getState(boolean markAsDirty) { + return (SliderState) super.getState(markAsDirty); + } + /** * Gets the maximum slider value * * @return the largest value the slider can have */ public double getMax() { - return getState().maxValue; + return getState(false).maxValue; } /** @@ -173,7 +178,7 @@ public class Slider extends AbstractField<Double> { * @return the smallest value the slider can have */ public double getMin() { - return getState().minValue; + return getState(false).minValue; } /** @@ -197,7 +202,7 @@ public class Slider extends AbstractField<Double> { * {@link SliderOrientation#VERTICAL} */ public SliderOrientation getOrientation() { - return getState().orientation; + return getState(false).orientation; } /** @@ -219,7 +224,7 @@ public class Slider extends AbstractField<Double> { * @return resolution */ public int getResolution() { - return getState().resolution; + return getState(false).resolution; } /** |