aboutsummaryrefslogtreecommitdiffstats
path: root/server/src/com
diff options
context:
space:
mode:
authorLeif Åstrand <leif@vaadin.com>2013-05-17 16:38:25 +0300
committerLeif Åstrand <leif@vaadin.com>2013-05-17 16:39:02 +0300
commit4bc1f6e6bbf8d86e36973c47097a01dbf21dac3b (patch)
treeeec7c4c1b2d87782a34c846a6c4252881744d86c /server/src/com
parentf1b78432bf7e414c6823fb08b87b6a1c28c942bb (diff)
parent42545ac81ae49cb9a3af2a8b3b06ba9525886b22 (diff)
downloadvaadin-framework-4bc1f6e6bbf8d86e36973c47097a01dbf21dac3b.tar.gz
vaadin-framework-4bc1f6e6bbf8d86e36973c47097a01dbf21dac3b.zip
Merge changes from origin/7.1
29eeda5 Merge "Clean up Table popup menu close handler to prevent a memory leak" from 6.8 (#11840) 6d7f5e4 Eliminate unnecessary conversions of option keys b8c6a15 Clear items in ComboBox only if changed (#10924) 42545ac Fix NPE if there's no query in the URI (#11836) Change-Id: I211f8f2e0367588da17631219ebf6e69b02ea701
Diffstat (limited to 'server/src/com')
-rw-r--r--server/src/com/vaadin/ui/ComboBox.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/server/src/com/vaadin/ui/ComboBox.java b/server/src/com/vaadin/ui/ComboBox.java
index 0f42749acd..88e895df82 100644
--- a/server/src/com/vaadin/ui/ComboBox.java
+++ b/server/src/com/vaadin/ui/ComboBox.java
@@ -262,8 +262,8 @@ public class ComboBox extends AbstractSelect implements
target.addAttribute("nullselection", true);
}
target.addAttribute("key", key);
- if (isSelected(id) && keyIndex < selectedKeys.length) {
- target.addAttribute("selected", true);
+ if (keyIndex < selectedKeys.length && isSelected(id)) {
+ // at most one item can be selected at a time
selectedKeys[keyIndex++] = key;
}
target.endTag("so");