aboutsummaryrefslogtreecommitdiffstats
path: root/server/src/main
diff options
context:
space:
mode:
authorArtur <artur@vaadin.com>2017-03-07 09:46:33 +0200
committerHenri Sara <henri.sara@gmail.com>2017-03-16 12:32:19 +0200
commitc299a6bb4803bb132409fa2b9c0d4b45636a7a4c (patch)
tree86033447576e86ce6ea107840306a86aa7122d2f /server/src/main
parent330329efcec873314f7aca7e17c1009d401a7bfd (diff)
downloadvaadin-framework-c299a6bb4803bb132409fa2b9c0d4b45636a7a4c.tar.gz
vaadin-framework-c299a6bb4803bb132409fa2b9c0d4b45636a7a4c.zip
Handle unknown connectors consistently and quietly as described in #8111 (#8741)
Fixes #8629
Diffstat (limited to 'server/src/main')
-rw-r--r--server/src/main/java/com/vaadin/server/communication/ServerRpcHandler.java20
1 files changed, 14 insertions, 6 deletions
diff --git a/server/src/main/java/com/vaadin/server/communication/ServerRpcHandler.java b/server/src/main/java/com/vaadin/server/communication/ServerRpcHandler.java
index bee4720273..e4783cbf6e 100644
--- a/server/src/main/java/com/vaadin/server/communication/ServerRpcHandler.java
+++ b/server/src/main/java/com/vaadin/server/communication/ServerRpcHandler.java
@@ -350,11 +350,9 @@ public class ServerRpcHandler implements Serializable {
final ClientConnector connector = connectorTracker
.getConnector(invocation.getConnectorId());
if (connector == null) {
- getLogger().log(Level.WARNING,
- "Received RPC call for unknown connector with id {0} (tried to invoke {1}.{2})",
- new Object[] { invocation.getConnectorId(),
- invocation.getInterfaceName(),
- invocation.getMethodName() });
+ logUnknownConnector(invocation.getConnectorId(),
+ invocation.getInterfaceName(),
+ invocation.getMethodName());
continue;
}
@@ -423,6 +421,13 @@ public class ServerRpcHandler implements Serializable {
}
}
+ private void logUnknownConnector(String connectorId, String interfaceName,
+ String methodName) {
+ getLogger().log(Level.FINE,
+ "Received RPC call for unknown connector with id {0} (tried to invoke {1}.{2})",
+ new Object[] { connectorId, interfaceName, methodName });
+ }
+
/**
* Handles the given RPC method invocation for the given connector
*
@@ -575,7 +580,10 @@ public class ServerRpcHandler implements Serializable {
JsonArray parametersJson, ConnectorTracker connectorTracker)
throws JsonException {
ClientConnector connector = connectorTracker.getConnector(connectorId);
-
+ if (connector == null) {
+ logUnknownConnector(connectorId, interfaceName, methodName);
+ return null;
+ }
ServerRpcManager<?> rpcManager = connector.getRpcManager(interfaceName);
if (rpcManager == null) {
/*