diff options
author | Tatu Lund <tatu@vaadin.com> | 2019-11-12 09:30:15 +0200 |
---|---|---|
committer | Leif Åstrand <leif@vaadin.com> | 2019-11-12 09:30:15 +0200 |
commit | dc35fdec074e14a09b8efb82ce1068338bac155d (patch) | |
tree | f6353ee04ebe97e6773582ab738c4d72fd3a8439 /server/src/test | |
parent | fd1a8df74a6ddba0c2ff2862ee02f58deebdf6e1 (diff) | |
download | vaadin-framework-dc35fdec074e14a09b8efb82ce1068338bac155d.tar.gz vaadin-framework-dc35fdec074e14a09b8efb82ce1068338bac155d.zip |
Use APPLICATION_SCOPE for the session lock (#11792)
The Vaadin session itself is also stored in APPLICATION_SCOPE. The default
scope is PORTLET_SCOPE, so lock would be otherwise not be in sync with
the session.
To be able to do this, relevant methods in VaadinService are made protected so
that VaadinPortletService can override them.
Fixes #11611
Diffstat (limited to 'server/src/test')
-rw-r--r-- | server/src/test/java/com/vaadin/server/VaadinPortletServiceTest.java | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/server/src/test/java/com/vaadin/server/VaadinPortletServiceTest.java b/server/src/test/java/com/vaadin/server/VaadinPortletServiceTest.java index 2d7da64d20..2280e7d4f5 100644 --- a/server/src/test/java/com/vaadin/server/VaadinPortletServiceTest.java +++ b/server/src/test/java/com/vaadin/server/VaadinPortletServiceTest.java @@ -9,6 +9,8 @@ import static org.mockito.Mockito.when; import java.util.concurrent.locks.ReentrantLock; +import javax.portlet.PortletSession; + import org.junit.Before; import org.junit.Test; import org.mockito.Mockito; @@ -185,9 +187,9 @@ public class VaadinPortletServiceTest { ReentrantLock mockLock = Mockito.mock(ReentrantLock.class); when(mockLock.isHeldByCurrentThread()).thenReturn(true); - WrappedSession emptyWrappedSession = Mockito + WrappedPortletSession emptyWrappedSession = Mockito .mock(WrappedPortletSession.class); - when(emptyWrappedSession.getAttribute("null.lock")) + when(emptyWrappedSession.getAttribute("null.lock",PortletSession.APPLICATION_SCOPE)) .thenReturn(mockLock); VaadinRequest requestWithUIIDSet = Mockito .mock(VaadinRequest.class); |