diff options
author | Juuso Valli <juuso@vaadin.com> | 2014-04-23 16:19:18 +0300 |
---|---|---|
committer | Vaadin Code Review <review@vaadin.com> | 2014-04-23 13:38:51 +0000 |
commit | 716046af83ec05a44314a792648863646398d3b9 (patch) | |
tree | 298468607ddcee199199d3349dc698c50e6afee9 /server | |
parent | 2e58e97e5297c0e0c718df52ba1c4b30742f3c03 (diff) | |
download | vaadin-framework-716046af83ec05a44314a792648863646398d3b9.tar.gz vaadin-framework-716046af83ec05a44314a792648863646398d3b9.zip |
Clarify comments in Table.typeIsCompatible (#8168)
Change-Id: Idc9b2e2052afe2b5586904c535674ec686bb4685
Diffstat (limited to 'server')
-rw-r--r-- | server/src/com/vaadin/ui/Table.java | 18 |
1 files changed, 2 insertions, 16 deletions
diff --git a/server/src/com/vaadin/ui/Table.java b/server/src/com/vaadin/ui/Table.java index 00a7038afd..e23a1bf688 100644 --- a/server/src/com/vaadin/ui/Table.java +++ b/server/src/com/vaadin/ui/Table.java @@ -2775,22 +2775,8 @@ public class Table extends AbstractSelect implements Action.Container, */ private boolean typeIsCompatible(Class<?> a, Class<?> b) { // TODO Implement this check properly - // Map<Class<?>, Class<?>> typemap = new HashMap<Class<?>, Class<?>>(); - // typemap.put(byte.class, Byte.class); - // typemap.put(short.class, Short.class); - // typemap.put(int.class, Integer.class); - // typemap.put(long.class, Long.class); - // typemap.put(float.class, Float.class); - // typemap.put(double.class, Double.class); - // typemap.put(char.class, Character.class); - // typemap.put(boolean.class, Boolean.class); - // if (typemap.containsKey(a)) { - // a = typemap.get(a); - // } - // if (typemap.containsKey(b)) { - // b = typemap.get(b); - // } - // return a.isAssignableFrom(b); + // Basically we need to do a a.isAssignableFrom(b) + // with special considerations for primitive types. return true; } |