diff options
| author | Fabian Lange <lange.fabian@gmail.com> | 2013-07-14 16:38:26 +0200 |
|---|---|---|
| committer | Vaadin Code Review <review@vaadin.com> | 2013-07-15 05:27:23 +0000 |
| commit | 7f52b2e8221f58586b5c66dfa11b2bc2a79af204 (patch) | |
| tree | 2605566507b5c10096167755492ec6fc8f33a554 /server | |
| parent | 23ed4870339df44d02126fe53c431c8b6282f475 (diff) | |
| download | vaadin-framework-7f52b2e8221f58586b5c66dfa11b2bc2a79af204.tar.gz vaadin-framework-7f52b2e8221f58586b5c66dfa11b2bc2a79af204.zip | |
Improved AbstractClientConnector performance (#12219)
Avoiding duplicate lookup of connector hierarchy when a component shall be
marked dirty. Optimized if statement to fail fast.
Change-Id: I3ac82d64b235ebfd1888a6076c595f351018d887
Diffstat (limited to 'server')
| -rw-r--r-- | server/src/com/vaadin/server/AbstractClientConnector.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/server/src/com/vaadin/server/AbstractClientConnector.java b/server/src/com/vaadin/server/AbstractClientConnector.java index c3101924dd..91a9e41522 100644 --- a/server/src/com/vaadin/server/AbstractClientConnector.java +++ b/server/src/com/vaadin/server/AbstractClientConnector.java @@ -224,9 +224,9 @@ public abstract class AbstractClientConnector implements ClientConnector, } if (markAsDirty) { UI ui = getUI(); - if (ui != null && !ui.getConnectorTracker().isWritingResponse() - && !ui.getConnectorTracker().isDirty(this)) { - markAsDirty(); + if (ui != null && !ui.getConnectorTracker().isDirty(this) + && !ui.getConnectorTracker().isWritingResponse()) { + ui.getConnectorTracker().markDirty(this); } } return sharedState; |