aboutsummaryrefslogtreecommitdiffstats
path: root/server
diff options
context:
space:
mode:
authorArtur Signell <artur@vaadin.com>2013-11-11 16:33:27 +0200
committerArtur Signell <artur@vaadin.com>2013-11-11 16:33:27 +0200
commitdd7e6fee8c4717df59699f04f7e72a6f2e92008f (patch)
tree1d1e4e074b006d53977b6e8a77c9926b30b504db /server
parentf51b8911ad7d9ee8f651cf037e30a09e09a5e530 (diff)
parentc308d8a949095ec49a6933d2d4424d078fb4e210 (diff)
downloadvaadin-framework-dd7e6fee8c4717df59699f04f7e72a6f2e92008f.tar.gz
vaadin-framework-dd7e6fee8c4717df59699f04f7e72a6f2e92008f.zip
Merge changes from origin/7.1
30e9b7c Add a test for @mixin { @font-face {...} } (#11649) 0a2cf2c Prevent showing "Session Expired" notification if navigating away (#12298) 8efc385 Fixes NPE in TreeTable.setContainerDS(null) (#12928) 23815e6 Remove broken JSch check c308d8a Fixes double scrollbar issue in browserframes (#11780) Fixed by adding font-size 0 to the base theme. Change-Id: I64ae167e8e6b61205718998b80d534fb2cf0cb3d
Diffstat (limited to 'server')
-rw-r--r--server/src/com/vaadin/ui/TreeTable.java4
-rw-r--r--server/tests/src/com/vaadin/tests/server/component/treetable/TreeTableSetContainerNull.java15
2 files changed, 17 insertions, 2 deletions
diff --git a/server/src/com/vaadin/ui/TreeTable.java b/server/src/com/vaadin/ui/TreeTable.java
index e150db9423..1c13eae8d9 100644
--- a/server/src/com/vaadin/ui/TreeTable.java
+++ b/server/src/com/vaadin/ui/TreeTable.java
@@ -590,11 +590,11 @@ public class TreeTable extends Table implements Hierarchical {
// does not change component hierarchy during paint
containerSupportsPartialUpdates = (newDataSource instanceof ItemSetChangeNotifier) && false;
- if (!(newDataSource instanceof Hierarchical)) {
+ if (newDataSource != null && !(newDataSource instanceof Hierarchical)) {
newDataSource = new ContainerHierarchicalWrapper(newDataSource);
}
- if (!(newDataSource instanceof Ordered)) {
+ if (newDataSource != null && !(newDataSource instanceof Ordered)) {
newDataSource = new HierarchicalContainerOrderedWrapper(
(Hierarchical) newDataSource);
}
diff --git a/server/tests/src/com/vaadin/tests/server/component/treetable/TreeTableSetContainerNull.java b/server/tests/src/com/vaadin/tests/server/component/treetable/TreeTableSetContainerNull.java
new file mode 100644
index 0000000000..a3b79a14f0
--- /dev/null
+++ b/server/tests/src/com/vaadin/tests/server/component/treetable/TreeTableSetContainerNull.java
@@ -0,0 +1,15 @@
+package com.vaadin.tests.server.component.treetable;
+
+import junit.framework.TestCase;
+
+import com.vaadin.ui.TreeTable;
+
+public class TreeTableSetContainerNull extends TestCase {
+
+ public void testNullContainer() {
+ TreeTable treeTable = new TreeTable();
+
+ // should not cause an exception
+ treeTable.setContainerDataSource(null);
+ }
+}