summaryrefslogtreecommitdiffstats
path: root/server
diff options
context:
space:
mode:
authorTeemu Suo-Anttila <tsuoanttila@users.noreply.github.com>2018-04-17 17:40:59 +0300
committerIlia Motornyi <elmot@vaadin.com>2018-04-17 17:40:59 +0300
commit7c662a179ff996ad244eaf17ce19a84ac8ae5095 (patch)
tree257600b0f8b2c4dda1ebaf6cbc89fac7a8506bd8 /server
parent17aaea62289540c3315aec88b71428ecf18ea7e9 (diff)
downloadvaadin-framework-7c662a179ff996ad244eaf17ce19a84ac8ae5095.tar.gz
vaadin-framework-7c662a179ff996ad244eaf17ce19a84ac8ae5095.zip
Fix using ConnectorResource icons before attaching ComboBox (#10810)
* Fix using ConnectorResource icons before attaching ComboBox * Update Chrome and PhantomJS screenshots
Diffstat (limited to 'server')
-rw-r--r--server/src/main/java/com/vaadin/ui/ComboBox.java11
1 files changed, 11 insertions, 0 deletions
diff --git a/server/src/main/java/com/vaadin/ui/ComboBox.java b/server/src/main/java/com/vaadin/ui/ComboBox.java
index ef1e7cfa84..107e503256 100644
--- a/server/src/main/java/com/vaadin/ui/ComboBox.java
+++ b/server/src/main/java/com/vaadin/ui/ComboBox.java
@@ -842,6 +842,10 @@ public class ComboBox<T> extends AbstractSingleSelect<T>
Resource icon = getItemIconGenerator().apply(value);
if (icon != null) {
if (icon instanceof ConnectorResource) {
+ if (!isAttached()) {
+ // Deferred resource generation.
+ return;
+ }
setResource("selected", icon);
}
selectedItemIcon = ResourceReference
@@ -852,6 +856,13 @@ public class ComboBox<T> extends AbstractSingleSelect<T>
}
@Override
+ public void attach() {
+ super.attach();
+
+ updateSelectedItemIcon();
+ }
+
+ @Override
protected Element writeItem(Element design, T item, DesignContext context) {
Element element = design.appendElement("option");