diff options
| author | Johannes Dahlström <johannesd@vaadin.com> | 2013-12-16 13:08:02 +0200 |
|---|---|---|
| committer | Vaadin Code Review <review@vaadin.com> | 2013-12-16 17:29:05 +0000 |
| commit | 8245079252865d19a929c86bfd67cbe139259f18 (patch) | |
| tree | 3708868178dfdd891771e5cf24f4cf22bee4b7a8 /shared | |
| parent | 681864fee3c95dd281493f881db276b7b7abe87d (diff) | |
| download | vaadin-framework-8245079252865d19a929c86bfd67cbe139259f18.tar.gz vaadin-framework-8245079252865d19a929c86bfd67cbe139259f18.zip | |
Decrease the websocket buffer size due to a Jetty 9.1 issue (#13087)
Jetty 9.1 throws if InputBufferSize is set to greater than or equal to
MaxTextMessageBufferSize. We cannot simply increase the value of the latter
because Atmosphere sets the former first. Thus, its value must be set to
less than 32768 (the default for MaxTextMessageBufferSize). This should not
cause problems with regard to performance; the original figure of 65536
was more or less an arbitrary choice.
Change-Id: If9596fc2bffdd14e8c1f31ff4b9b10d6685e01ed
Diffstat (limited to 'shared')
| -rw-r--r-- | shared/src/com/vaadin/shared/communication/PushConstants.java | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/shared/src/com/vaadin/shared/communication/PushConstants.java b/shared/src/com/vaadin/shared/communication/PushConstants.java index f16cbb7390..4b4f247e5f 100644 --- a/shared/src/com/vaadin/shared/communication/PushConstants.java +++ b/shared/src/com/vaadin/shared/communication/PushConstants.java @@ -27,8 +27,11 @@ public class PushConstants implements Serializable { /** * The size, in <b>bytes</b>, of the receiving buffer used by some servers. + * <p> + * Should not be set to a value equal to or greater than 32768 due to a + * Jetty 9.1 issue (see #13087) */ - public static final int WEBSOCKET_BUFFER_SIZE = 65536; + public static final int WEBSOCKET_BUFFER_SIZE = 16384; /** * The maximum size, in <b>characters</b>, of a websocket message fragment. |