summaryrefslogtreecommitdiffstats
path: root/shared
diff options
context:
space:
mode:
authorPekka Hyvönen <pekka@vaadin.com>2017-02-16 10:14:38 +0200
committerHenri Sara <henri.sara@gmail.com>2017-02-16 12:38:08 +0200
commit30a1416da4fdbc13cde6662498690792808a87b7 (patch)
tree5bc666e9786eb4ac3d09641e8e363b03d9ac57da /shared
parent77ebc459d2ecb29dd8a85d386bfb35a40c263f1e (diff)
downloadvaadin-framework-30a1416da4fdbc13cde6662498690792808a87b7.tar.gz
vaadin-framework-30a1416da4fdbc13cde6662498690792808a87b7.zip
Reduce ComboBox initial requests (#8571)
* Reduce ComboBox initial requests Use initial fetched data on client side, do not request data from server side for each time popup is opened. Fixed initial filter being null for ComboBox on DataProvider, causing unnecessary size & fetch for not-changed filter. Fixed ComboBox sending default filter unnecessarily to server. Fixed wrong page indexing in VComboBox -> ComboBoxConnector. Fixes #8496 Fixes vaadin/framework8-issues#488 * Fix last item missing When pageLength was 0 and nullSelectionAllowed, the last item was not shown. Tried to sensify the API for total suggestions versus total suggestions + null selection item. * Fix ComboBox selected item updates Handles changing of ItemCaptionGenerator or ItemIconGenerator, need to update the selected item caption and icon separately. Previously it worked because all data was sent all the time to client. Doesn't fix the issue, when selected item is updated with refreshItem(), and it is not on the active range that will be sent to client. For that, ComboBox would need a separate notification about item update. * Updated screenshots
Diffstat (limited to 'shared')
-rw-r--r--shared/src/main/java/com/vaadin/shared/ui/combobox/ComboBoxState.java7
1 files changed, 7 insertions, 0 deletions
diff --git a/shared/src/main/java/com/vaadin/shared/ui/combobox/ComboBoxState.java b/shared/src/main/java/com/vaadin/shared/ui/combobox/ComboBoxState.java
index a7be4865a7..666fff1e58 100644
--- a/shared/src/main/java/com/vaadin/shared/ui/combobox/ComboBoxState.java
+++ b/shared/src/main/java/com/vaadin/shared/ui/combobox/ComboBoxState.java
@@ -93,4 +93,11 @@ public class ComboBoxState extends AbstractSingleSelectState {
*/
public String emptySelectionCaption = "";
+ /**
+ * Selected item icon uri.
+ *
+ * @since 8.0
+ */
+ public String selectedItemIcon;
+
}