Clean DropEvent and DragEndEvent properties (#8925)

* Add dropEffect parameter to DragEndEvent (#8895)

* Remove drop effect from drop event (#8895)

* Make sure that drop effect is not null

2 files changed, 6 insertions, 4 deletions

diff --git a/shared/src/main/java/com/vaadin/shared/ui/dnd/DragSourceRpc.java b/shared/src/main/java/com/vaadin/shared/ui/dnd/DragSourceRpc.java
index 178028b423..4faf7ca139 100644
--- a/shared/src/main/java/com/vaadin/shared/ui/dnd/DragSourceRpc.java
+++ b/shared/src/main/java/com/vaadin/shared/ui/dnd/DragSourceRpc.java
@@ -33,6 +33,10 @@ public interface DragSourceRpc extends ServerRpc {
 
     /**
      * Called when dragend event happens on client side.
+     *
+     * @param dropEffect
+     *         Drop effect of the dragend event, extracted from {@code
+     *         DataTransfer.dropEffect} parameter.
      */
-    public void dragEnd();
+    public void dragEnd(DropEffect dropEffect);
 }
diff --git a/shared/src/main/java/com/vaadin/shared/ui/dnd/DropTargetRpc.java b/shared/src/main/java/com/vaadin/shared/ui/dnd/DropTargetRpc.java
index b74fd3a949..7a608068a1 100644
--- a/shared/src/main/java/com/vaadin/shared/ui/dnd/DropTargetRpc.java
+++ b/shared/src/main/java/com/vaadin/shared/ui/dnd/DropTargetRpc.java
@@ -32,8 +32,6 @@ public interface DropTargetRpc extends ServerRpc {
      * @param dataTransferText
      *         Data of type {@code "text"} from the {@code DataTransfer}
      *         object.
-     * @param dropEffect
-     *         Drop effect set for the drop target where drop happened.
      */
-    public void drop(String dataTransferText, DropEffect dropEffect);
+    public void drop(String dataTransferText);
 }