1. Removed obsolete dependency framework methods and interface definitions.

2. "Undeprecated" reflection based listeners, we still wish to support these.
But I noted on javadoc that using these methods is discouraged and suggested better methods.


svn changeset:3718/svn branch:trunk

1 files changed, 10 insertions, 29 deletions

diff --git a/src/com/itmill/toolkit/ui/AbstractComponent.java b/src/com/itmill/toolkit/ui/AbstractComponent.java
index 3508266d91..07292b8859 100644
--- a/src/com/itmill/toolkit/ui/AbstractComponent.java
+++ b/src/com/itmill/toolkit/ui/AbstractComponent.java
@@ -11,7 +11,6 @@ import java.util.Iterator;
 import java.util.LinkedList;
 import java.util.Locale;
 import java.util.Map;
-import java.util.Set;
 
 import com.itmill.toolkit.Application;
 import com.itmill.toolkit.event.EventRouter;
@@ -20,7 +19,6 @@ import com.itmill.toolkit.terminal.ErrorMessage;
 import com.itmill.toolkit.terminal.PaintException;
 import com.itmill.toolkit.terminal.PaintTarget;
 import com.itmill.toolkit.terminal.Resource;
-import com.itmill.toolkit.terminal.VariableOwner;
 
 /**
  * An abstract class that defines default implementation for the
@@ -581,7 +579,6 @@ public abstract class AbstractComponent implements Component, MethodEventSource
      * here, we use the default documentation from implemented interface.
      */
     public final void paint(PaintTarget target) throws PaintException {
-
         if (!target.startTag(this, getTag()) || repaintRequestListenersNotified) {
 
             // Paint the contents of the component
@@ -667,7 +664,6 @@ public abstract class AbstractComponent implements Component, MethodEventSource
 
     /* Documentation copied from interface */
     public void childRequestedRepaint(Collection alreadyNotified) {
-
         // Invisible components do not need repaints
         if (!isVisible()) {
             return;
@@ -682,10 +678,8 @@ public abstract class AbstractComponent implements Component, MethodEventSource
      * @param alreadyNotified
      */
     private void fireRequestRepaintEvent(Collection alreadyNotified) {
-
         // Notify listeners only once
         if (!repaintRequestListenersNotified) {
-
             // Notify the listeners
             if (repaintRequestListeners != null
                     && !repaintRequestListeners.isEmpty()) {
@@ -740,18 +734,6 @@ public abstract class AbstractComponent implements Component, MethodEventSource
      * interface.
      */
     public void changeVariables(Object source, Map variables) {
-
-    }
-
-    /* Dependency -framework is deprecated */
-    public void dependsOn(VariableOwner depended) {
-    }
-
-    public void removeDirectDependency(VariableOwner depended) {
-    }
-
-    public Set getDirectDependencies() {
-        return null;
     }
 
     /* General event framework *************************************** */
@@ -800,10 +782,10 @@ public abstract class AbstractComponent implements Component, MethodEventSource
 
     /**
      * <p>
-     * Registers a new listener with the specified activation method to listen
-     * events generated by this component. If the activation method does not
-     * have any arguments the event object will not be passed to it when it's
-     * called.
+     * Convenience method for registering a new listener with the specified
+     * activation method to listen events generated by this component. If the
+     * activation method does not have any arguments the event object will not
+     * be passed to it when it's called.
      * </p>
      * 
      * <p>
@@ -818,6 +800,12 @@ public abstract class AbstractComponent implements Component, MethodEventSource
      * {@link com.itmill.toolkit.event com.itmill.toolkit.event package documentation}.
      * </p>
      * 
+     * <p>
+     * Note: Using this method is discouraged because it cannot be checked
+     * during compilation. Use {@link #addListener(Class, Object, Method)} or
+     * {@link #addListener(com.itmill.toolkit.ui.Component.Listener)} instead.
+     * </p>
+     * 
      * @param eventType
      *                the type of the listened event. Events of this type or its
      *                subclasses activate the listener.
@@ -825,10 +813,6 @@ public abstract class AbstractComponent implements Component, MethodEventSource
      *                the object instance who owns the activation method.
      * @param methodName
      *                the name of the activation method.
-     * @deprecated Use {@link #addListener(Class, Object, Method)} or
-     *             {@link #addListener(com.itmill.toolkit.ui.Component.Listener)}
-     *             instead. Using this method is discouraged because it cannot
-     *             be checked during compilation.
      */
     public void addListener(Class eventType, Object object, String methodName) {
         if (eventRouter == null) {
@@ -929,7 +913,6 @@ public abstract class AbstractComponent implements Component, MethodEventSource
      *                the Event to be sent to all listeners.
      */
     protected void fireEvent(Component.Event event) {
-
         if (eventRouter != null) {
             eventRouter.fireEvent(event);
         }
@@ -944,7 +927,6 @@ public abstract class AbstractComponent implements Component, MethodEventSource
      * implemented interface.
      */
     public void addListener(Component.Listener listener) {
-
         if (eventRouter == null) {
             eventRouter = new EventRouter();
         }
@@ -959,7 +941,6 @@ public abstract class AbstractComponent implements Component, MethodEventSource
      * interface.
      */
     public void removeListener(Component.Listener listener) {
-
         if (eventRouter != null) {
             eventRouter.removeListener(Component.Event.class, listener,
                     COMPONENT_EVENT_METHOD);