Partly eliminate the use of Property.toString().

The toString() method should not be used on a property to get its value.
Added getStringValue() to AbstractField, Label etc. Using them
where applicable. Added comments to some problematic locations where
Property.toString() is known to be used.

AbstractField.toString() and Label.toString() still return the same
values as before, but it will throw an exception in future revisions.

Migration needed: Replace explicit and implicit uses of
Property.toString() with use property.getValue() and its
string representation.
Alternatively, use AbstractProperty.getStringValue() and
AbstractField.getStringValue() instead of Property.toString() during
migration.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/com/vaadin/ui/AbstractTextField.java b/src/com/vaadin/ui/AbstractTextField.java
index 62904330c2..8d775c862e 100644
--- a/src/com/vaadin/ui/AbstractTextField.java
+++ b/src/com/vaadin/ui/AbstractTextField.java
@@ -373,7 +373,7 @@ public abstract class AbstractTextField extends AbstractField implements
 
     @Override
     protected boolean isEmpty() {
-        return super.isEmpty() || toString().length() == 0;
+        return super.isEmpty() || getStringValue().length() == 0;
     }
 
     /**
@@ -751,4 +751,4 @@ public abstract class AbstractTextField extends AbstractField implements
         removeListener(BlurEvent.EVENT_ID, BlurEvent.class, listener);
     }
 
-}
\ No newline at end of file
+}