diff options
author | Jens Jansson <peppe@vaadin.com> | 2012-01-18 15:16:12 +0200 |
---|---|---|
committer | Jens Jansson <peppe@vaadin.com> | 2012-01-18 15:16:12 +0200 |
commit | 2b29b8298054617fef7e6a170b47a75d689be645 (patch) | |
tree | 4d80cc7f07ef2481d0709a69e6561b815e6bfb44 /src/com/vaadin/ui/Table.java | |
parent | 838d3f7120ae41b84a8894f7cab64ee09f3c74e4 (diff) | |
download | vaadin-framework-2b29b8298054617fef7e6a170b47a75d689be645.tar.gz vaadin-framework-2b29b8298054617fef7e6a170b47a75d689be645.zip |
#8019 Did a bunch of null checks for possible faulty null states which was not possible when we still used primitives.
Diffstat (limited to 'src/com/vaadin/ui/Table.java')
-rw-r--r-- | src/com/vaadin/ui/Table.java | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/com/vaadin/ui/Table.java b/src/com/vaadin/ui/Table.java index a51344b00f..ccc68e06b0 100644 --- a/src/com/vaadin/ui/Table.java +++ b/src/com/vaadin/ui/Table.java @@ -1058,13 +1058,13 @@ public class Table extends AbstractSelect implements Action.Container, * @return the header for the specified column if it has one. */ public String getColumnHeader(Object propertyId) { - if (getColumnHeaderMode() == COLUMN_HEADER_MODE_HIDDEN) { + if (getColumnHeaderMode() == ColumnHeaderMode.HIDDEN) { return null; } String header = columnHeaders.get(propertyId); - if ((header == null && getColumnHeaderMode() == COLUMN_HEADER_MODE_EXPLICIT_DEFAULTS_ID) - || getColumnHeaderMode() == COLUMN_HEADER_MODE_ID) { + if ((header == null && getColumnHeaderMode() == ColumnHeaderMode.EXPLICIT_DEFAULTS_ID) + || getColumnHeaderMode() == ColumnHeaderMode.ID) { header = propertyId.toString(); } @@ -1432,6 +1432,9 @@ public class Table extends AbstractSelect implements Action.Container, * the New value of property columnHeaderMode. */ public void setColumnHeaderMode(ColumnHeaderMode columnHeaderMode) { + if(columnHeaderMode == null){ + throw new IllegalArgumentException("Column header mode can not be null"); + } if (columnHeaderMode != this.columnHeaderMode) { this.columnHeaderMode = columnHeaderMode; requestRepaint(); @@ -2950,7 +2953,7 @@ public class Table extends AbstractSelect implements Action.Container, } private boolean areColumnHeadersEnabled() { - return getColumnHeaderMode() != COLUMN_HEADER_MODE_HIDDEN; + return getColumnHeaderMode() != ColumnHeaderMode.HIDDEN; } private void paintVisibleColumns(PaintTarget target) throws PaintException { |